From b4412ab3c8de165551e0aa2ad093532aa093ffde Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Rapha=C3=ABl=20Bosi?= <71827178+bosiraphael@users.noreply.github.com> Date: Tue, 18 Mar 2025 17:00:56 +0100 Subject: [PATCH] Fix workflow id not being set (#10989) The workflow id was not set inside `WorkflowRunVisualizerEffect` and `WorkflowVersionVisualizerEffect` this PR fixes this --- .../components/WorkflowRunVisualizerEffect.tsx | 9 +++++++++ .../components/WorkflowVersionVisualizerEffect.tsx | 6 +++++- 2 files changed, 14 insertions(+), 1 deletion(-) diff --git a/packages/twenty-front/src/modules/workflow/workflow-diagram/components/WorkflowRunVisualizerEffect.tsx b/packages/twenty-front/src/modules/workflow/workflow-diagram/components/WorkflowRunVisualizerEffect.tsx index 293d7452d..1f5987de1 100644 --- a/packages/twenty-front/src/modules/workflow/workflow-diagram/components/WorkflowRunVisualizerEffect.tsx +++ b/packages/twenty-front/src/modules/workflow/workflow-diagram/components/WorkflowRunVisualizerEffect.tsx @@ -2,6 +2,7 @@ import { useStepsOutputSchema } from '@/workflow/hooks/useStepsOutputSchema'; import { useWorkflowRun } from '@/workflow/hooks/useWorkflowRun'; import { useWorkflowVersion } from '@/workflow/hooks/useWorkflowVersion'; import { flowState } from '@/workflow/states/flowState'; +import { workflowIdState } from '@/workflow/states/workflowIdState'; import { workflowRunIdState } from '@/workflow/states/workflowRunIdState'; import { workflowDiagramState } from '@/workflow/workflow-diagram/states/workflowDiagramState'; import { generateWorkflowRunDiagram } from '@/workflow/workflow-diagram/utils/generateWorkflowRunDiagram'; @@ -18,6 +19,7 @@ export const WorkflowRunVisualizerEffect = ({ const workflowVersion = useWorkflowVersion(workflowRun?.workflowVersionId); const setWorkflowRunId = useSetRecoilState(workflowRunIdState); + const setWorkflowId = useSetRecoilState(workflowIdState); const setFlow = useSetRecoilState(flowState); const setWorkflowDiagram = useSetRecoilState(workflowDiagramState); const { populateStepsOutputSchema } = useStepsOutputSchema(); @@ -26,6 +28,13 @@ export const WorkflowRunVisualizerEffect = ({ setWorkflowRunId(workflowRunId); }, [setWorkflowRunId, workflowRunId]); + useEffect(() => { + if (!isDefined(workflowVersion)) { + return; + } + setWorkflowId(workflowVersion.workflowId); + }, [setWorkflowId, workflowVersion]); + useEffect(() => { if (!isDefined(workflowRun?.output)) { setFlow(undefined); diff --git a/packages/twenty-front/src/modules/workflow/workflow-diagram/components/WorkflowVersionVisualizerEffect.tsx b/packages/twenty-front/src/modules/workflow/workflow-diagram/components/WorkflowVersionVisualizerEffect.tsx index 6db6572ca..d61025456 100644 --- a/packages/twenty-front/src/modules/workflow/workflow-diagram/components/WorkflowVersionVisualizerEffect.tsx +++ b/packages/twenty-front/src/modules/workflow/workflow-diagram/components/WorkflowVersionVisualizerEffect.tsx @@ -1,6 +1,7 @@ import { useStepsOutputSchema } from '@/workflow/hooks/useStepsOutputSchema'; import { useWorkflowVersion } from '@/workflow/hooks/useWorkflowVersion'; import { flowState } from '@/workflow/states/flowState'; +import { workflowIdState } from '@/workflow/states/workflowIdState'; import { workflowDiagramState } from '@/workflow/workflow-diagram/states/workflowDiagramState'; import { getWorkflowVersionDiagram } from '@/workflow/workflow-diagram/utils/getWorkflowVersionDiagram'; import { useEffect } from 'react'; @@ -16,6 +17,7 @@ export const WorkflowVersionVisualizerEffect = ({ const setFlow = useSetRecoilState(flowState); const setWorkflowDiagram = useSetRecoilState(workflowDiagramState); + const setWorkflowId = useSetRecoilState(workflowIdState); const { populateStepsOutputSchema } = useStepsOutputSchema(); useEffect(() => { if (!isDefined(workflowVersion)) { @@ -29,7 +31,9 @@ export const WorkflowVersionVisualizerEffect = ({ trigger: workflowVersion.trigger, steps: workflowVersion.steps, }); - }, [setFlow, workflowVersion]); + + setWorkflowId(workflowVersion.workflowId); + }, [setFlow, setWorkflowId, workflowVersion]); useEffect(() => { if (!isDefined(workflowVersion)) {