From b80a270e9d7cd743033c61de4ef7b933703bfa20 Mon Sep 17 00:00:00 2001 From: Guillim Date: Mon, 2 Jun 2025 15:15:49 +0200 Subject: [PATCH] adding new error codes to the temporary catch (#12366) For microsoft, examples of errors from the logs: Screenshot 2025-05-28 at 18 02 48 Fixes https://github.com/twentyhq/twenty/issues/12252 --- .../parse-gmail-message-list-fetch-error.util.ts | 14 ++++++++++++++ .../parse-gmail-messages-import-error.util.ts | 7 ++++++- .../utils/parse-microsoft-messages-import.util.ts | 6 +++++- 3 files changed, 25 insertions(+), 2 deletions(-) diff --git a/packages/twenty-server/src/modules/messaging/message-import-manager/drivers/gmail/utils/parse-gmail-message-list-fetch-error.util.ts b/packages/twenty-server/src/modules/messaging/message-import-manager/drivers/gmail/utils/parse-gmail-message-list-fetch-error.util.ts index 3ca37819e..614538285 100644 --- a/packages/twenty-server/src/modules/messaging/message-import-manager/drivers/gmail/utils/parse-gmail-message-list-fetch-error.util.ts +++ b/packages/twenty-server/src/modules/messaging/message-import-manager/drivers/gmail/utils/parse-gmail-message-list-fetch-error.util.ts @@ -80,7 +80,15 @@ export const parseGmailMessageListFetchError = (error: { MessageImportDriverExceptionCode.INSUFFICIENT_PERMISSIONS, ); + case 503: + return new MessageImportDriverException( + message, + MessageImportDriverExceptionCode.TEMPORARY_ERROR, + ); + case 500: + case 502: + case 504: if (reason === 'backendError') { return new MessageImportDriverException( message, @@ -88,6 +96,12 @@ export const parseGmailMessageListFetchError = (error: { ); } + if (errors?.[0]?.message.includes(`Authentication backend unavailable`)) { + return new MessageImportDriverException( + `${code} - ${reason} - ${message}`, + MessageImportDriverExceptionCode.TEMPORARY_ERROR, + ); + } break; default: diff --git a/packages/twenty-server/src/modules/messaging/message-import-manager/drivers/gmail/utils/parse-gmail-messages-import-error.util.ts b/packages/twenty-server/src/modules/messaging/message-import-manager/drivers/gmail/utils/parse-gmail-messages-import-error.util.ts index 2dbc1eeb3..e4ed11dac 100644 --- a/packages/twenty-server/src/modules/messaging/message-import-manager/drivers/gmail/utils/parse-gmail-messages-import-error.util.ts +++ b/packages/twenty-server/src/modules/messaging/message-import-manager/drivers/gmail/utils/parse-gmail-messages-import-error.util.ts @@ -82,9 +82,14 @@ export const parseGmailMessagesImportError = ( MessageImportDriverExceptionCode.INSUFFICIENT_PERMISSIONS, ); + case 503: + return new MessageImportDriverException( + message, + MessageImportDriverExceptionCode.TEMPORARY_ERROR, + ); + case 500: case 502: - case 503: case 504: if (reason === 'backendError') { return new MessageImportDriverException( diff --git a/packages/twenty-server/src/modules/messaging/message-import-manager/drivers/microsoft/utils/parse-microsoft-messages-import.util.ts b/packages/twenty-server/src/modules/messaging/message-import-manager/drivers/microsoft/utils/parse-microsoft-messages-import.util.ts index ac443a89f..2a3bbd072 100644 --- a/packages/twenty-server/src/modules/messaging/message-import-manager/drivers/microsoft/utils/parse-microsoft-messages-import.util.ts +++ b/packages/twenty-server/src/modules/messaging/message-import-manager/drivers/microsoft/utils/parse-microsoft-messages-import.util.ts @@ -40,7 +40,11 @@ export const parseMicrosoftMessagesImportError = (error: { } } - if (error.statusCode === 429 || error.statusCode === 503) { + if ( + error.statusCode === 429 || + error.statusCode === 503 || + error.statusCode === 509 + ) { return new MessageImportDriverException( `Microsoft Graph API ${error.code} ${error.statusCode} error: ${error.message}`, MessageImportDriverExceptionCode.TEMPORARY_ERROR,