added typechecking for all ts files (#6466)

Fixes: #6436 

Changes made: 

- Added typecheck step before twenty-ui build to check stories TS errors
- Added a tsconfig.dev.json to add stories and tests to typecheking when
in dev mode
- Added tsconfig.dev.json to storybook dev command of twenty-ui to
typecheck stories while developing
- Fixed twenty-ui stories that were broken

- Added a serve command to serve front build
- Fixed unit test from another PR

---------

Co-authored-by: Félix Malfait <felix.malfait@gmail.com>
Co-authored-by: Lucas Bordeau <bordeau.lucas@gmail.com>

packages/twenty-front/project.json

@@ -10,6 +10,12 @@
         "outputPath": "{projectRoot}/build"
       }
     },
+    "serve": {
+      "executor": "nx:run-commands",
+      "options": {
+        "command": "npx serve -s {projectRoot}/build"
+      }
+    },
     "start": {
       "executor": "@nx/vite:dev-server",
       "options": {

packages/twenty-front/src/modules/ui/display/status/components/__stories__/Status.stories.tsx

@@ -15,6 +15,7 @@ const meta: Meta<typeof Status> = {
   component: Status,
   args: {
     text: 'Urgent',
+    weight: 'medium',
   },
 };
 

packages/twenty-front/src/utils/__tests__/title-utils.test.ts

@@ -9,10 +9,6 @@ describe('title-utils', () => {
     expect(getPageTitleFromPath('/invite/:workspaceInviteHash')).toBe('Invite');
     expect(getPageTitleFromPath('/create/workspace')).toBe('Create Workspace');
     expect(getPageTitleFromPath('/create/profile')).toBe('Create Profile');
-    expect(getPageTitleFromPath('/tasks')).toBe('Tasks');
-    expect(getPageTitleFromPath('/objects/opportunities')).toBe(
-      'Opportunities',
-    );
     expect(getPageTitleFromPath('/settings/objects/opportunities')).toBe(
       SettingsPageTitles.Objects,
     );

packages/twenty-front/tsconfig.dev.json

@@ -0,0 +1,13 @@
+{
+  "extends": "./tsconfig.json",
+  "compilerOptions": {
+    "types": ["node"]
+  },
+  "include": [
+    "src/**/*.js",
+    "src/**/*.jsx",
+    "src/**/*.d.ts",
+    "src/**/*.ts",
+    "src/**/*.tsx"
+  ]
+}

packages/twenty-front/tsconfig.json

@@ -32,7 +32,10 @@
   "include": [],
   "references": [
     {
-      "path": "./tsconfig.app.json"
+      "path": "./tsconfig.dev.json"
+    },
+    {
+      "path": "./tsconfig.build.json"
     },
     {
       "path": "./tsconfig.spec.json"
@@ -42,4 +45,4 @@
     }
   ],
   "extends": "../../tsconfig.base.json"
-}
+}

packages/twenty-front/vite.config.ts

@@ -19,9 +19,13 @@ export default defineConfig(({ command, mode }) => {
 
   const isBuildCommand = command === 'build';
 
+  const tsConfigPath = isBuildCommand
+    ? path.resolve(__dirname, './tsconfig.build.json')
+    : path.resolve(__dirname, './tsconfig.dev.json');
+
   const checkers: Checkers = {
     typescript: {
-      tsconfigPath: path.resolve(__dirname, './tsconfig.app.json'),
+      tsconfigPath: tsConfigPath,
     },
     overlay: false,
   };