From be947bdc8f10e0f1b52674a04bec396195bed251 Mon Sep 17 00:00:00 2001
From: Sammy Teillet <sammy.teillet@gmail.com>
Date: Mon, 24 Apr 2023 14:02:38 +0200
Subject: [PATCH] refactor: strongly type keys of sorts

---
 front/src/components/table/table-header/SortAndFilterBar.tsx | 4 ++--
 front/src/pages/people/People.tsx                            | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/front/src/components/table/table-header/SortAndFilterBar.tsx b/front/src/components/table/table-header/SortAndFilterBar.tsx
index df2e09ab4..1e028fc3d 100644
--- a/front/src/components/table/table-header/SortAndFilterBar.tsx
+++ b/front/src/components/table/table-header/SortAndFilterBar.tsx
@@ -8,10 +8,10 @@ type OwnProps = {
   onRemoveSort: (sortId: string) => void;
 };
 
-export type SortType = {
+export type SortType<SortIds = string> = {
   label: string;
   order: 'asc' | 'desc';
-  id: string;
+  id: SortIds;
   icon?: IconProp;
 };
 
diff --git a/front/src/pages/people/People.tsx b/front/src/pages/people/People.tsx
index 72c701ff1..0678495ee 100644
--- a/front/src/pages/people/People.tsx
+++ b/front/src/pages/people/People.tsx
@@ -3,7 +3,7 @@ import WithTopBarContainer from '../../layout/containers/WithTopBarContainer';
 import Table from '../../components/table/Table';
 import styled from '@emotion/styled';
 import { peopleColumns } from './people-table';
-import { mapPerson } from '../../interfaces/person.interface';
+import { GraphqlPerson, mapPerson } from '../../interfaces/person.interface';
 import { useState } from 'react';
 import { SortType } from '../../components/table/table-header/SortAndFilterBar';
 import { OrderBy, usePeopleQuery } from '../../services/people';
@@ -38,7 +38,7 @@ function People() {
 
   const { data } = usePeopleQuery(orderBy);
 
-  const sortsAvailable: Array<SortType> = [
+  const sortsAvailable: Array<SortType<keyof GraphqlPerson>> = [
     {
       id: 'created_at',
       label: 'Created at',