relation-integration-tests (#13113)
This commit is contained in:
Guillim
@ -0,0 +1,187 @@
|
||||
// Jest Snapshot v1, https://goo.gl/fbAQLP
|
||||
|
||||
exports[`Field metadata morph relation creation should fail relation MANY_TO_ONE when targetFieldLabel conflicts with an existing field on target object metadata id 1`] = `
|
||||
[
|
||||
{
|
||||
"extensions": {
|
||||
"code": "BAD_USER_INPUT",
|
||||
"userFriendlyMessage": "An error occurred.",
|
||||
},
|
||||
"message": "Name "collisionfieldlabel" is not available",
|
||||
"name": "UserInputError",
|
||||
},
|
||||
]
|
||||
`;
|
||||
|
||||
exports[`Field metadata morph relation creation should fail relation MANY_TO_ONE when targetFieldLabel contains only whitespace 1`] = `
|
||||
[
|
||||
{
|
||||
"extensions": {
|
||||
"code": "BAD_USER_INPUT",
|
||||
"userFriendlyMessage": "An error occurred.",
|
||||
},
|
||||
"message": "Invalid label: " "",
|
||||
"name": "UserInputError",
|
||||
},
|
||||
]
|
||||
`;
|
||||
|
||||
exports[`Field metadata morph relation creation should fail relation MANY_TO_ONE when targetFieldLabel exceeds maximum length 1`] = `
|
||||
[
|
||||
{
|
||||
"extensions": {
|
||||
"code": "BAD_USER_INPUT",
|
||||
"userFriendlyMessage": "An error occurred.",
|
||||
},
|
||||
"message": "Name is too long: it exceeds the 63 characters limit.",
|
||||
"name": "UserInputError",
|
||||
},
|
||||
]
|
||||
`;
|
||||
|
||||
exports[`Field metadata morph relation creation should fail relation MANY_TO_ONE when targetFieldLabel is empty 1`] = `
|
||||
[
|
||||
{
|
||||
"extensions": {
|
||||
"code": "BAD_USER_INPUT",
|
||||
"userFriendlyMessage": "An error occurred.",
|
||||
},
|
||||
"message": "Input is too short: """,
|
||||
"name": "UserInputError",
|
||||
},
|
||||
]
|
||||
`;
|
||||
|
||||
exports[`Field metadata morph relation creation should fail relation MANY_TO_ONE when targetObjectMetadataId is unknown 1`] = `
|
||||
[
|
||||
{
|
||||
"extensions": {
|
||||
"code": "INTERNAL_SERVER_ERROR",
|
||||
"exceptionEventId": "mocked-exception-id",
|
||||
"userFriendlyMessage": "An error occurred.",
|
||||
},
|
||||
"message": "Object metadata relation target not found for relation creation payload",
|
||||
},
|
||||
]
|
||||
`;
|
||||
|
||||
exports[`Field metadata morph relation creation should fail relation MANY_TO_ONE when type is a wrong value 1`] = `
|
||||
[
|
||||
{
|
||||
"extensions": {
|
||||
"code": "BAD_USER_INPUT",
|
||||
"subCode": "INVALID_FIELD_INPUT",
|
||||
"userFriendlyMessage": "An error occurred.",
|
||||
},
|
||||
"message": "Relation creation payload is invalid: type must be one of the following values: ONE_TO_MANY, MANY_TO_ONE",
|
||||
"name": "UserInputError",
|
||||
},
|
||||
]
|
||||
`;
|
||||
|
||||
exports[`Field metadata morph relation creation should fail relation MANY_TO_ONE when type is not provided 1`] = `
|
||||
[
|
||||
{
|
||||
"extensions": {
|
||||
"code": "BAD_USER_INPUT",
|
||||
"subCode": "INVALID_FIELD_INPUT",
|
||||
"userFriendlyMessage": "An error occurred.",
|
||||
},
|
||||
"message": "Relation creation payload is invalid: type must be one of the following values: ONE_TO_MANY, MANY_TO_ONE",
|
||||
"name": "UserInputError",
|
||||
},
|
||||
]
|
||||
`;
|
||||
|
||||
exports[`Field metadata morph relation creation should fail relation ONE_TO_MANY when targetFieldLabel conflicts with an existing field on target object metadata id 1`] = `
|
||||
[
|
||||
{
|
||||
"extensions": {
|
||||
"code": "BAD_USER_INPUT",
|
||||
"userFriendlyMessage": "An error occurred.",
|
||||
},
|
||||
"message": "Name "collisionfieldlabel" is not available",
|
||||
"name": "UserInputError",
|
||||
},
|
||||
]
|
||||
`;
|
||||
|
||||
exports[`Field metadata morph relation creation should fail relation ONE_TO_MANY when targetFieldLabel contains only whitespace 1`] = `
|
||||
[
|
||||
{
|
||||
"extensions": {
|
||||
"code": "BAD_USER_INPUT",
|
||||
"userFriendlyMessage": "An error occurred.",
|
||||
},
|
||||
"message": "Invalid label: " "",
|
||||
"name": "UserInputError",
|
||||
},
|
||||
]
|
||||
`;
|
||||
|
||||
exports[`Field metadata morph relation creation should fail relation ONE_TO_MANY when targetFieldLabel exceeds maximum length 1`] = `
|
||||
[
|
||||
{
|
||||
"extensions": {
|
||||
"code": "BAD_USER_INPUT",
|
||||
"userFriendlyMessage": "An error occurred.",
|
||||
},
|
||||
"message": "Name is too long: it exceeds the 63 characters limit.",
|
||||
"name": "UserInputError",
|
||||
},
|
||||
]
|
||||
`;
|
||||
|
||||
exports[`Field metadata morph relation creation should fail relation ONE_TO_MANY when targetFieldLabel is empty 1`] = `
|
||||
[
|
||||
{
|
||||
"extensions": {
|
||||
"code": "BAD_USER_INPUT",
|
||||
"userFriendlyMessage": "An error occurred.",
|
||||
},
|
||||
"message": "Input is too short: """,
|
||||
"name": "UserInputError",
|
||||
},
|
||||
]
|
||||
`;
|
||||
|
||||
exports[`Field metadata morph relation creation should fail relation ONE_TO_MANY when targetObjectMetadataId is unknown 1`] = `
|
||||
[
|
||||
{
|
||||
"extensions": {
|
||||
"code": "INTERNAL_SERVER_ERROR",
|
||||
"exceptionEventId": "mocked-exception-id",
|
||||
"userFriendlyMessage": "An error occurred.",
|
||||
},
|
||||
"message": "Object metadata relation target not found for relation creation payload",
|
||||
},
|
||||
]
|
||||
`;
|
||||
|
||||
exports[`Field metadata morph relation creation should fail relation ONE_TO_MANY when type is a wrong value 1`] = `
|
||||
[
|
||||
{
|
||||
"extensions": {
|
||||
"code": "BAD_USER_INPUT",
|
||||
"subCode": "INVALID_FIELD_INPUT",
|
||||
"userFriendlyMessage": "An error occurred.",
|
||||
},
|
||||
"message": "Relation creation payload is invalid: type must be one of the following values: ONE_TO_MANY, MANY_TO_ONE",
|
||||
"name": "UserInputError",
|
||||
},
|
||||
]
|
||||
`;
|
||||
|
||||
exports[`Field metadata morph relation creation should fail relation ONE_TO_MANY when type is not provided 1`] = `
|
||||
[
|
||||
{
|
||||
"extensions": {
|
||||
"code": "BAD_USER_INPUT",
|
||||
"subCode": "INVALID_FIELD_INPUT",
|
||||
"userFriendlyMessage": "An error occurred.",
|
||||
},
|
||||
"message": "Relation creation payload is invalid: type must be one of the following values: ONE_TO_MANY, MANY_TO_ONE",
|
||||
"name": "UserInputError",
|
||||
},
|
||||
]
|
||||
`;
|
||||
@ -0,0 +1,171 @@
|
||||
import { deleteOneFieldMetadata } from 'test/integration/metadata/suites/field-metadata/utils/delete-one-field-metadata.util';
|
||||
import { createMorphRelationBetweenObjects } from 'test/integration/metadata/suites/object-metadata/utils/create-morph-relation-between-objects.util';
|
||||
import { createOneObjectMetadata } from 'test/integration/metadata/suites/object-metadata/utils/create-one-object-metadata.util';
|
||||
import { deleteOneObjectMetadata } from 'test/integration/metadata/suites/object-metadata/utils/delete-one-object-metadata.util';
|
||||
import { EachTestingContext } from 'twenty-shared/testing';
|
||||
import { FieldMetadataType } from 'twenty-shared/types';
|
||||
|
||||
import { RelationType } from 'src/engine/metadata-modules/field-metadata/interfaces/relation-type.interface';
|
||||
|
||||
describe('createOne FieldMetadataService morph relation fields', () => {
|
||||
let createdObjectMetadataPersonId = '';
|
||||
let createdObjectMetadataOpportunityId = '';
|
||||
let createdObjectMetadataCompanyId = '';
|
||||
|
||||
beforeEach(async () => {
|
||||
const {
|
||||
data: {
|
||||
createOneObject: { id: objectMetadataPersonId },
|
||||
},
|
||||
} = await createOneObjectMetadata({
|
||||
input: {
|
||||
nameSingular: 'personForMorphRelation',
|
||||
namePlural: 'peopleForMorphRelation',
|
||||
labelSingular: 'Person For Morph Relation',
|
||||
labelPlural: 'People For Morph Relation',
|
||||
icon: 'IconPerson',
|
||||
},
|
||||
});
|
||||
|
||||
createdObjectMetadataPersonId = objectMetadataPersonId;
|
||||
|
||||
const {
|
||||
data: {
|
||||
createOneObject: { id: objectMetadataCompanyId },
|
||||
},
|
||||
} = await createOneObjectMetadata({
|
||||
input: {
|
||||
nameSingular: 'companyForMorphRelation',
|
||||
namePlural: 'companiesForMorphRelation',
|
||||
labelSingular: 'Company For Morph Relation',
|
||||
labelPlural: 'Companies For Morph Relation',
|
||||
icon: 'IconCompany',
|
||||
},
|
||||
});
|
||||
|
||||
createdObjectMetadataCompanyId = objectMetadataCompanyId;
|
||||
|
||||
const {
|
||||
data: {
|
||||
createOneObject: { id: objectMetadataOpportunityId },
|
||||
},
|
||||
} = await createOneObjectMetadata({
|
||||
input: {
|
||||
nameSingular: 'opportunityForMorphRelation',
|
||||
namePlural: 'opportunitiesForMorphRelation',
|
||||
labelSingular: 'Opportunity For Morph Relation',
|
||||
labelPlural: 'Opportunities For Morph Relation',
|
||||
icon: 'IconOpportunity',
|
||||
},
|
||||
});
|
||||
|
||||
createdObjectMetadataOpportunityId = objectMetadataOpportunityId;
|
||||
});
|
||||
afterEach(async () => {
|
||||
await deleteOneObjectMetadata({
|
||||
input: { idToDelete: createdObjectMetadataPersonId },
|
||||
});
|
||||
await deleteOneObjectMetadata({
|
||||
input: { idToDelete: createdObjectMetadataOpportunityId },
|
||||
});
|
||||
await deleteOneObjectMetadata({
|
||||
input: { idToDelete: createdObjectMetadataCompanyId },
|
||||
});
|
||||
});
|
||||
|
||||
type EachTestingContextArray = EachTestingContext<
|
||||
| {
|
||||
relationType: RelationType;
|
||||
objectMetadataId: string;
|
||||
firstTargetObjectMetadataId: string;
|
||||
secondTargetObjectMetadataId: string;
|
||||
type: FieldMetadataType;
|
||||
}
|
||||
| ((args: {
|
||||
objectMetadataId: string;
|
||||
firstTargetObjectMetadataId: string;
|
||||
secondTargetObjectMetadataId: string;
|
||||
}) => {
|
||||
relationType: RelationType;
|
||||
objectMetadataId: string;
|
||||
firstTargetObjectMetadataId: string;
|
||||
secondTargetObjectMetadataId: string;
|
||||
type: FieldMetadataType;
|
||||
})
|
||||
>[];
|
||||
|
||||
const eachTestingContextArray: EachTestingContextArray = [
|
||||
{
|
||||
title: 'should create a MORPH_RELATION field type MANY_TO_ONE',
|
||||
context: ({
|
||||
objectMetadataId,
|
||||
firstTargetObjectMetadataId,
|
||||
secondTargetObjectMetadataId,
|
||||
}) => ({
|
||||
relationType: RelationType.MANY_TO_ONE,
|
||||
objectMetadataId,
|
||||
firstTargetObjectMetadataId,
|
||||
secondTargetObjectMetadataId,
|
||||
type: FieldMetadataType.MORPH_RELATION,
|
||||
}),
|
||||
},
|
||||
{
|
||||
title: 'should create a MORPH_RELATION field type ONE_TO_MANY',
|
||||
context: ({
|
||||
objectMetadataId,
|
||||
firstTargetObjectMetadataId,
|
||||
secondTargetObjectMetadataId,
|
||||
}) => ({
|
||||
relationType: RelationType.ONE_TO_MANY,
|
||||
objectMetadataId,
|
||||
firstTargetObjectMetadataId,
|
||||
secondTargetObjectMetadataId,
|
||||
type: FieldMetadataType.MORPH_RELATION,
|
||||
}),
|
||||
},
|
||||
];
|
||||
|
||||
it.each(eachTestingContextArray)('$title', async ({ context }) => {
|
||||
const contextPayload =
|
||||
typeof context === 'function'
|
||||
? context({
|
||||
objectMetadataId: createdObjectMetadataOpportunityId,
|
||||
firstTargetObjectMetadataId: createdObjectMetadataPersonId,
|
||||
secondTargetObjectMetadataId: createdObjectMetadataCompanyId,
|
||||
})
|
||||
: context;
|
||||
|
||||
const createdField = await createMorphRelationBetweenObjects({
|
||||
objectMetadataId: contextPayload.objectMetadataId,
|
||||
firstTargetObjectMetadataId: contextPayload.firstTargetObjectMetadataId,
|
||||
secondTargetObjectMetadataId: contextPayload.secondTargetObjectMetadataId,
|
||||
type: contextPayload.type,
|
||||
relationType: contextPayload.relationType,
|
||||
});
|
||||
|
||||
expect(createdField.id).toBeDefined();
|
||||
expect(createdField.name).toBe('owner');
|
||||
// expect(createdField.relation).toBeUndefined();
|
||||
// expect(createdField.morphRelations[0].type).toBe(
|
||||
// contextPayload.relationType,
|
||||
// );
|
||||
// expect(createdField.morphRelations[0].targetFieldMetadata.id).toBeDefined();
|
||||
|
||||
const isManyToOne =
|
||||
contextPayload.relationType === RelationType.MANY_TO_ONE;
|
||||
|
||||
if (isManyToOne) {
|
||||
expect(createdField.settings?.joinColumnName).toBe(
|
||||
'ownerOpportunityForMorphRelationId',
|
||||
);
|
||||
} else {
|
||||
expect(createdField.settings?.joinColumnName).toBeUndefined();
|
||||
}
|
||||
|
||||
// TODO: check the morphrelation targets are created correctly (wait for Query Morph Relations)
|
||||
|
||||
await deleteOneFieldMetadata({
|
||||
input: { idToDelete: createdField.id },
|
||||
}).catch();
|
||||
});
|
||||
});
|
||||
@ -0,0 +1,229 @@
|
||||
import { faker } from '@faker-js/faker/.';
|
||||
import { createOneFieldMetadata } from 'test/integration/metadata/suites/field-metadata/utils/create-one-field-metadata.util';
|
||||
import { createOneObjectMetadata } from 'test/integration/metadata/suites/object-metadata/utils/create-one-object-metadata.util';
|
||||
import { deleteOneObjectMetadata } from 'test/integration/metadata/suites/object-metadata/utils/delete-one-object-metadata.util';
|
||||
import { getMockCreateObjectInput } from 'test/integration/metadata/suites/object-metadata/utils/generate-mock-create-object-metadata-input';
|
||||
import { EachTestingContext } from 'twenty-shared/testing';
|
||||
import { FieldMetadataType } from 'twenty-shared/types';
|
||||
|
||||
import { RelationType } from 'src/engine/metadata-modules/field-metadata/interfaces/relation-type.interface';
|
||||
|
||||
import { CreateFieldInput } from 'src/engine/metadata-modules/field-metadata/dtos/create-field.input';
|
||||
|
||||
type GlobalTestContext = {
|
||||
objectMetadataIds: {
|
||||
firstTargetObjectId: string;
|
||||
secondTargetObjectId: string;
|
||||
sourceObjectId: string;
|
||||
};
|
||||
targetFieldLabel: string;
|
||||
type: FieldMetadataType;
|
||||
targetFieldIcon: string;
|
||||
collisionFieldLabel: string;
|
||||
};
|
||||
const globalTestContext: GlobalTestContext = {
|
||||
objectMetadataIds: {
|
||||
firstTargetObjectId: '',
|
||||
secondTargetObjectId: '',
|
||||
sourceObjectId: '',
|
||||
},
|
||||
targetFieldLabel: 'defaultTargetFieldLabel',
|
||||
type: FieldMetadataType.MORPH_RELATION,
|
||||
targetFieldIcon: 'IconBuildingSkyscraper',
|
||||
collisionFieldLabel: 'collisionfieldlabel',
|
||||
};
|
||||
|
||||
type TestedRelationCreationPayload = Partial<
|
||||
NonNullable<CreateFieldInput['relationCreationPayload']>
|
||||
>;
|
||||
|
||||
type CreateOneObjectMetadataItemTestingContext = EachTestingContext<
|
||||
| TestedRelationCreationPayload
|
||||
| ((context: GlobalTestContext) => TestedRelationCreationPayload)
|
||||
>[];
|
||||
describe('Field metadata morph relation creation should fail', () => {
|
||||
const failingLabelsCreationTestsUseCase: CreateOneObjectMetadataItemTestingContext =
|
||||
[
|
||||
{
|
||||
title: 'when targetFieldLabel is empty',
|
||||
context: { targetFieldLabel: '' },
|
||||
},
|
||||
{
|
||||
title: 'when targetFieldLabel exceeds maximum length',
|
||||
context: {
|
||||
targetFieldLabel: 'A'.repeat(64),
|
||||
},
|
||||
},
|
||||
{
|
||||
// Not handled gracefully should be refactored
|
||||
title: 'when targetObjectMetadataId is unknown',
|
||||
context: {
|
||||
targetObjectMetadataId: faker.string.uuid(),
|
||||
},
|
||||
},
|
||||
{
|
||||
title: 'when targetFieldLabel contains only whitespace',
|
||||
context: { targetFieldLabel: ' ' },
|
||||
},
|
||||
{
|
||||
title:
|
||||
'when targetFieldLabel conflicts with an existing field on target object metadata id',
|
||||
context: ({ collisionFieldLabel }) => ({
|
||||
targetFieldLabel: collisionFieldLabel,
|
||||
}),
|
||||
},
|
||||
{
|
||||
title: 'when type is not provided',
|
||||
context: { type: undefined },
|
||||
},
|
||||
{
|
||||
title: 'when type is a wrong value',
|
||||
context: { type: 'wrong' as RelationType },
|
||||
},
|
||||
];
|
||||
|
||||
beforeAll(async () => {
|
||||
const {
|
||||
data: {
|
||||
createOneObject: { id: sourceObjectId },
|
||||
},
|
||||
} = await createOneObjectMetadata({
|
||||
input: getMockCreateObjectInput({
|
||||
namePlural: 'sourceRelations',
|
||||
nameSingular: 'sourceRelation',
|
||||
}),
|
||||
});
|
||||
|
||||
const {
|
||||
data: {
|
||||
createOneObject: { id: firstTargetObjectId },
|
||||
},
|
||||
} = await createOneObjectMetadata({
|
||||
input: getMockCreateObjectInput({
|
||||
namePlural: 'firstTargetRelations',
|
||||
nameSingular: 'firstTargetRelation',
|
||||
}),
|
||||
});
|
||||
|
||||
const {
|
||||
data: {
|
||||
createOneObject: { id: secondTargetObjectId },
|
||||
},
|
||||
} = await createOneObjectMetadata({
|
||||
input: getMockCreateObjectInput({
|
||||
namePlural: 'secondTargetRelations',
|
||||
nameSingular: 'secondTargetRelation',
|
||||
}),
|
||||
});
|
||||
|
||||
globalTestContext.objectMetadataIds = {
|
||||
sourceObjectId,
|
||||
firstTargetObjectId,
|
||||
secondTargetObjectId,
|
||||
};
|
||||
|
||||
const { data } = await createOneFieldMetadata({
|
||||
input: {
|
||||
objectMetadataId: firstTargetObjectId,
|
||||
name: globalTestContext.collisionFieldLabel,
|
||||
label: 'LabelThatCouldBeAnything',
|
||||
isLabelSyncedWithName: false,
|
||||
type: FieldMetadataType.TEXT,
|
||||
},
|
||||
});
|
||||
|
||||
expect(data).toBeDefined();
|
||||
});
|
||||
|
||||
afterAll(async () => {
|
||||
for (const objectMetadataId of Object.values(
|
||||
globalTestContext.objectMetadataIds,
|
||||
)) {
|
||||
await deleteOneObjectMetadata({
|
||||
input: {
|
||||
idToDelete: objectMetadataId,
|
||||
},
|
||||
});
|
||||
}
|
||||
});
|
||||
|
||||
it.each(failingLabelsCreationTestsUseCase)(
|
||||
'relation ONE_TO_MANY $title',
|
||||
async ({ context }) => {
|
||||
const computedContext =
|
||||
typeof context === 'function' ? context(globalTestContext) : context;
|
||||
|
||||
const { errors } = await createOneFieldMetadata({
|
||||
expectToFail: true,
|
||||
input: {
|
||||
objectMetadataId: globalTestContext.objectMetadataIds.sourceObjectId,
|
||||
name: 'owner',
|
||||
label: 'owner field',
|
||||
isLabelSyncedWithName: false,
|
||||
type: FieldMetadataType.MORPH_RELATION,
|
||||
morphRelationsCreationPayload: [
|
||||
{
|
||||
targetFieldLabel: 'defaultFirstTargetFieldLabel',
|
||||
type: RelationType.ONE_TO_MANY,
|
||||
targetObjectMetadataId:
|
||||
globalTestContext.objectMetadataIds.firstTargetObjectId,
|
||||
targetFieldIcon: 'IconBuildingSkyscraper',
|
||||
...computedContext,
|
||||
},
|
||||
{
|
||||
targetFieldLabel: 'defaultSecondTargetFieldLabel',
|
||||
type: RelationType.ONE_TO_MANY,
|
||||
targetObjectMetadataId:
|
||||
globalTestContext.objectMetadataIds.secondTargetObjectId,
|
||||
targetFieldIcon: 'IconBuildingSkyscraper',
|
||||
...computedContext,
|
||||
},
|
||||
],
|
||||
},
|
||||
});
|
||||
|
||||
expect(errors).toBeDefined();
|
||||
expect(errors).toMatchSnapshot();
|
||||
},
|
||||
);
|
||||
|
||||
it.each(failingLabelsCreationTestsUseCase)(
|
||||
'relation MANY_TO_ONE $title',
|
||||
async ({ context }) => {
|
||||
const computedContext =
|
||||
typeof context === 'function' ? context(globalTestContext) : context;
|
||||
|
||||
const { errors } = await createOneFieldMetadata({
|
||||
expectToFail: true,
|
||||
input: {
|
||||
objectMetadataId: globalTestContext.objectMetadataIds.sourceObjectId,
|
||||
name: 'owner',
|
||||
label: 'owner field',
|
||||
isLabelSyncedWithName: false,
|
||||
type: FieldMetadataType.MORPH_RELATION,
|
||||
morphRelationsCreationPayload: [
|
||||
{
|
||||
targetFieldLabel: 'defaultFirstTargetFieldLabel',
|
||||
type: RelationType.MANY_TO_ONE,
|
||||
targetObjectMetadataId:
|
||||
globalTestContext.objectMetadataIds.firstTargetObjectId,
|
||||
targetFieldIcon: 'IconBuildingSkyscraper',
|
||||
...computedContext,
|
||||
},
|
||||
{
|
||||
targetFieldLabel: 'defaultSecondTargetFieldLabel',
|
||||
type: RelationType.MANY_TO_ONE,
|
||||
targetObjectMetadataId:
|
||||
globalTestContext.objectMetadataIds.secondTargetObjectId,
|
||||
targetFieldIcon: 'IconBuildingSkyscraper',
|
||||
...computedContext,
|
||||
},
|
||||
],
|
||||
},
|
||||
});
|
||||
|
||||
expect(errors).toBeDefined();
|
||||
expect(errors).toMatchSnapshot();
|
||||
},
|
||||
);
|
||||
});
|
||||
Reference in New Issue
Block a user