admin/twenty
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Fixed RecordShowEffect request bug (#12247)

Browse Source 
This PR fixes the RecordShowEffect that was overwriting the record store
with an empty state during the request loading time.
This commit is contained in:
Lucas Bordeau
2025-05-23 13:45:05 +02:00
committed by GitHub
parent 3d21e1ce26
commit c98439d76a
1 changed files with 6 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
packages/twenty-front/src/modules/object-record/record-show/components/RecordShowEffect.tsx
View File

@ -6,6 +6,7 @@ import { recordStoreFamilyState } from '@/object-record/record-store/states/reco
import { ObjectRecord } from '@/object-record/types/ObjectRecord'; import { ObjectRecord } from '@/object-record/types/ObjectRecord';
import { useEffect } from 'react'; import { useEffect } from 'react';
import { useRecoilCallback } from 'recoil'; import { useRecoilCallback } from 'recoil';
import { isDefined } from 'twenty-shared/utils';
type RecordShowEffectProps = { type RecordShowEffectProps = {
objectNameSingular: string; objectNameSingular: string;
@ -25,7 +26,7 @@ export const RecordShowEffect = ({
objectMetadataItems, objectMetadataItems,
}); });
const { record } = useFindOneRecord({ const { record, loading } = useFindOneRecord({
objectRecordId: recordId, objectRecordId: recordId,
objectNameSingular, objectNameSingular,
recordGqlFields: FIND_ONE_RECORD_FOR_SHOW_PAGE_OPERATION_SIGNATURE.fields, recordGqlFields: FIND_ONE_RECORD_FOR_SHOW_PAGE_OPERATION_SIGNATURE.fields,
@ -47,8 +48,10 @@ export const RecordShowEffect = ({
); );
useEffect(() => { useEffect(() => {
setRecordStore(record); if (!loading && isDefined(record)) {
}, [record, setRecordStore]); setRecordStore(record);
}
}, [record, setRecordStore, loading]);
return <></>; return <></>;
}; };