admin/twenty
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Fixed view reset on view change (#6897)

Browse Source 
Fixes #6833 

The view states for unsaved changes were not reseted on view change.

The fix was to just add a call to the existing resetCurrentView when the
viewId changes in the related effect.
This commit is contained in:
Lucas Bordeau
2024-09-05 10:23:42 +02:00
committed by GitHub
parent a2b1062db6
commit caff652df3
1 changed files with 9 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
packages/twenty-front/src/modules/views/components/QueryParamsViewIdEffect.tsx
View File

@ -4,6 +4,7 @@ import { useFilteredObjectMetadataItems } from '@/object-metadata/hooks/useFilte
import { useViewFromQueryParams } from '@/views/hooks/internal/useViewFromQueryParams'; import { useViewFromQueryParams } from '@/views/hooks/internal/useViewFromQueryParams';
import { useViewStates } from '@/views/hooks/internal/useViewStates'; import { useViewStates } from '@/views/hooks/internal/useViewStates';
import { useGetCurrentView } from '@/views/hooks/useGetCurrentView'; import { useGetCurrentView } from '@/views/hooks/useGetCurrentView';
import { useResetCurrentView } from '@/views/hooks/useResetCurrentView';
import { isUndefined } from '@sniptt/guards'; import { isUndefined } from '@sniptt/guards';
import { useEffect } from 'react'; import { useEffect } from 'react';
import { useRecoilState } from 'recoil'; import { useRecoilState } from 'recoil';
@ -33,6 +34,14 @@ export const QueryParamsViewIdEffect = () => {
lastVisitedObjectMetadataItemId, lastVisitedObjectMetadataItemId,
); );
const { resetCurrentView } = useResetCurrentView();
useEffect(() => {
if (isDefined(currentViewId)) {
resetCurrentView();
}
}, [resetCurrentView, currentViewId]);
useEffect(() => { useEffect(() => {
const indexView = viewsOnCurrentObject.find((view) => view.key === 'INDEX'); const indexView = viewsOnCurrentObject.find((view) => view.key === 'INDEX');