FieldDisplay & FieldInput (#1708)

* Removed view field duplicate types

* wip

* wip 2

* wip 3

* Unified state for fields

* Renaming

* Wip

* Post merge

* Post post merge

* wip

* Delete unused file

* Boolean and Probability

* Finished InlineCell

* Renamed EditableCell to TableCell

* Finished double texts

* Finished MoneyField

* Fixed bug inline cell click outside

* Fixed hotkey scope

* Final fixes

* Phone

* Fix url and number input validation

* Fix

* Fix position

* wip refactor activity editor

* Fixed activity editor

---------

Co-authored-by: Charles Bochet <charles@twenty.com>

front/src/modules/companies/constants/companiesAvailableColumnDefinitions.tsx

@@ -1,14 +1,14 @@
 import {
-  ViewFieldBooleanMetadata,
-  ViewFieldChipMetadata,
-  ViewFieldDateMetadata,
-  ViewFieldMetadata,
-  ViewFieldMoneyMetadata,
-  ViewFieldNumberMetadata,
-  ViewFieldRelationMetadata,
-  ViewFieldTextMetadata,
-  ViewFieldURLMetadata,
-} from '@/ui/editable-field/types/ViewField';
+  FieldBooleanMetadata,
+  FieldChipMetadata,
+  FieldDateMetadata,
+  FieldMetadata,
+  FieldMoneyMetadata,
+  FieldNumberMetadata,
+  FieldRelationMetadata,
+  FieldTextMetadata,
+  FieldURLMetadata,
+} from '@/ui/field/types/FieldMetadata';
 import {
   IconBrandLinkedin,
   IconBrandX,
@@ -24,7 +24,7 @@ import {
 import { Entity } from '@/ui/input/relation-picker/types/EntityTypeForSelect';
 import { ColumnDefinition } from '@/ui/table/types/ColumnDefinition';
 
-export const companiesAvailableColumnDefinitions: ColumnDefinition<ViewFieldMetadata>[] =
+export const companiesAvailableColumnDefinitions: ColumnDefinition<FieldMetadata>[] =
   [
     {
       key: 'name',
@@ -32,125 +32,131 @@ export const companiesAvailableColumnDefinitions: ColumnDefinition<ViewFieldMeta
       Icon: IconBuildingSkyscraper,
       size: 180,
       index: 0,
+      type: 'chip',
       metadata: {
-        type: 'chip',
         urlFieldName: 'domainName',
         contentFieldName: 'name',
         relationType: Entity.Company,
+        placeHolder: 'Company Name',
       },
       isVisible: true,
-    } as ColumnDefinition<ViewFieldChipMetadata>,
+    } satisfies ColumnDefinition<FieldChipMetadata>,
     {
       key: 'domainName',
       name: 'URL',
       Icon: IconLink,
       size: 100,
       index: 1,
+      type: 'url',
       metadata: {
-        type: 'url',
         fieldName: 'domainName',
         placeHolder: 'example.com',
       },
       isVisible: true,
-    } as ColumnDefinition<ViewFieldURLMetadata>,
+      useEditButton: true,
+    } satisfies ColumnDefinition<FieldURLMetadata>,
     {
       key: 'accountOwner',
       name: 'Account Owner',
       Icon: IconUserCircle,
       size: 150,
       index: 2,
+      type: 'relation',
       metadata: {
-        type: 'relation',
         fieldName: 'accountOwner',
         relationType: Entity.User,
       },
       isVisible: true,
-    } satisfies ColumnDefinition<ViewFieldRelationMetadata>,
+    } satisfies ColumnDefinition<FieldRelationMetadata>,
     {
       key: 'createdAt',
       name: 'Creation',
       Icon: IconCalendarEvent,
       size: 150,
       index: 3,
+      type: 'date',
       metadata: {
-        type: 'date',
         fieldName: 'createdAt',
       },
       isVisible: true,
-    } satisfies ColumnDefinition<ViewFieldDateMetadata>,
+    } satisfies ColumnDefinition<FieldDateMetadata>,
     {
       key: 'employees',
       name: 'Employees',
       Icon: IconUsers,
       size: 150,
       index: 4,
+      type: 'number',
       metadata: {
-        type: 'number',
         fieldName: 'employees',
         isPositive: true,
+        placeHolder: 'Employees',
       },
       isVisible: true,
-    } satisfies ColumnDefinition<ViewFieldNumberMetadata>,
+    } satisfies ColumnDefinition<FieldNumberMetadata>,
     {
       key: 'linkedin',
       name: 'LinkedIn',
       Icon: IconBrandLinkedin,
       size: 170,
       index: 5,
+      type: 'url',
       metadata: {
-        type: 'url',
         fieldName: 'linkedinUrl',
         placeHolder: 'LinkedIn URL',
       },
       isVisible: true,
-    } satisfies ColumnDefinition<ViewFieldURLMetadata>,
+      useEditButton: true,
+    } satisfies ColumnDefinition<FieldURLMetadata>,
     {
       key: 'address',
       name: 'Address',
       Icon: IconMap,
       size: 170,
       index: 6,
+      type: 'text',
       metadata: {
-        type: 'text',
         fieldName: 'address',
         placeHolder: 'Addre​ss', // Hack: Fake character to prevent password-manager from filling the field
       },
       isVisible: true,
-    } satisfies ColumnDefinition<ViewFieldTextMetadata>,
+    } satisfies ColumnDefinition<FieldTextMetadata>,
     {
       key: 'idealCustomerProfile',
       name: 'ICP',
       Icon: IconTarget,
       size: 150,
       index: 7,
+      type: 'boolean',
       metadata: {
-        type: 'boolean',
         fieldName: 'idealCustomerProfile',
       },
       isVisible: false,
-    } satisfies ColumnDefinition<ViewFieldBooleanMetadata>,
+    } satisfies ColumnDefinition<FieldBooleanMetadata>,
     {
       key: 'annualRecurringRevenue',
       name: 'ARR',
       Icon: IconMoneybag,
       size: 150,
       index: 8,
+      type: 'moneyAmount',
       metadata: {
-        type: 'moneyAmount',
         fieldName: 'annualRecurringRevenue',
+        placeHolder: 'ARR',
       },
-    } satisfies ColumnDefinition<ViewFieldMoneyMetadata>,
+    } satisfies ColumnDefinition<FieldMoneyMetadata>,
     {
       key: 'xUrl',
       name: 'Twitter',
       Icon: IconBrandX,
       size: 150,
       index: 9,
+      type: 'url',
       metadata: {
-        type: 'url',
         fieldName: 'xUrl',
         placeHolder: 'X',
       },
       isVisible: false,
-    } satisfies ColumnDefinition<ViewFieldURLMetadata>,
+      useEditButton: true,
+    } satisfies ColumnDefinition<FieldURLMetadata>,
   ];