From cbcb49cd1eaec248c32853c6ba6a2a3e9e95c63f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?J=C3=A9r=C3=A9my=20M?= Date: Wed, 6 Sep 2023 11:03:12 +0200 Subject: [PATCH] fix: allow null value for number and date (#1472) --- front/src/modules/ui/editable-field/types/FieldMetadata.ts | 2 +- .../ui/editable-field/types/guards/isFieldDateValue.ts | 5 ++--- .../ui/editable-field/types/guards/isFieldNumberValue.ts | 5 ++--- 3 files changed, 5 insertions(+), 7 deletions(-) diff --git a/front/src/modules/ui/editable-field/types/FieldMetadata.ts b/front/src/modules/ui/editable-field/types/FieldMetadata.ts index fdbd9eb76..3a7003a3c 100644 --- a/front/src/modules/ui/editable-field/types/FieldMetadata.ts +++ b/front/src/modules/ui/editable-field/types/FieldMetadata.ts @@ -100,7 +100,7 @@ export type FieldMetadata = export type FieldTextValue = string; export type FieldChipValue = string; -export type FieldDateValue = string; +export type FieldDateValue = string | null; export type FieldPhoneValue = string; export type FieldURLValue = string; export type FieldNumberValue = number | null; diff --git a/front/src/modules/ui/editable-field/types/guards/isFieldDateValue.ts b/front/src/modules/ui/editable-field/types/guards/isFieldDateValue.ts index 1d7bdfd88..0d6a86676 100644 --- a/front/src/modules/ui/editable-field/types/guards/isFieldDateValue.ts +++ b/front/src/modules/ui/editable-field/types/guards/isFieldDateValue.ts @@ -5,8 +5,7 @@ export function isFieldDateValue( fieldValue: unknown, ): fieldValue is FieldDateValue { return ( - fieldValue !== null && - fieldValue !== undefined && - typeof fieldValue === 'string' + fieldValue === null || + (fieldValue !== undefined && typeof fieldValue === 'string') ); } diff --git a/front/src/modules/ui/editable-field/types/guards/isFieldNumberValue.ts b/front/src/modules/ui/editable-field/types/guards/isFieldNumberValue.ts index 452bdbede..a592554ee 100644 --- a/front/src/modules/ui/editable-field/types/guards/isFieldNumberValue.ts +++ b/front/src/modules/ui/editable-field/types/guards/isFieldNumberValue.ts @@ -5,8 +5,7 @@ export function isFieldNumberValue( fieldValue: unknown, ): fieldValue is FieldNumberValue { return ( - fieldValue !== null && - fieldValue !== undefined && - typeof fieldValue === 'number' + fieldValue === null || + (fieldValue !== undefined && typeof fieldValue === 'number') ); }