Fix active navigation tab + quick workflows fixes (#8567)

- Active navigation tab hovered in show page
- remove timeline tab + rename workflow tab
- remove {{variable}} placeholder
- fix margin
- Workflow Runs and Versions show page title

<img width="807" alt="Capture d’écran 2024-11-18 à 18 23 12"
src="https://github.com/user-attachments/assets/688dfc67-362e-4f04-b436-3ff94d7e3e4a">
This commit is contained in:
Thomas Trompette
2024-11-19 11:55:25 +01:00
committed by GitHub
parent c17e18b1e9
commit cdf0240ccb
7 changed files with 22 additions and 12 deletions

View File

@ -39,7 +39,10 @@ export const NavigationDrawerItemForObjectMetadataItem = ({
viewId ? `?view=${viewId}` : ''
}`;
const isActive = currentPath === `/objects/${objectMetadataItem.namePlural}`;
const isActive =
currentPath === `/objects/${objectMetadataItem.namePlural}` ||
currentPath.includes(`object/${objectMetadataItem.nameSingular}/`);
const shouldSubItemsBeDisplayed = isActive && objectMetadataViews.length > 1;
const sortedObjectMetadataViews = [...objectMetadataViews].sort(

View File

@ -14,17 +14,22 @@ export const NavigationDrawerOpenedSection = () => {
const loading = useIsPrefetchLoading();
const currentObjectNamePlural = useParams().objectNamePlural;
const { activeObjectMetadataItems: workspaceFavoritesObjectMetadataItems } =
useFilteredObjectMetadataItemsForWorkspaceFavorites();
if (!currentObjectNamePlural) {
const {
objectNamePlural: currentObjectNamePlural,
objectNameSingular: currentObjectNameSingular,
} = useParams();
if (!currentObjectNamePlural && !currentObjectNameSingular) {
return;
}
const objectMetadataItem = filteredActiveObjectMetadataItems.find(
(item) => item.namePlural === currentObjectNamePlural,
(item) =>
item.namePlural === currentObjectNamePlural ||
item.nameSingular === currentObjectNameSingular,
);
if (!objectMetadataItem) {

View File

@ -21,7 +21,6 @@ const StyledObjectsMetaDataItemsWrapper = styled.div`
flex-direction: column;
gap: ${({ theme }) => theme.betweenSiblingsGap};
width: 100%;
margin-bottom: ${({ theme }) => theme.spacing(3)};
flex: 1;
overflow-y: auto;
`;