From ce07d2645c2eb1358998ae62c7043b9ef43e86ae Mon Sep 17 00:00:00 2001 From: Guillim Date: Fri, 28 Mar 2025 18:59:47 +0100 Subject: [PATCH] Renaming + remove setRecoilvalue (#11281) Simple renaming of a hook plus a deletion of a useless setRecoilValue hook. pretty strainghtforward --- .../components/ObjectOptionsDropdownLayoutContent.tsx | 2 +- ...orLayout.ts => useSetViewTypeFromLayoutOptionsMenu.ts} | 8 -------- 2 files changed, 1 insertion(+), 9 deletions(-) rename packages/twenty-front/src/modules/object-record/object-options-dropdown/hooks/{useObjectOptionsForLayout.ts => useSetViewTypeFromLayoutOptionsMenu.ts} (91%) diff --git a/packages/twenty-front/src/modules/object-record/object-options-dropdown/components/ObjectOptionsDropdownLayoutContent.tsx b/packages/twenty-front/src/modules/object-record/object-options-dropdown/components/ObjectOptionsDropdownLayoutContent.tsx index b67fcc5f0..7f239536c 100644 --- a/packages/twenty-front/src/modules/object-record/object-options-dropdown/components/ObjectOptionsDropdownLayoutContent.tsx +++ b/packages/twenty-front/src/modules/object-record/object-options-dropdown/components/ObjectOptionsDropdownLayoutContent.tsx @@ -12,8 +12,8 @@ import { } from 'twenty-ui'; import { useObjectOptionsForBoard } from '@/object-record/object-options-dropdown/hooks/useObjectOptionsForBoard'; -import { useSetViewTypeFromLayoutOptionsMenu } from '@/object-record/object-options-dropdown/hooks/useObjectOptionsForLayout'; import { useOptionsDropdown } from '@/object-record/object-options-dropdown/hooks/useOptionsDropdown'; +import { useSetViewTypeFromLayoutOptionsMenu } from '@/object-record/object-options-dropdown/hooks/useSetViewTypeFromLayoutOptionsMenu'; import { recordGroupFieldMetadataComponentState } from '@/object-record/record-group/states/recordGroupFieldMetadataComponentState'; import { recordIndexOpenRecordInState } from '@/object-record/record-index/states/recordIndexOpenRecordInState'; import { DropdownMenuHeader } from '@/ui/layout/dropdown/components/DropdownMenuHeader/DropdownMenuHeader'; diff --git a/packages/twenty-front/src/modules/object-record/object-options-dropdown/hooks/useObjectOptionsForLayout.ts b/packages/twenty-front/src/modules/object-record/object-options-dropdown/hooks/useSetViewTypeFromLayoutOptionsMenu.ts similarity index 91% rename from packages/twenty-front/src/modules/object-record/object-options-dropdown/hooks/useObjectOptionsForLayout.ts rename to packages/twenty-front/src/modules/object-record/object-options-dropdown/hooks/useSetViewTypeFromLayoutOptionsMenu.ts index 91e2cad04..154b5734d 100644 --- a/packages/twenty-front/src/modules/object-record/object-options-dropdown/hooks/useObjectOptionsForLayout.ts +++ b/packages/twenty-front/src/modules/object-record/object-options-dropdown/hooks/useSetViewTypeFromLayoutOptionsMenu.ts @@ -5,14 +5,12 @@ import { useRecordIndexContextOrThrow } from '@/object-record/record-index/conte import { useLoadRecordIndexStates } from '@/object-record/record-index/hooks/useLoadRecordIndexStates'; import { recordIndexViewTypeState } from '@/object-record/record-index/states/recordIndexViewTypeState'; import { prefetchViewFromViewIdFamilySelector } from '@/prefetch/states/selector/prefetchViewFromViewIdFamilySelector'; -import { useSetRecoilComponentStateV2 } from '@/ui/utilities/state/component-state/hooks/useSetRecoilComponentStateV2'; import { usePersistViewGroupRecords } from '@/views/hooks/internal/usePersistViewGroupRecords'; import { useUpdateCurrentView } from '@/views/hooks/useUpdateCurrentView'; import { GraphQLView } from '@/views/types/GraphQLView'; import { ViewGroup } from '@/views/types/ViewGroup'; import { ViewType } from '@/views/types/ViewType'; import { useGetAvailableFieldsForKanban } from '@/views/view-picker/hooks/useGetAvailableFieldsForKanban'; -import { viewPickerKanbanFieldMetadataIdComponentState } from '@/views/view-picker/states/viewPickerKanbanFieldMetadataIdComponentState'; import { useCallback } from 'react'; import { useRecoilCallback, useSetRecoilState } from 'recoil'; import { assertUnreachable, isDefined } from 'twenty-shared/utils'; @@ -24,10 +22,6 @@ export const useSetViewTypeFromLayoutOptionsMenu = () => { const { availableFieldsForKanban } = useGetAvailableFieldsForKanban(); const { objectMetadataItem } = useRecordIndexContextOrThrow(); - const setViewPickerKanbanFieldMetadataId = useSetRecoilComponentStateV2( - viewPickerKanbanFieldMetadataIdComponentState, - ); - const { loadRecordIndexStates } = useLoadRecordIndexStates(); const { createViewGroupRecords } = usePersistViewGroupRecords(); @@ -126,7 +120,6 @@ export const useSetViewTypeFromLayoutOptionsMenu = () => { { ...currentView, viewGroups }, objectMetadataItem, ); - setViewPickerKanbanFieldMetadataId(kanbanField.id); } setRecordIndexViewType(viewType); await updateCurrentView(updateCurrentViewParams); @@ -147,7 +140,6 @@ export const useSetViewTypeFromLayoutOptionsMenu = () => { updateCurrentView, setRecordIndexViewType, createViewGroupAssociatedWithKanbanField, - setViewPickerKanbanFieldMetadataId, loadRecordIndexStates, ], );