admin/twenty
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Refactor Views by cleaning the code, relying on apolloCache and improving performances (#4516)

Browse Source 
* Wip refactoring view

* Post merge conflicts

* Fix review

* Add create view capability

* Fix create object missing view

* Fix tests
This commit is contained in:
Charles Bochet
2024-03-20 14:21:58 +01:00
committed by GitHub
parent 20e14cb455
commit cfb0cce9b8
392 changed files with 3474 additions and 4410 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
packages/twenty-front/src/modules/ui/layout/tab/components/TabList.tsx
View File

@ -36,9 +36,9 @@ const StyledContainer = styled.div`
export const TabList = ({ tabs, tabListId }: TabListProps) => {
const initialActiveTabId = tabs[0].id;
const { getActiveTabIdState, setActiveTabId } = useTabList(tabListId);
const { activeTabIdState, setActiveTabId } = useTabList(tabListId);
const activeTabId = useRecoilValue(getActiveTabIdState());
const activeTabId = useRecoilValue(activeTabIdState);
React.useEffect(() => {
setActiveTabId(initialActiveTabId);

6
packages/twenty-front/src/modules/ui/layout/tab/hooks/__tests__/useTabList.test.tsx
View File

@ -8,12 +8,11 @@ describe('useTabList', () => {
it('Should update the activeTabId state', async () => {
const { result } = renderHook(
() => {
const { getActiveTabIdState, setActiveTabId } =
const { activeTabIdState, setActiveTabId } =
useTabList('TEST_TAB_LIST_ID');
const activeTabId = useRecoilValue(getActiveTabIdState());
const activeTabId = useRecoilValue(activeTabIdState);
return {
getActiveTabIdState: getActiveTabIdState,
activeTabId,
setActiveTabId: setActiveTabId,
};
@ -22,7 +21,6 @@ describe('useTabList', () => {
wrapper: RecoilRoot,
},
);
expect(result.current.getActiveTabIdState).toBeInstanceOf(Function);
expect(result.current.setActiveTabId).toBeInstanceOf(Function);
expect(result.current.activeTabId).toBeNull();

5
packages/twenty-front/src/modules/ui/layout/tab/hooks/internal/useTabListStates.ts
View File

@ -15,9 +15,6 @@ export const useTabListStates = ({ tabListScopeId }: useTabListStatesProps) => {
return {
scopeId,
getActiveTabIdState: extractComponentState(
activeTabIdComponentState,
scopeId,
),
activeTabIdState: extractComponentState(activeTabIdComponentState, scopeId),
};
};

6
packages/twenty-front/src/modules/ui/layout/tab/hooks/useTabList.ts
View File

@ -3,14 +3,14 @@ import { useSetRecoilState } from 'recoil';
import { useTabListStates } from '@/ui/layout/tab/hooks/internal/useTabListStates';
export const useTabList = (tabListId?: string) => {
const { getActiveTabIdState } = useTabListStates({
const { activeTabIdState } = useTabListStates({
tabListScopeId: `${tabListId}-scope`,
});
const setActiveTabId = useSetRecoilState(getActiveTabIdState());
const setActiveTabId = useSetRecoilState(activeTabIdState);
return {
getActiveTabIdState,
activeTabIdState,
setActiveTabId,
};
};