admin/twenty
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Refactor Views by cleaning the code, relying on apolloCache and improving performances (#4516)

Browse Source 
* Wip refactoring view

* Post merge conflicts

* Fix review

* Add create view capability

* Fix create object missing view

* Fix tests
This commit is contained in:
Charles Bochet
2024-03-20 14:21:58 +01:00
committed by GitHub
parent 20e14cb455
commit cfb0cce9b8
392 changed files with 3474 additions and 4410 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
packages/twenty-front/src/modules/ui/utilities/pointer-event/hooks/__tests__/useClickOutsideListener.test.tsx
View File

@ -15,9 +15,7 @@ describe('useClickOutsideListener', () => {
return {
useClickOutside: useClickOutsideListener(componentId),
isActivated: useRecoilValue(
getClickOutsideListenerIsActivatedState(),
),
isActivated: useRecoilValue(getClickOutsideListenerIsActivatedState),
};
},
{

14
packages/twenty-front/src/modules/ui/utilities/pointer-event/hooks/useClickOutsideListener.ts
View File

@ -34,7 +34,7 @@ export const useClickOutsideListener = (componentId: string) => {
callback(event);
const additionalCallbacks = snapshot
.getLoadable(getClickOutsideListenerCallbacksState())
.getLoadable(getClickOutsideListenerCallbacksState)
.getValue();
additionalCallbacks.forEach((additionalCallback) => {
@ -51,7 +51,7 @@ export const useClickOutsideListener = (componentId: string) => {
const toggleClickOutsideListener = useRecoilCallback(
({ set }) =>
(activated: boolean) => {
set(getClickOutsideListenerIsActivatedState(), activated);
set(getClickOutsideListenerIsActivatedState, activated);
},
[getClickOutsideListenerIsActivatedState],
);
@ -60,7 +60,7 @@ export const useClickOutsideListener = (componentId: string) => {
({ set, snapshot }) =>
({ callbackFunction, callbackId }: ClickOutsideListenerCallback) => {
const existingCallbacks = snapshot
.getLoadable(getClickOutsideListenerCallbacksState())
.getLoadable(getClickOutsideListenerCallbacksState)
.getValue();
const existingCallbackWithSameId = existingCallbacks.find(
@ -74,7 +74,7 @@ export const useClickOutsideListener = (componentId: string) => {
});
set(
getClickOutsideListenerCallbacksState(),
getClickOutsideListenerCallbacksState,
existingCallbacksWithNewCallback,
);
} else {
@ -95,7 +95,7 @@ export const useClickOutsideListener = (componentId: string) => {
};
set(
getClickOutsideListenerCallbacksState(),
getClickOutsideListenerCallbacksState,
existingCallbacksWithOverwrittenCallback,
);
}
@ -107,7 +107,7 @@ export const useClickOutsideListener = (componentId: string) => {
({ set, snapshot }) =>
({ callbackId }: { callbackId: string }) => {
const existingCallbacks = snapshot
.getLoadable(getClickOutsideListenerCallbacksState())
.getLoadable(getClickOutsideListenerCallbacksState)
.getValue();
const indexOfCallbackToUnsubscribe = existingCallbacks.findIndex(
@ -121,7 +121,7 @@ export const useClickOutsideListener = (componentId: string) => {
existingCallbacks.toSpliced(indexOfCallbackToUnsubscribe, 1);
set(
getClickOutsideListenerCallbacksState(),
getClickOutsideListenerCallbacksState,
newCallbacksWithoutCallbackToUnsubscribe,
);
}

8
packages/twenty-front/src/modules/ui/utilities/pointer-event/hooks/useListenClickOutsideV2.ts
View File

@ -32,7 +32,7 @@ export const useListenClickOutsideV2 = <T extends Element>({
({ snapshot, set }) =>
(event: MouseEvent | TouchEvent) => {
const clickOutsideListenerIsActivated = snapshot
.getLoadable(getClickOutsideListenerIsActivatedState())
.getLoadable(getClickOutsideListenerIsActivatedState)
.getValue();
const isListening = clickOutsideListenerIsActivated && enabled;
@ -47,7 +47,7 @@ export const useListenClickOutsideV2 = <T extends Element>({
.some((ref) => ref.current?.contains(event.target as Node));
set(
getClickOutsideListenerIsMouseDownInsideState(),
getClickOutsideListenerIsMouseDownInsideState,
clickedOnAtLeastOneRef,
);
}
@ -84,7 +84,7 @@ export const useListenClickOutsideV2 = <T extends Element>({
});
set(
getClickOutsideListenerIsMouseDownInsideState(),
getClickOutsideListenerIsMouseDownInsideState,
clickedOnAtLeastOneRef,
);
}
@ -102,7 +102,7 @@ export const useListenClickOutsideV2 = <T extends Element>({
({ snapshot }) =>
(event: MouseEvent | TouchEvent) => {
const isMouseDownInside = snapshot
.getLoadable(getClickOutsideListenerIsMouseDownInsideState())
.getLoadable(getClickOutsideListenerIsMouseDownInsideState)
.getValue();
if (mode === ClickOutsideMode.compareHTMLRef) {