admin/twenty
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Left menu and chip links (#12294)

Browse Source 
Small optimization for faster loading (gaining ~80ms - average time of a
click)

It might seem a little over-engineered but there are a lot of edge cases
and I couldn't find a simpler solution

I also tried to tackle Link Chips but it's more complex so this will be
for another PR
This commit is contained in:
Félix Malfait
2025-05-28 12:32:49 +02:00
committed by GitHub
parent 97d4ec96af
commit d4fac6793a
29 changed files with 203 additions and 60 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
packages/twenty-front/src/modules/favorites/components/CurrentWorkspaceMemberFavorites.tsx
View File

@ -160,6 +160,7 @@ export const CurrentWorkspaceMemberFavorites = ({
rightOptions={rightOptions}
className="navigation-drawer-item"
isRightOptionsDropdownOpen={isFavoriteFolderEditDropdownOpen}
triggerEvent="CLICK"
/>
</FavoritesDroppable>
)}
@ -190,7 +191,7 @@ export const CurrentWorkspaceMemberFavorites = ({
label={favorite.labelIdentifier}
objectName={favorite.objectNameSingular}
Icon={() => <FavoriteIcon favorite={favorite} />}
to={favorite.link}
to={isDragging ? undefined : favorite.link}
active={index === selectedFavoriteIndex}
subItemState={getNavigationSubItemLeftAdornment({
index,
@ -205,6 +206,7 @@ export const CurrentWorkspaceMemberFavorites = ({
/>
}
isDragging={isDragging}
triggerEvent="CLICK"
/>
}
/>

3
packages/twenty-front/src/modules/favorites/components/CurrentWorkspaceMemberOrphanFavorites.tsx
View File

@ -50,7 +50,7 @@ export const CurrentWorkspaceMemberOrphanFavorites = () => {
currentViewPath,
favorite,
)}
to={favorite.link}
to={isDragging ? undefined : favorite.link}
rightOptions={
<LightIconButton
Icon={IconHeartOff}
@ -60,6 +60,7 @@ export const CurrentWorkspaceMemberOrphanFavorites = () => {
}
objectName={favorite.objectNameSingular}
isDragging={isDragging}
triggerEvent="CLICK"
/>
</StyledOrphanFavoritesContainer>
}