[Fix] isLabelSyncedWithName should be nullable (#9028)
isLabelSyncedWithName should be nullable for fieldMetadata, as it is for objectMetadata. + Adding missing validation on label and name sync in fieldMetadataService for creation and update + adding metadata tests
This commit is contained in:
@ -0,0 +1,24 @@
|
||||
import gql from 'graphql-tag';
|
||||
|
||||
import { CreateFieldInput } from 'src/engine/metadata-modules/field-metadata/dtos/create-field.input';
|
||||
|
||||
type CreateOneFieldFactoryParams = {
|
||||
gqlFields: string;
|
||||
input?: { field: Omit<CreateFieldInput, 'workspaceId' | 'dataSourceId'> };
|
||||
};
|
||||
|
||||
export const createOneFieldMetadataFactory = ({
|
||||
gqlFields,
|
||||
input,
|
||||
}: CreateOneFieldFactoryParams) => ({
|
||||
query: gql`
|
||||
mutation CreateOneFieldMetadataItem($input: CreateOneFieldMetadataInput!) {
|
||||
createOneField(input: $input) {
|
||||
${gqlFields}
|
||||
}
|
||||
}
|
||||
`,
|
||||
variables: {
|
||||
input,
|
||||
},
|
||||
});
|
||||
@ -0,0 +1,31 @@
|
||||
import { createOneFieldMetadataFactory } from 'test/integration/metadata/suites/field-metadata/utils/create-one-field-metadata-factory.util';
|
||||
import { makeMetadataAPIRequest } from 'test/integration/metadata/suites/utils/make-metadata-api-request.util';
|
||||
|
||||
import { FieldMetadataType } from 'src/engine/metadata-modules/field-metadata/field-metadata.entity';
|
||||
|
||||
const FIELD_NAME = 'testName';
|
||||
|
||||
export const createTestTextFieldMetadata = async (
|
||||
objectMetadataItemId: string,
|
||||
) => {
|
||||
const createFieldInput = {
|
||||
name: FIELD_NAME,
|
||||
label: 'Test name',
|
||||
type: FieldMetadataType.TEXT,
|
||||
objectMetadataId: objectMetadataItemId,
|
||||
isLabelSyncedWithName: true,
|
||||
};
|
||||
const graphqlOperation = createOneFieldMetadataFactory({
|
||||
input: { field: createFieldInput },
|
||||
gqlFields: `
|
||||
id
|
||||
name
|
||||
label
|
||||
isLabelSyncedWithName
|
||||
`,
|
||||
});
|
||||
|
||||
const response = await makeMetadataAPIRequest(graphqlOperation);
|
||||
|
||||
return { fieldMetadataId: response.body.data.createOneField.id };
|
||||
};
|
||||
@ -0,0 +1,20 @@
|
||||
import gql from 'graphql-tag';
|
||||
|
||||
type DeleteOneFieldFactoryParams = {
|
||||
idToDelete: string;
|
||||
};
|
||||
|
||||
export const deleteOneFieldMetadataItemFactory = ({
|
||||
idToDelete,
|
||||
}: DeleteOneFieldFactoryParams) => ({
|
||||
query: gql`
|
||||
mutation DeleteOneFieldMetadataItem($idToDelete: UUID!) {
|
||||
deleteOneField(input: { id: $idToDelete }) {
|
||||
id
|
||||
}
|
||||
}
|
||||
`,
|
||||
variables: {
|
||||
idToDelete,
|
||||
},
|
||||
});
|
||||
@ -0,0 +1,10 @@
|
||||
import { makeGraphqlAPIRequest } from 'test/integration/graphql/utils/make-graphql-api-request.util';
|
||||
import { deleteOneFieldMetadataItemFactory } from 'test/integration/metadata/suites/field-metadata/utils/delete-one-field-metadata-factory.util';
|
||||
|
||||
export const deleteFieldMetadata = async (fieldMetadataId: string) => {
|
||||
const graphqlOperation = deleteOneFieldMetadataItemFactory({
|
||||
idToDelete: fieldMetadataId,
|
||||
});
|
||||
|
||||
await makeGraphqlAPIRequest(graphqlOperation);
|
||||
};
|
||||
@ -0,0 +1,25 @@
|
||||
import gql from 'graphql-tag';
|
||||
|
||||
import { UpdateFieldInput } from 'src/engine/metadata-modules/field-metadata/dtos/update-field.input';
|
||||
|
||||
type UpdateOneFieldFactoryParams = {
|
||||
gqlFields: string;
|
||||
input: { id: string; update: Omit<UpdateFieldInput, 'workspaceId' | 'id'> };
|
||||
};
|
||||
|
||||
export const updateOneFieldMetadataFactory = ({
|
||||
gqlFields,
|
||||
input,
|
||||
}: UpdateOneFieldFactoryParams) => ({
|
||||
query: gql`
|
||||
mutation UpdateOneFieldMetadataItem($idToUpdate: UUID!, $updatePayload: UpdateFieldInput!) {
|
||||
updateOneField(input: {id: $idToUpdate, update: $updatePayload}) {
|
||||
${gqlFields}
|
||||
}
|
||||
}
|
||||
`,
|
||||
variables: {
|
||||
idToUpdate: input.id,
|
||||
updatePayload: input.update,
|
||||
},
|
||||
});
|
||||
Reference in New Issue
Block a user