Fix all broken CIs (#7439)
Fix all the broken CIs :p This includes an ongoing effort to simplify test maintenance by having 1 unique source of truth about metadata and data mocks (that will later be generated from a unique source of seeds: dev = demo = test) Regressions: - Unit line coverage: 60 > 55 - Storybook Pages branch coverage: 40 > 35 We will need to write tests to increase those coverage - RelationFieldDisplay perf: 0.2ms to 0.22ms > We might have a regression here - Removed perf story about RawJSON > We will need to re-add it
This commit is contained in:
committed by
Charles Bochet
parent
bd305c8432
commit
d8c4af9279
@ -1,10 +1,14 @@
|
||||
import { ObjectRecord } from '@/object-record/types/ObjectRecord';
|
||||
import {
|
||||
mockedCompanyObjectMetadataItem,
|
||||
mockedPersonObjectMetadataItem,
|
||||
} from '~/testing/mock-data/metadata';
|
||||
|
||||
import { generatedMockObjectMetadataItems } from '~/testing/mock-data/generatedMockObjectMetadataItems';
|
||||
import { getFieldPreviewValueFromRecord } from '../getFieldPreviewValueFromRecord';
|
||||
const mockedCompanyObjectMetadataItem = generatedMockObjectMetadataItems.find(
|
||||
(item) => item.nameSingular === 'company',
|
||||
);
|
||||
|
||||
const mockedPersonObjectMetadataItem = generatedMockObjectMetadataItems.find(
|
||||
(item) => item.nameSingular === 'person',
|
||||
);
|
||||
|
||||
describe('getFieldPreviewValueFromRecord', () => {
|
||||
describe('RELATION field', () => {
|
||||
@ -21,9 +25,13 @@ describe('getFieldPreviewValueFromRecord', () => {
|
||||
},
|
||||
__typename: 'Opportunity',
|
||||
};
|
||||
const fieldMetadataItem = mockedCompanyObjectMetadataItem.fields.find(
|
||||
const fieldMetadataItem = mockedCompanyObjectMetadataItem?.fields.find(
|
||||
({ name }) => name === 'people',
|
||||
)!;
|
||||
);
|
||||
|
||||
if (!fieldMetadataItem) {
|
||||
throw new Error('Field not found');
|
||||
}
|
||||
|
||||
// When
|
||||
const result = getFieldPreviewValueFromRecord({
|
||||
@ -43,9 +51,13 @@ describe('getFieldPreviewValueFromRecord', () => {
|
||||
company: relationRecord,
|
||||
__typename: 'Opportunity',
|
||||
};
|
||||
const fieldMetadataItem = mockedPersonObjectMetadataItem.fields.find(
|
||||
const fieldMetadataItem = mockedPersonObjectMetadataItem?.fields.find(
|
||||
({ name }) => name === 'company',
|
||||
)!;
|
||||
);
|
||||
|
||||
if (!fieldMetadataItem) {
|
||||
throw new Error('Field not found');
|
||||
}
|
||||
|
||||
// When
|
||||
const result = getFieldPreviewValueFromRecord({
|
||||
@ -62,9 +74,13 @@ describe('getFieldPreviewValueFromRecord', () => {
|
||||
it('returns the record field value', () => {
|
||||
// Given
|
||||
const record = { id: '', name: 'Twenty', __typename: 'Opportunity' };
|
||||
const fieldMetadataItem = mockedCompanyObjectMetadataItem.fields.find(
|
||||
const fieldMetadataItem = mockedCompanyObjectMetadataItem?.fields.find(
|
||||
({ name }) => name === 'name',
|
||||
)!;
|
||||
);
|
||||
|
||||
if (!fieldMetadataItem) {
|
||||
throw new Error('Field not found');
|
||||
}
|
||||
|
||||
// When
|
||||
const result = getFieldPreviewValueFromRecord({
|
||||
|
||||
Reference in New Issue
Block a user