Fix settings navigation active state for sub-pages (#12318)
Changes the default behavior for settings navigation items to stay active when navigating to sub-pages. **Problem:** - Navigation items like "Data Model" and "Webhooks" were not staying highlighted when navigating to detail pages - This was because `matchSubPages` defaulted to requiring exact path matches **Solution:** - Updated logic to make sub-page matching the default behavior (`end: item.matchSubPages === false`) - Only "Accounts" explicitly sets `matchSubPages: false` for its custom sub-item navigation - Removed redundant `matchSubPages: true` declarations throughout the codebase **URL Changes:** -- checked with @Bonapara - `/settings/workspace` → `/settings/general` - `/settings/workspace-members` → `/settings/members` - `/settings/api-keys` → `/settings/apis` - `/settings/developers/webhooks` → `/settings/webhooks` before: https://github.com/user-attachments/assets/56b94a49-9c31-4bb5-9875-ec24f4bc4d1e after: https://github.com/user-attachments/assets/38742599-c045-44d1-8020-56f3eacca779 --------- Co-authored-by: Félix Malfait <felix.malfait@gmail.com>
This commit is contained in:
@ -36,10 +36,10 @@ describe('title-utils', () => {
|
||||
expect(getPageTitleFromPath('/settings/accounts/emails/:accountUuid')).toBe(
|
||||
SettingsPageTitles.Accounts,
|
||||
);
|
||||
expect(getPageTitleFromPath('/settings/workspace-members')).toBe(
|
||||
expect(getPageTitleFromPath('/settings/members')).toBe(
|
||||
SettingsPageTitles.Members,
|
||||
);
|
||||
expect(getPageTitleFromPath('/settings/workspace')).toBe(
|
||||
expect(getPageTitleFromPath('/settings/general')).toBe(
|
||||
SettingsPageTitles.General,
|
||||
);
|
||||
expect(getPageTitleFromPath('/')).toBe('Twenty');
|
||||
|
||||
Reference in New Issue
Block a user