From da35a2f4791ce4eb65779866006b953b7aec8686 Mon Sep 17 00:00:00 2001 From: Ajay A Adsule <103304466+AjayAdsule@users.noreply.github.com> Date: Mon, 9 Jun 2025 18:38:57 +0530 Subject: [PATCH] =?UTF-8?q?fix:=20trigger=20onClickOutside=20when=20click?= =?UTF-8?q?=20escape=20for=20closing=20the=20model=20a=E2=80=A6=20(#12461)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Description: Resolved a bug where pressing the Escape key did not clear the filter chips when no filter value was present. Added a call to onClickOutside inside the useScopedHotkeys hook to ensure filter chips are removed when Escape is pressed and the dropdown is open but empty. https://github.com/user-attachments/assets/42ed35b0-f5a8-4d26-8407-fdd5e2cc4a42 fix #12319 --- .../modules/views/components/EditableFilterDropdownButton.tsx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/twenty-front/src/modules/views/components/EditableFilterDropdownButton.tsx b/packages/twenty-front/src/modules/views/components/EditableFilterDropdownButton.tsx index 020707a9c..acad6f466 100644 --- a/packages/twenty-front/src/modules/views/components/EditableFilterDropdownButton.tsx +++ b/packages/twenty-front/src/modules/views/components/EditableFilterDropdownButton.tsx @@ -30,7 +30,7 @@ export const EditableFilterDropdownButton = ({ removeRecordFilter({ recordFilterId: recordFilter.id }); }; - const handleDropdownClickOutside = useCallback(() => { + const onFilterDropdownClose = useCallback(() => { const recordFilterIsEmpty = isRecordFilterConsideredEmpty(recordFilter); if (recordFilterIsEmpty) { @@ -62,7 +62,7 @@ export const EditableFilterDropdownButton = ({ dropdownHotkeyScope={hotkeyScope} dropdownOffset={{ y: 8, x: 0 }} dropdownPlacement="bottom-start" - onClickOutside={handleDropdownClickOutside} + onClose={onFilterDropdownClose} /> );