diff --git a/packages/twenty-front/src/hooks/useIsMatchingLocation.ts b/packages/twenty-front/src/hooks/useIsMatchingLocation.ts index 36f525f1f..631bd032a 100644 --- a/packages/twenty-front/src/hooks/useIsMatchingLocation.ts +++ b/packages/twenty-front/src/hooks/useIsMatchingLocation.ts @@ -3,36 +3,26 @@ import { matchPath, useLocation } from 'react-router-dom'; import { AppBasePath } from '@/types/AppBasePath'; import { isNonEmptyString } from '@sniptt/guards'; import { isDefined } from 'twenty-shared'; -import { useCallback } from 'react'; export const useIsMatchingLocation = () => { const location = useLocation(); - // Infinite loop issue caused by `checkUserExistsQuery` in `useSignInUp`. - // Without executing this query, there is no infinite loop. - // I also noticed that in `isMatchingLocation` inside `continueWithEmail`, no loop occurs. - // Both functions are called within the `useEffect` of `SignInUpWorkspaceScopeFormEffect`. - // This led me to conclude that the issue comes from `useIsMatchingLocation`. - // Using `useCallback` prevent the loop. - const isMatchingLocation = useCallback( - (path: string, basePath?: AppBasePath) => { - const addTrailingSlash = (path: string) => - path.endsWith('/') ? path : path + '/'; + const addTrailingSlash = (path: string) => + path.endsWith('/') ? path : path + '/'; - const getConstructedPath = (path: string, basePath?: AppBasePath) => { - if (!isNonEmptyString(basePath)) return path; + const getConstructedPath = (path: string, basePath?: AppBasePath) => { + if (!isNonEmptyString(basePath)) return path; - return addTrailingSlash(basePath) + path; - }; + return addTrailingSlash(basePath) + path; + }; - const match = matchPath( - getConstructedPath(path, basePath), - location.pathname, - ); - return isDefined(match); - }, - [location.pathname], - ); + const isMatchingLocation = (path: string, basePath?: AppBasePath) => { + const match = matchPath( + getConstructedPath(path, basePath), + location.pathname, + ); + return isDefined(match); + }; return { isMatchingLocation, diff --git a/packages/twenty-front/src/modules/auth/sign-in-up/hooks/useSignInUp.ts b/packages/twenty-front/src/modules/auth/sign-in-up/hooks/useSignInUp.ts index e54d10bcc..5314cfb24 100644 --- a/packages/twenty-front/src/modules/auth/sign-in-up/hooks/useSignInUp.ts +++ b/packages/twenty-front/src/modules/auth/sign-in-up/hooks/useSignInUp.ts @@ -45,17 +45,7 @@ export const useSignInUp = (form: UseFormReturn