From e0bf8e43d1011094bf3dbd03e0f4d14531977d85 Mon Sep 17 00:00:00 2001
From: Charles Bochet <charlesBochet@users.noreply.github.com>
Date: Wed, 28 Feb 2024 17:49:45 +0100
Subject: [PATCH] Update relation cascade on standard objects favorite,
 attachment, activityTargets (#4227)

---
 .../field-metadata/utils/generate-default-value.ts        | 5 +++++
 .../metadata/object-metadata/object-metadata.service.ts   | 5 +++++
 .../services/workspace-migration-enum.service.ts          | 2 +-
 .../standard-objects/company.object-metadata.ts           | 8 +++++++-
 .../standard-objects/opportunity.object-metadata.ts       | 7 ++++++-
 .../standard-objects/person.object-metadata.ts            | 8 +++++++-
 .../standard-objects/workspace-member.object-metadata.ts  | 3 ++-
 7 files changed, 33 insertions(+), 5 deletions(-)

diff --git a/packages/twenty-server/src/metadata/field-metadata/utils/generate-default-value.ts b/packages/twenty-server/src/metadata/field-metadata/utils/generate-default-value.ts
index a6038042f..91d733c80 100644
--- a/packages/twenty-server/src/metadata/field-metadata/utils/generate-default-value.ts
+++ b/packages/twenty-server/src/metadata/field-metadata/utils/generate-default-value.ts
@@ -22,6 +22,11 @@ export function generateDefaultValue(
         url: '',
         label: '',
       };
+    case FieldMetadataType.CURRENCY:
+      return {
+        amountMicros: null,
+        currencyCode: '',
+      };
     default:
       return null;
   }
diff --git a/packages/twenty-server/src/metadata/object-metadata/object-metadata.service.ts b/packages/twenty-server/src/metadata/object-metadata/object-metadata.service.ts
index 03ccaa811..56c692b4a 100644
--- a/packages/twenty-server/src/metadata/object-metadata/object-metadata.service.ts
+++ b/packages/twenty-server/src/metadata/object-metadata/object-metadata.service.ts
@@ -28,6 +28,7 @@ import { DataSourceService } from 'src/metadata/data-source/data-source.service'
 import {
   RelationMetadataEntity,
   RelationMetadataType,
+  RelationOnDeleteAction,
 } from 'src/metadata/relation-metadata/relation-metadata.entity';
 import { computeCustomName } from 'src/workspace/utils/compute-custom-name.util';
 import { computeObjectTargetTable } from 'src/workspace/utils/compute-object-target-table.util';
@@ -355,6 +356,7 @@ export class ObjectMetadataService extends TypeOrmQueryService<ObjectMetadataEnt
                 createdObjectMetadata,
               ),
               referencedTableColumnName: 'id',
+              onDelete: RelationOnDeleteAction.CASCADE,
             },
           ],
         },
@@ -386,6 +388,7 @@ export class ObjectMetadataService extends TypeOrmQueryService<ObjectMetadataEnt
                 createdObjectMetadata,
               ),
               referencedTableColumnName: 'id',
+              onDelete: RelationOnDeleteAction.CASCADE,
             },
           ],
         },
@@ -611,6 +614,7 @@ export class ObjectMetadataService extends TypeOrmQueryService<ObjectMetadataEnt
           activityTargetRelationFieldMetadataMap[
             activityTargetObjectMetadata.id
           ].id,
+        onDeleteAction: RelationOnDeleteAction.CASCADE,
       },
     ]);
 
@@ -699,6 +703,7 @@ export class ObjectMetadataService extends TypeOrmQueryService<ObjectMetadataEnt
           favoriteRelationFieldMetadataMap[createdObjectMetadata.id].id,
         toFieldMetadataId:
           favoriteRelationFieldMetadataMap[favoriteObjectMetadata.id].id,
+        onDeleteAction: RelationOnDeleteAction.CASCADE,
       },
     ]);
 
diff --git a/packages/twenty-server/src/workspace/workspace-migration-runner/services/workspace-migration-enum.service.ts b/packages/twenty-server/src/workspace/workspace-migration-runner/services/workspace-migration-enum.service.ts
index 03bf1a20e..d2db1a083 100644
--- a/packages/twenty-server/src/workspace/workspace-migration-runner/services/workspace-migration-enum.service.ts
+++ b/packages/twenty-server/src/workspace/workspace-migration-runner/services/workspace-migration-enum.service.ts
@@ -186,6 +186,6 @@ export class WorkspaceMigrationEnumService {
   }
 
   private getStringifyValue(value: any) {
-    return typeof value === 'string' ? value : `'${value}'`;
+    return `'${value}'`;
   }
 }
diff --git a/packages/twenty-server/src/workspace/workspace-sync-metadata/standard-objects/company.object-metadata.ts b/packages/twenty-server/src/workspace/workspace-sync-metadata/standard-objects/company.object-metadata.ts
index c160efa13..20b9aa9a8 100644
--- a/packages/twenty-server/src/workspace/workspace-sync-metadata/standard-objects/company.object-metadata.ts
+++ b/packages/twenty-server/src/workspace/workspace-sync-metadata/standard-objects/company.object-metadata.ts
@@ -1,7 +1,10 @@
 import { CurrencyMetadata } from 'src/metadata/field-metadata/composite-types/currency.composite-type';
 import { LinkMetadata } from 'src/metadata/field-metadata/composite-types/link.composite-type';
 import { FieldMetadataType } from 'src/metadata/field-metadata/field-metadata.entity';
-import { RelationMetadataType } from 'src/metadata/relation-metadata/relation-metadata.entity';
+import {
+  RelationMetadataType,
+  RelationOnDeleteAction,
+} from 'src/metadata/relation-metadata/relation-metadata.entity';
 import { FieldMetadata } from 'src/workspace/workspace-sync-metadata/decorators/field-metadata.decorator';
 import { IsNullable } from 'src/workspace/workspace-sync-metadata/decorators/is-nullable.decorator';
 import { IsSystem } from 'src/workspace/workspace-sync-metadata/decorators/is-system.decorator';
@@ -139,6 +142,7 @@ export class CompanyObjectMetadata extends BaseObjectMetadata {
   @RelationMetadata({
     type: RelationMetadataType.ONE_TO_MANY,
     objectName: 'activityTarget',
+    onDelete: RelationOnDeleteAction.CASCADE,
   })
   @IsNullable()
   activityTargets: ActivityTargetObjectMetadata[];
@@ -165,6 +169,7 @@ export class CompanyObjectMetadata extends BaseObjectMetadata {
   @RelationMetadata({
     type: RelationMetadataType.ONE_TO_MANY,
     objectName: 'favorite',
+    onDelete: RelationOnDeleteAction.CASCADE,
   })
   @IsNullable()
   favorites: FavoriteObjectMetadata[];
@@ -178,6 +183,7 @@ export class CompanyObjectMetadata extends BaseObjectMetadata {
   @RelationMetadata({
     type: RelationMetadataType.ONE_TO_MANY,
     objectName: 'attachment',
+    onDelete: RelationOnDeleteAction.CASCADE,
   })
   @IsNullable()
   attachments: AttachmentObjectMetadata[];
diff --git a/packages/twenty-server/src/workspace/workspace-sync-metadata/standard-objects/opportunity.object-metadata.ts b/packages/twenty-server/src/workspace/workspace-sync-metadata/standard-objects/opportunity.object-metadata.ts
index bf0112ac8..6fcc97d6f 100644
--- a/packages/twenty-server/src/workspace/workspace-sync-metadata/standard-objects/opportunity.object-metadata.ts
+++ b/packages/twenty-server/src/workspace/workspace-sync-metadata/standard-objects/opportunity.object-metadata.ts
@@ -1,6 +1,9 @@
 import { CurrencyMetadata } from 'src/metadata/field-metadata/composite-types/currency.composite-type';
 import { FieldMetadataType } from 'src/metadata/field-metadata/field-metadata.entity';
-import { RelationMetadataType } from 'src/metadata/relation-metadata/relation-metadata.entity';
+import {
+  RelationMetadataType,
+  RelationOnDeleteAction,
+} from 'src/metadata/relation-metadata/relation-metadata.entity';
 import { FieldMetadata } from 'src/workspace/workspace-sync-metadata/decorators/field-metadata.decorator';
 import { IsNullable } from 'src/workspace/workspace-sync-metadata/decorators/is-nullable.decorator';
 import { IsSystem } from 'src/workspace/workspace-sync-metadata/decorators/is-system.decorator';
@@ -128,6 +131,7 @@ export class OpportunityObjectMetadata extends BaseObjectMetadata {
   @RelationMetadata({
     type: RelationMetadataType.ONE_TO_MANY,
     objectName: 'favorite',
+    onDelete: RelationOnDeleteAction.CASCADE,
   })
   @IsNullable()
   favorites: FavoriteObjectMetadata[];
@@ -141,6 +145,7 @@ export class OpportunityObjectMetadata extends BaseObjectMetadata {
   @RelationMetadata({
     type: RelationMetadataType.ONE_TO_MANY,
     objectName: 'activityTarget',
+    onDelete: RelationOnDeleteAction.CASCADE,
   })
   @IsNullable()
   activityTargets: ActivityTargetObjectMetadata[];
diff --git a/packages/twenty-server/src/workspace/workspace-sync-metadata/standard-objects/person.object-metadata.ts b/packages/twenty-server/src/workspace/workspace-sync-metadata/standard-objects/person.object-metadata.ts
index ab6ad554a..e067212c1 100644
--- a/packages/twenty-server/src/workspace/workspace-sync-metadata/standard-objects/person.object-metadata.ts
+++ b/packages/twenty-server/src/workspace/workspace-sync-metadata/standard-objects/person.object-metadata.ts
@@ -1,7 +1,10 @@
 import { FullNameMetadata } from 'src/metadata/field-metadata/composite-types/full-name.composite-type';
 import { LinkMetadata } from 'src/metadata/field-metadata/composite-types/link.composite-type';
 import { FieldMetadataType } from 'src/metadata/field-metadata/field-metadata.entity';
-import { RelationMetadataType } from 'src/metadata/relation-metadata/relation-metadata.entity';
+import {
+  RelationMetadataType,
+  RelationOnDeleteAction,
+} from 'src/metadata/relation-metadata/relation-metadata.entity';
 import { FieldMetadata } from 'src/workspace/workspace-sync-metadata/decorators/field-metadata.decorator';
 import { IsNullable } from 'src/workspace/workspace-sync-metadata/decorators/is-nullable.decorator';
 import { IsSystem } from 'src/workspace/workspace-sync-metadata/decorators/is-system.decorator';
@@ -135,6 +138,7 @@ export class PersonObjectMetadata extends BaseObjectMetadata {
   @RelationMetadata({
     type: RelationMetadataType.ONE_TO_MANY,
     objectName: 'activityTarget',
+    onDelete: RelationOnDeleteAction.CASCADE,
   })
   @IsNullable()
   activityTargets: ActivityTargetObjectMetadata[];
@@ -148,6 +152,7 @@ export class PersonObjectMetadata extends BaseObjectMetadata {
   @RelationMetadata({
     type: RelationMetadataType.ONE_TO_MANY,
     objectName: 'favorite',
+    onDelete: RelationOnDeleteAction.CASCADE,
   })
   @IsNullable()
   favorites: FavoriteObjectMetadata[];
@@ -161,6 +166,7 @@ export class PersonObjectMetadata extends BaseObjectMetadata {
   @RelationMetadata({
     type: RelationMetadataType.ONE_TO_MANY,
     objectName: 'attachment',
+    onDelete: RelationOnDeleteAction.CASCADE,
   })
   @IsNullable()
   attachments: AttachmentObjectMetadata[];
diff --git a/packages/twenty-server/src/workspace/workspace-sync-metadata/standard-objects/workspace-member.object-metadata.ts b/packages/twenty-server/src/workspace/workspace-sync-metadata/standard-objects/workspace-member.object-metadata.ts
index 2879e55d4..74eab0acf 100644
--- a/packages/twenty-server/src/workspace/workspace-sync-metadata/standard-objects/workspace-member.object-metadata.ts
+++ b/packages/twenty-server/src/workspace/workspace-sync-metadata/standard-objects/workspace-member.object-metadata.ts
@@ -1,6 +1,6 @@
 import { FullNameMetadata } from 'src/metadata/field-metadata/composite-types/full-name.composite-type';
 import { FieldMetadataType } from 'src/metadata/field-metadata/field-metadata.entity';
-import { RelationMetadataType } from 'src/metadata/relation-metadata/relation-metadata.entity';
+import { RelationMetadataType, RelationOnDeleteAction } from 'src/metadata/relation-metadata/relation-metadata.entity';
 import { FieldMetadata } from 'src/workspace/workspace-sync-metadata/decorators/field-metadata.decorator';
 import { Gate } from 'src/workspace/workspace-sync-metadata/decorators/gate.decorator';
 import { IsNullable } from 'src/workspace/workspace-sync-metadata/decorators/is-nullable.decorator';
@@ -114,6 +114,7 @@ export class WorkspaceMemberObjectMetadata extends BaseObjectMetadata {
   @RelationMetadata({
     type: RelationMetadataType.ONE_TO_MANY,
     objectName: 'favorite',
+    onDelete: RelationOnDeleteAction.CASCADE,
   })
   @IsNullable()
   favorites: FavoriteObjectMetadata[];