Cosmetic refactoring on context menu (#1209)

* Cosmetic refactoring on context menu

* Fix lint

* Fix lint

* Fix lint

* Fix lint

* Fix lint

* Fix lint

front/src/modules/ui/table/action-bar/components/EntityTableActionBar.tsx

@@ -8,5 +8,5 @@ import { selectedRowIdsSelector } from '../../states/selectors/selectedRowIdsSel
 export function EntityTableActionBar() {
   const selectedRowIds = useRecoilValue(selectedRowIdsSelector);
 
-  return <ActionBar selectedIds={selectedRowIds}></ActionBar>;
+  return <ActionBar selectedIds={selectedRowIds} />;
 }

front/src/modules/ui/table/components/CheckboxCell.tsx

@@ -2,7 +2,7 @@ import { useCallback } from 'react';
 import styled from '@emotion/styled';
 import { useSetRecoilState } from 'recoil';
 
-import { actionBarOpenState } from '@/ui/action-bar/states/ActionBarIsOpenState';
+import { actionBarOpenState } from '@/ui/action-bar/states/actionBarIsOpenState';
 import { Checkbox } from '@/ui/input/checkbox/components/Checkbox';
 
 import { useCurrentRowSelected } from '../hooks/useCurrentRowSelected';

front/src/modules/ui/table/components/EntityTableCell.tsx

@@ -1,8 +1,8 @@
 import { useContext } from 'react';
 import { useSetRecoilState } from 'recoil';
 
-import { contextMenuOpenState } from '@/ui/context-menu/states/ContextMenuIsOpenState';
-import { contextMenuPositionState } from '@/ui/context-menu/states/ContextMenuPositionState';
+import { contextMenuIsOpenState } from '@/ui/context-menu/states/contextMenuIsOpenState';
+import { contextMenuPositionState } from '@/ui/context-menu/states/contextMenuPositionState';
 import { RecoilScope } from '@/ui/utilities/recoil-scope/components/RecoilScope';
 
 import { ColumnIndexContext } from '../contexts/ColumnIndexContext';
@@ -12,7 +12,7 @@ import { useCurrentRowSelected } from '../hooks/useCurrentRowSelected';
 
 export function EntityTableCell({ cellIndex }: { cellIndex: number }) {
   const setContextMenuPosition = useSetRecoilState(contextMenuPositionState);
-  const setContextMenuOpenState = useSetRecoilState(contextMenuOpenState);
+  const setContextMenuOpenState = useSetRecoilState(contextMenuIsOpenState);
 
   const { setCurrentRowSelected } = useCurrentRowSelected();
 

front/src/modules/ui/table/components/GenericEntityTableData.tsx

@@ -1,3 +1,5 @@
+import { useEffect } from 'react';
+
 import { defaultOrderBy } from '@/people/queries';
 import { FilterDefinition } from '@/ui/filter-n-sort/types/FilterDefinition';
 import { useSetEntityTableData } from '@/ui/table/hooks/useSetEntityTableData';
@@ -8,16 +10,16 @@ export function GenericEntityTableData({
   orderBy = defaultOrderBy,
   whereFilters,
   filterDefinitionArray,
-  setActionBar,
-  setContextMenu,
+  setActionBarEntries,
+  setContextMenuEntries,
 }: {
   useGetRequest: any;
   getRequestResultKey: string;
   orderBy?: any;
   whereFilters?: any;
   filterDefinitionArray: FilterDefinition[];
-  setActionBar?: () => void;
-  setContextMenu?: () => void;
+  setActionBarEntries?: () => void;
+  setContextMenuEntries?: () => void;
 }) {
   const setEntityTableData = useSetEntityTableData();
   useGetRequest({
@@ -28,11 +30,10 @@ export function GenericEntityTableData({
     },
   });
 
-  if (setActionBar) {
-    setActionBar();
-  }
-  if (setContextMenu) {
-    setContextMenu();
-  }
+  useEffect(() => {
+    setActionBarEntries?.();
+    setContextMenuEntries?.();
+  }, [setActionBarEntries, setContextMenuEntries]);
+
   return <></>;
 }

front/src/modules/ui/table/context-menu/components/EntityTableContextMenu.tsx

@@ -7,5 +7,5 @@ import { selectedRowIdsSelector } from '../../states/selectors/selectedRowIdsSel
 
 export function EntityTableContextMenu() {
   const selectedRowIds = useRecoilValue(selectedRowIdsSelector);
-  return <ContextMenu selectedIds={selectedRowIds}></ContextMenu>;
+  return <ContextMenu selectedIds={selectedRowIds} />;
 }