Fix search fallback action (#10256)

The command menu search bar was reset after clicking on the `Search
records` fallback action, but it shouldn't.
This PR:
- Introduces a new type of action: `Fallback` actions
- Reset the search bar only if the action key differs from
'record-search-fallback'
This commit is contained in:
Raphaël Bosi
2025-02-17 15:24:42 +01:00
committed by GitHub
parent e8a55fd4dc
commit e6a484bb58
7 changed files with 38 additions and 26 deletions

View File

@ -1,4 +1,3 @@
import { RecordAgnosticActionsKey } from '@/action-menu/actions/record-agnostic-actions/types/RecordAgnosticActionsKey';
import { actionMenuEntriesComponentSelector } from '@/action-menu/states/actionMenuEntriesComponentSelector';
import {
ActionMenuEntryScope,
@ -129,24 +128,20 @@ export const useCommandMenuCommands = () => {
hotKeys: actionMenuEntry.hotKeys,
}));
const searchRecordsAction = actionMenuEntries.find(
(actionMenuEntry) =>
actionMenuEntry.key === RecordAgnosticActionsKey.SEARCH_RECORDS,
);
const fallbackCommands: Command[] = searchRecordsAction
? [
{
id: searchRecordsAction.key,
label: i18n._(searchRecordsAction.label),
Icon: searchRecordsAction.Icon,
onCommandClick: searchRecordsAction.onClick,
type: CommandType.StandardAction,
scope: CommandScope.Global,
hotKeys: searchRecordsAction.hotKeys,
},
]
: [];
const fallbackCommands: Command[] = actionMenuEntries
?.filter(
(actionMenuEntry) =>
actionMenuEntry.type === ActionMenuEntryType.Fallback,
)
?.map((actionMenuEntry) => ({
id: actionMenuEntry.key,
label: i18n._(actionMenuEntry.label),
Icon: actionMenuEntry.Icon,
onCommandClick: actionMenuEntry.onClick,
type: CommandType.Fallback,
scope: CommandScope.Global,
hotKeys: actionMenuEntry.hotKeys,
}));
return {
copilotCommands,