chore: enable no-console eslint rule for tests and stories (#4816)

Re-enables no-console eslint rule in stories and tests files:
- In stories, use `action` from '@storybook/addon-actions' or `fn` from
'@storybook/test' instead of console.
- In tests, console methods can be mocked like this:
`global.console.error = jest.fn()`.
This commit is contained in:
Thaïs
2024-04-04 18:36:39 +02:00
committed by GitHub
parent 48b1be9917
commit e784dc8a98
9 changed files with 17 additions and 55 deletions

View File

@ -1,3 +1,4 @@
import { action } from '@storybook/addon-actions';
import { Meta, StoryObj } from '@storybook/react';
import { IconBell } from 'twenty-ui';
@ -12,8 +13,7 @@ const meta: Meta<typeof DraggableList> = {
component: DraggableList,
decorators: [ComponentDecorator],
parameters: {
// eslint-disable-next-line no-console
onDragEnd: () => console.log('dragged'),
onDragEnd: action('dragged'),
},
argTypes: {
draggableItems: { control: false },

View File

@ -1,3 +1,4 @@
import { action } from '@storybook/addon-actions';
import { Meta, StoryObj } from '@storybook/react';
import { IconBell } from 'twenty-ui';
@ -23,10 +24,8 @@ export const Default: Story = {
LeftIcon: IconBell,
accent: 'default',
iconButtons: [
// eslint-disable-next-line no-console
{ Icon: IconBell, onClick: () => console.log('Clicked') },
// eslint-disable-next-line no-console
{ Icon: IconBell, onClick: () => console.log('Clicked') },
{ Icon: IconBell, onClick: action('Clicked') },
{ Icon: IconBell, onClick: action('Clicked') },
],
},
decorators: [ComponentDecorator],
@ -86,15 +85,11 @@ export const Catalog: CatalogStory<Story, typeof MenuItem> = {
iconButtons: [
{
Icon: IconBell,
onClick: () =>
// eslint-disable-next-line no-console
console.log('Clicked on first icon button'),
onClick: action('Clicked on first icon button'),
},
{
Icon: IconBell,
onClick: () =>
// eslint-disable-next-line no-console
console.log('Clicked on second icon button'),
onClick: action('Clicked on second icon button'),
},
],
};

View File

@ -1,3 +1,4 @@
import { action } from '@storybook/addon-actions';
import { Meta, StoryObj } from '@storybook/react';
import { IconBell, IconMinus } from 'twenty-ui';
@ -24,10 +25,8 @@ export const Default: Story = {
args: {
LeftIcon: IconBell,
accent: 'default',
// eslint-disable-next-line no-console
iconButtons: [{ Icon: IconMinus, onClick: () => console.log('Clicked') }],
// eslint-disable-next-line no-console
onClick: () => console.log('Clicked'),
iconButtons: [{ Icon: IconMinus, onClick: action('Clicked') }],
onClick: action('Clicked'),
text: 'Menu item draggable',
isDragDisabled: false,
},
@ -87,9 +86,7 @@ export const Catalog: Story = {
iconButtons: [
{
Icon: IconMinus,
onClick: () =>
// eslint-disable-next-line no-console
console.log('Clicked on minus icon button'),
onClick: action('Clicked on minus icon button'),
},
],
};

View File

@ -52,8 +52,7 @@ describe('useAvailableScopeIdOrThrow', () => {
});
it('should throw an error if no scopeId is provided and scopeId is undefined in the context', () => {
// eslint-disable-next-line no-console
console.error = jest.fn();
global.console.error = jest.fn();
const renderFunction = () =>
renderHook(() => ({