admin/twenty
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Add redis to useMetadataCache yoga plugin (#5194)

Browse Source 
## Context
@lucasbordeau introduced a new Yoga plugin that allows us to cache our
requests (👏), see https://github.com/twentyhq/twenty/pull/5189
I'm simply updating the implementation to allow us to use different
cache storage types such as redis
Also adding a check so it does not use cache for other operations than
ObjectMetadataItems

## Test
locally, first call takes 340ms, 2nd takes 30ms with 'redis' and 13ms
with 'memory'
This commit is contained in:
Weiko
2024-04-26 19:27:09 +02:00
committed by GitHub
parent 5e143f1f49
commit ebc25c8695
3 changed files with 43 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

33
packages/twenty-server/src/engine/api/graphql/graphql-config/hooks/use-cached-metadata.ts
View File

@ -1,8 +1,12 @@
import { Plugin } from 'graphql-yoga';
export function useCachedMetadata(): Plugin {
const cache = new Map<string, any>();
export type CacheMetadataPluginConfig = {
cacheGetter: (key: string) => any;
cacheSetter: (key: string, value: any) => void;
operationsToCache: string[];
};
export function useCachedMetadata(config: CacheMetadataPluginConfig): Plugin {
const computeCacheKey = (serverContext: any) => {
const workspaceId = serverContext.req.workspace?.id ?? 'anonymous';
const cacheVersion = serverContext.req.cacheVersion ?? '0';
@ -10,28 +14,37 @@ export function useCachedMetadata(): Plugin {
return `${workspaceId}:${cacheVersion}`;
};
const getOperationName = (serverContext: any) =>
serverContext?.req?.body?.operationName;
return {
onRequest: ({ endResponse, serverContext }) => {
onRequest: async ({ endResponse, serverContext }) => {
if (!config.operationsToCache.includes(getOperationName(serverContext))) {
return;
}
const cacheKey = computeCacheKey(serverContext);
const foundInCache = cache.has(cacheKey);
if (foundInCache) {
const cachedResponse = cache.get(cacheKey);
const cachedResponse = await config.cacheGetter(cacheKey);
if (cachedResponse) {
const earlyResponse = Response.json(cachedResponse);
return endResponse(earlyResponse);
}
},
onResponse: async ({ response, serverContext }) => {
if (!config.operationsToCache.includes(getOperationName(serverContext))) {
return;
}
const cacheKey = computeCacheKey(serverContext);
const foundInCache = cache.has(cacheKey);
const cachedResponse = await config.cacheGetter(cacheKey);
if (!foundInCache) {
if (!cachedResponse) {
const responseBody = await response.json();
cache.set(cacheKey, responseBody);
config.cacheSetter(cacheKey, responseBody);
}
},
};