Small fixes on accounts settings (#6157)

- Add keys in components map
This commit is contained in:
bosiraphael
2024-07-08 12:00:00 +02:00
committed by GitHub
parent af83879d7a
commit ef849d316f
3 changed files with 7 additions and 5 deletions

View File

@ -11,6 +11,7 @@ import { SettingsAccountsListEmptyStateCard } from '@/settings/accounts/componen
import { SETTINGS_ACCOUNT_CALENDAR_CHANNELS_TAB_LIST_COMPONENT_ID } from '@/settings/accounts/constants/SettingsAccountCalendarChannelsTabListComponentId'; import { SETTINGS_ACCOUNT_CALENDAR_CHANNELS_TAB_LIST_COMPONENT_ID } from '@/settings/accounts/constants/SettingsAccountCalendarChannelsTabListComponentId';
import { TabList } from '@/ui/layout/tab/components/TabList'; import { TabList } from '@/ui/layout/tab/components/TabList';
import { useTabList } from '@/ui/layout/tab/hooks/useTabList'; import { useTabList } from '@/ui/layout/tab/hooks/useTabList';
import React from 'react';
export const SettingsAccountsCalendarChannelsContainer = () => { export const SettingsAccountsCalendarChannelsContainer = () => {
const { activeTabIdState } = useTabList( const { activeTabIdState } = useTabList(
@ -59,13 +60,13 @@ export const SettingsAccountsCalendarChannelsContainer = () => {
tabs={tabs} tabs={tabs}
/> />
{calendarChannels.map((calendarChannel) => ( {calendarChannels.map((calendarChannel) => (
<> <React.Fragment key={calendarChannel.id}>
{calendarChannel.id === activeTabId && ( {calendarChannel.id === activeTabId && (
<SettingsAccountsCalendarChannelDetails <SettingsAccountsCalendarChannelDetails
calendarChannel={calendarChannel} calendarChannel={calendarChannel}
/> />
)} )}
</> </React.Fragment>
))} ))}
{false && activeTabId === 'general' && ( {false && activeTabId === 'general' && (
<SettingsAccountsCalendarChannelsGeneral /> <SettingsAccountsCalendarChannelsGeneral />

View File

@ -10,6 +10,7 @@ import { SettingsAccountsMessageChannelDetails } from '@/settings/accounts/compo
import { SETTINGS_ACCOUNT_MESSAGE_CHANNELS_TAB_LIST_COMPONENT_ID } from '@/settings/accounts/constants/SettingsAccountMessageChannelsTabListComponentId'; import { SETTINGS_ACCOUNT_MESSAGE_CHANNELS_TAB_LIST_COMPONENT_ID } from '@/settings/accounts/constants/SettingsAccountMessageChannelsTabListComponentId';
import { TabList } from '@/ui/layout/tab/components/TabList'; import { TabList } from '@/ui/layout/tab/components/TabList';
import { useTabList } from '@/ui/layout/tab/hooks/useTabList'; import { useTabList } from '@/ui/layout/tab/hooks/useTabList';
import React from 'react';
export const SettingsAccountsMessageChannelsContainer = () => { export const SettingsAccountsMessageChannelsContainer = () => {
const { activeTabIdState } = useTabList( const { activeTabIdState } = useTabList(
@ -58,13 +59,13 @@ export const SettingsAccountsMessageChannelsContainer = () => {
tabs={tabs} tabs={tabs}
/> />
{messageChannels.map((messageChannel) => ( {messageChannels.map((messageChannel) => (
<> <React.Fragment key={messageChannel.id}>
{messageChannel.id === activeTabId && ( {messageChannel.id === activeTabId && (
<SettingsAccountsMessageChannelDetails <SettingsAccountsMessageChannelDetails
messageChannel={messageChannel} messageChannel={messageChannel}
/> />
)} )}
</> </React.Fragment>
))} ))}
</> </>
); );

View File

@ -1,5 +1,5 @@
import { ReactNode } from 'react';
import styled from '@emotion/styled'; import styled from '@emotion/styled';
import { ReactNode } from 'react';
import { Radio } from '@/ui/input/components/Radio'; import { Radio } from '@/ui/input/components/Radio';
import { Card } from '@/ui/layout/card/components/Card'; import { Card } from '@/ui/layout/card/components/Card';