From f145862cf1454600b94ca96ef54c3a8049d59d0c Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Rapha=C3=ABl=20Bosi?=
 <71827178+bosiraphael@users.noreply.github.com>
Date: Thu, 27 Mar 2025 17:03:06 +0100
Subject: [PATCH] Design fixes on show page (#11221)

- Fixes record inline cell height
- Fixes notes body empty state
---
 .../object-record/record-field/utils/isFieldValueEmpty.ts   | 6 ++----
 .../components/RecordInlineCellContainer.tsx                | 6 +++---
 .../components/RecordInlineCellDisplayMode.tsx              | 3 ---
 .../object-record/record-show/components/FieldsCard.tsx     | 3 +++
 4 files changed, 8 insertions(+), 10 deletions(-)

diff --git a/packages/twenty-front/src/modules/object-record/record-field/utils/isFieldValueEmpty.ts b/packages/twenty-front/src/modules/object-record/record-field/utils/isFieldValueEmpty.ts
index 8492625c9..ea24841d0 100644
--- a/packages/twenty-front/src/modules/object-record/record-field/utils/isFieldValueEmpty.ts
+++ b/packages/twenty-front/src/modules/object-record/record-field/utils/isFieldValueEmpty.ts
@@ -36,8 +36,8 @@ import { isFieldSelectValue } from '@/object-record/record-field/types/guards/is
 import { isFieldText } from '@/object-record/record-field/types/guards/isFieldText';
 import { isFieldTsVector } from '@/object-record/record-field/types/guards/isFieldTsVectorValue';
 import { isFieldUuid } from '@/object-record/record-field/types/guards/isFieldUuid';
-import { stripSimpleQuotesFromString } from '~/utils/string/stripSimpleQuotesFromString';
 import { isDefined } from 'twenty-shared/utils';
+import { stripSimpleQuotesFromString } from '~/utils/string/stripSimpleQuotesFromString';
 
 const isValueEmpty = (value: unknown) =>
   !isDefined(value) ||
@@ -146,9 +146,7 @@ export const isFieldValueEmpty = ({
 
   if (isFieldRichTextV2(fieldDefinition)) {
     return (
-      !isFieldRichTextV2Value(fieldValue) ||
-      (isValueEmpty(fieldValue?.blocknote) &&
-        isValueEmpty(fieldValue?.markdown))
+      !isFieldRichTextV2Value(fieldValue) || isValueEmpty(fieldValue?.markdown)
     );
   }
 
diff --git a/packages/twenty-front/src/modules/object-record/record-inline-cell/components/RecordInlineCellContainer.tsx b/packages/twenty-front/src/modules/object-record/record-inline-cell/components/RecordInlineCellContainer.tsx
index bc0897065..db37f958e 100644
--- a/packages/twenty-front/src/modules/object-record/record-inline-cell/components/RecordInlineCellContainer.tsx
+++ b/packages/twenty-front/src/modules/object-record/record-inline-cell/components/RecordInlineCellContainer.tsx
@@ -38,7 +38,6 @@ const StyledLabelAndIconContainer = styled.div`
   display: flex;
   gap: ${({ theme }) => theme.spacing(1)};
   height: 18px;
-  padding-top: 3px;
 `;
 
 const StyledValueContainer = styled.div`
@@ -57,15 +56,16 @@ const StyledLabelContainer = styled.div<{ width?: number }>`
 const StyledInlineCellBaseContainer = styled.div<{
   isDisplayModeFixHeight?: boolean;
 }>`
-  align-items: flex-start;
   box-sizing: border-box;
   width: 100%;
   display: flex;
-  height: fit-content;
   line-height: ${({ isDisplayModeFixHeight }) =>
     isDisplayModeFixHeight ? `24px` : `18px`};
+  height: ${({ isDisplayModeFixHeight }) =>
+    isDisplayModeFixHeight ? `24px` : `18px`};
   gap: ${({ theme }) => theme.spacing(1)};
   user-select: none;
+  align-items: center;
   justify-content: center;
 `;
 
diff --git a/packages/twenty-front/src/modules/object-record/record-inline-cell/components/RecordInlineCellDisplayMode.tsx b/packages/twenty-front/src/modules/object-record/record-inline-cell/components/RecordInlineCellDisplayMode.tsx
index 41c0be8e1..9de0f4671 100644
--- a/packages/twenty-front/src/modules/object-record/record-inline-cell/components/RecordInlineCellDisplayMode.tsx
+++ b/packages/twenty-front/src/modules/object-record/record-inline-cell/components/RecordInlineCellDisplayMode.tsx
@@ -43,9 +43,6 @@ const StyledRecordInlineCellNormalModeInnerContainer = styled.div`
   align-content: center;
   align-items: center;
   color: ${({ theme }) => theme.font.color.primary};
-  padding-top: 3px;
-  padding-bottom: 3px;
-
   height: fit-content;
 
   overflow: hidden;
diff --git a/packages/twenty-front/src/modules/object-record/record-show/components/FieldsCard.tsx b/packages/twenty-front/src/modules/object-record/record-show/components/FieldsCard.tsx
index af500aab3..d75cc5b58 100644
--- a/packages/twenty-front/src/modules/object-record/record-show/components/FieldsCard.tsx
+++ b/packages/twenty-front/src/modules/object-record/record-show/components/FieldsCard.tsx
@@ -108,6 +108,7 @@ export const FieldsCard = ({
                     }),
                     useUpdateRecord: useUpdateOneObjectRecordMutation,
                     hotkeyScope: InlineCellHotkeyScope.InlineCell,
+                    isDisplayModeFixHeight: true,
                   }}
                 >
                   <ActivityTargetsInlineCell
@@ -144,6 +145,7 @@ export const FieldsCard = ({
                   }),
                   useUpdateRecord: useUpdateOneObjectRecordMutation,
                   hotkeyScope: InlineCellHotkeyScope.InlineCell,
+                  isDisplayModeFixHeight: true,
                 }}
               >
                 <RecordFieldComponentInstanceContext.Provider
@@ -179,6 +181,7 @@ export const FieldsCard = ({
             }),
             useUpdateRecord: useUpdateOneObjectRecordMutation,
             hotkeyScope: InlineCellHotkeyScope.InlineCell,
+            isDisplayModeFixHeight: true,
           }}
         >
           <RecordDetailRelationSection