admin/twenty
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

[feat][FE] Stop persisting new empty records (#4853)

Browse Source 
## Context
Closes [#4773](https://github.com/twentyhq/twenty/issues/4773)
Persisting of new records is delayed to cell escape and not performed
for empty records.

## How was it tested?
Locally tested + jest

---------

Co-authored-by: Charles Bochet <charles@twenty.com>
This commit is contained in:
Marie
2024-04-10 19:16:34 +02:00
committed by GitHub
parent 01991fe717
commit f25d58b0d9
23 changed files with 270 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
packages/twenty-front/src/pages/object-record/RecordIndexPage.tsx
View File

@ -1,9 +1,9 @@
import { useParams } from 'react-router-dom';
import styled from '@emotion/styled';
import { v4 } from 'uuid';
import { useObjectNameSingularFromPlural } from '@/object-metadata/hooks/useObjectNameSingularFromPlural';
import { useCreateOneRecord } from '@/object-record/hooks/useCreateOneRecord';
import { RecordIndexContainer } from '@/object-record/record-index/components/RecordIndexContainer';
import { useRecordTable } from '@/object-record/record-table/hooks/useRecordTable';
import { DEFAULT_CELL_SCOPE } from '@/object-record/record-table/record-table-cell/hooks/useOpenRecordTableCell';
import { useSelectedTableCellEditMode } from '@/object-record/record-table/record-table-cell/hooks/useSelectedTableCellEditMode';
import { PageBody } from '@/ui/layout/page/PageBody';
@ -20,14 +20,6 @@ const StyledIndexContainer = styled.div`
export const RecordIndexPage = () => {
const objectNamePlural = useParams().objectNamePlural ?? '';
const { objectNameSingular } = useObjectNameSingularFromPlural({
objectNamePlural,
});
const { createOneRecord: createOneObject } = useCreateOneRecord({
objectNameSingular,
});
const recordIndexId = objectNamePlural ?? '';
const setHotkeyScope = useSetHotkeyScope();
@ -35,12 +27,14 @@ export const RecordIndexPage = () => {
scopeId: recordIndexId,
});
const handleAddButtonClick = async () => {
await createOneObject?.({
position: 'first',
});
const { setPendingRecordId } = useRecordTable({
recordTableId: recordIndexId,
});
setSelectedTableCellEditMode(0, 0);
const handleAddButtonClick = async () => {
setPendingRecordId(v4());
setSelectedTableCellEditMode(-1, 0);
setHotkeyScope(DEFAULT_CELL_SCOPE.scope, DEFAULT_CELL_SCOPE.customScopes);
};