admin/twenty
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Remove messageId defined assertion as it could not be in messaging sync (#5784)

Browse Source 
Instead, we will log but ignore the message
This commit is contained in:
Charles Bochet
2024-06-09 00:15:12 +02:00
committed by GitHub
parent d4610774fa
commit f2cd65557e
2 changed files with 9 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
packages/twenty-server/src/modules/messaging/message-import-manager/drivers/gmail/services/messaging-gmail-fetch-messages-by-batches.service.ts
View File

@ -114,6 +114,14 @@ export class MessagingGmailFetchMessagesByBatchesService {
return null; return null;
} }
if (!headerMessageId) {
this.logger.log(
`Header Message ID is missing while importing message in workspace ${workspaceId} and account ${connectedAccountId}`,
);
return null;
}
const participants = [ const participants = [
...formatAddressObjectAsParticipants(from, 'from'), ...formatAddressObjectAsParticipants(from, 'from'),
...formatAddressObjectAsParticipants(to ?? deliveredTo, 'to'), ...formatAddressObjectAsParticipants(to ?? deliveredTo, 'to'),
@ -182,10 +190,6 @@ export class MessagingGmailFetchMessagesByBatchesService {
const internalDate = message.internalDate; const internalDate = message.internalDate;
assert(id, 'ID is missing'); assert(id, 'ID is missing');
assert(
messageId,
'Message-ID is missing: ' + JSON.stringify(message.payload?.headers),
);
assert(threadId, 'Thread-ID is missing'); assert(threadId, 'Thread-ID is missing');
assert(historyId, 'History-ID is missing'); assert(historyId, 'History-ID is missing');
assert(internalDate, 'Internal date is missing'); assert(internalDate, 'Internal date is missing');

1
packages/twenty-server/src/modules/messaging/message-import-manager/drivers/gmail/services/messaging-gmail-messages-import.service.ts
View File

@ -158,6 +158,7 @@ export class MessagingGmailMessagesImportService {
); );
if (error.code === undefined) { if (error.code === undefined) {
// This should never happen as all errors must be known
throw error; throw error;
} }