admin/twenty
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

TWNTY-3825 - ESLint rule: const naming (#4171)

Browse Source 
* ESLint rule: const naming

Co-authored-by: v1b3m <vibenjamin6@gmail.com>
Co-authored-by: KlingerMatheus <klinger.matheus@gitstart.dev>

* Refactor according to review

Co-authored-by: v1b3m <vibenjamin6@gmail.com>
Co-authored-by: KlingerMatheus <klinger.matheus@gitstart.dev>

* refactor: Reverts changes on `twenty-server`

Co-authored-by: KlingerMatheus <klinger.matheus@gitstart.dev>
Co-authored-by: v1b3m <vibenjamin6@gmail.com>

---------

Co-authored-by: gitstart-twenty <gitstart-twenty@users.noreply.github.com>
Co-authored-by: v1b3m <vibenjamin6@gmail.com>
Co-authored-by: KlingerMatheus <klinger.matheus@gitstart.dev>
This commit is contained in:
gitstart-app[bot]
2024-02-25 13:52:48 +01:00
committed by GitHub
parent a108d36040
commit f543191552
184 changed files with 1121 additions and 828 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
packages/twenty-front/src/modules/ui/navigation/link/components/GithubVersionLink.tsx
View File

@ -4,13 +4,13 @@ import { IconBrandGithub } from '@/ui/display/icon';
import { ActionLink } from '@/ui/navigation/link/components/ActionLink.tsx';
import packageJson from '../../../../../../package.json';
import { githubLink } from '../constants';
import { GITHUB_LINK } from '../constants/GithubLink';
export const GithubVersionLink = () => {
const theme = useTheme();
return (
<ActionLink href={githubLink} target="_blank" rel="noreferrer">
<ActionLink href={GITHUB_LINK} target="_blank" rel="noreferrer">
<IconBrandGithub size={theme.icon.size.md} />
{packageJson.version}
</ActionLink>

1
packages/twenty-front/src/modules/ui/navigation/link/constants/GithubLink.ts Normal file
View File

@ -0,0 +1 @@
export const GITHUB_LINK = 'https://github.com/twentyhq/twenty';

1
packages/twenty-front/src/modules/ui/navigation/link/constants/index.ts
View File

@ -1 +0,0 @@
export const githubLink = 'https://github.com/twentyhq/twenty';

2
packages/twenty-front/src/modules/ui/navigation/menu-item/components/MenuItemSelectColor.tsx
View File

@ -5,7 +5,7 @@ import {
ColorSampleVariant,
} from '@/ui/display/color/components/ColorSample';
import { IconCheck } from '@/ui/display/icon';
import { ThemeColor } from '@/ui/theme/constants/colors';
import { ThemeColor } from '@/ui/theme/constants/MainColorNames';
import {
StyledMenuItemLabel,

7
packages/twenty-front/src/modules/ui/navigation/menu-item/components/__stories__/MenuItemSelectColor.stories.tsx
View File

@ -1,7 +1,10 @@
import { Meta, StoryObj } from '@storybook/react';
import { ColorSampleVariant } from '@/ui/display/color/components/ColorSample';
import { mainColorNames, ThemeColor } from '@/ui/theme/constants/colors';
import {
MAIN_COLOR_NAMES,
ThemeColor,
} from '@/ui/theme/constants/MainColorNames';
import {
CatalogDecorator,
CatalogDimension,
@ -35,7 +38,7 @@ export const Catalog: CatalogStory<Story, typeof MenuItemSelectColor> = {
dimensions: [
{
name: 'color',
values: mainColorNames,
values: MAIN_COLOR_NAMES,
props: (color: ThemeColor) => ({ color }),
labels: (color: ThemeColor) => color,
},

4
packages/twenty-front/src/modules/ui/navigation/menu-item/internals/components/StyledMenuItemBase.tsx
View File

@ -1,7 +1,7 @@
import { css } from '@emotion/react';
import styled from '@emotion/styled';
import { hoverBackground } from '@/ui/theme/constants/effects';
import { HOVER_BACKGROUND } from '@/ui/theme/constants/HoverBackground';
import { MenuItemAccent } from '../../types/MenuItemAccent';
@ -36,7 +36,7 @@ export const StyledMenuItemBase = styled.li<MenuItemBaseProps>`
padding: var(--vertical-padding) var(--horizontal-padding);
${hoverBackground};
${HOVER_BACKGROUND};
${({ theme, accent }) => {
switch (accent) {

8
packages/twenty-front/src/modules/ui/navigation/navigation-drawer/components/NavigationDrawer.tsx
View File

@ -5,10 +5,10 @@ import { motion } from 'framer-motion';
import { useRecoilValue } from 'recoil';
import { isNavigationDrawerOpenState } from '@/ui/navigation/states/isNavigationDrawerOpenState';
import { MOBILE_VIEWPORT } from '@/ui/theme/constants/theme';
import { MOBILE_VIEWPORT } from '@/ui/theme/constants/MobileViewport';
import { useIsMobile } from '@/ui/utilities/responsive/hooks/useIsMobile';
import { desktopNavDrawerWidths } from '../constants';
import { DESKTOP_NAV_DRAWER_WIDTHS } from '../constants/DesktopNavDrawerWidths';
import { NavigationDrawerBackButton } from './NavigationDrawerBackButton';
import { NavigationDrawerHeader } from './NavigationDrawerHeader';
@ -33,7 +33,7 @@ const StyledContainer = styled.div<{ isSubMenu?: boolean }>`
flex-direction: column;
gap: ${({ theme }) => theme.spacing(3)};
height: 100%;
min-width: ${desktopNavDrawerWidths.menu}px;
min-width: ${DESKTOP_NAV_DRAWER_WIDTHS.menu}px;
padding: ${({ theme }) => theme.spacing(3, 2, 4)};
${({ isSubMenu, theme }) =>
@ -80,7 +80,7 @@ export const NavigationDrawer = ({
const desktopWidth = !isNavigationDrawerOpen
? 12
: desktopNavDrawerWidths.menu;
: DESKTOP_NAV_DRAWER_WIDTHS.menu;
const mobileWidth = isNavigationDrawerOpen ? '100%' : 0;

2
packages/twenty-front/src/modules/ui/navigation/navigation-drawer/components/NavigationDrawerItem.tsx
View File

@ -5,7 +5,7 @@ import { useSetRecoilState } from 'recoil';
import { IconComponent } from '@/ui/display/icon/types/IconComponent';
import { isNavigationDrawerOpenState } from '@/ui/navigation/states/isNavigationDrawerOpenState';
import { MOBILE_VIEWPORT } from '@/ui/theme/constants/theme';
import { MOBILE_VIEWPORT } from '@/ui/theme/constants/MobileViewport';
import { useIsMobile } from '@/ui/utilities/responsive/hooks/useIsMobile';
export type NavigationDrawerItemProps = {

3
packages/twenty-front/src/modules/ui/navigation/navigation-drawer/constants/DesktopNavDrawerWidths.ts Normal file
View File

@ -0,0 +1,3 @@
export const DESKTOP_NAV_DRAWER_WIDTHS = {
menu: 236,
};

3
packages/twenty-front/src/modules/ui/navigation/navigation-drawer/constants/index.ts
View File

@ -1,3 +0,0 @@
export const desktopNavDrawerWidths = {
menu: 236,
};

2
packages/twenty-front/src/modules/ui/navigation/states/isNavigationDrawerOpenState.ts
View File

@ -1,6 +1,6 @@
import { atom } from 'recoil';
import { MOBILE_VIEWPORT } from '@/ui/theme/constants/theme';
import { MOBILE_VIEWPORT } from '@/ui/theme/constants/MobileViewport';
const isMobile = window.innerWidth <= MOBILE_VIEWPORT;

2
packages/twenty-front/src/modules/ui/navigation/step-bar/components/Step.tsx
View File

@ -3,7 +3,7 @@ import styled from '@emotion/styled';
import { motion } from 'framer-motion';
import { AnimatedCheckmark } from '@/ui/display/checkmark/components/AnimatedCheckmark';
import { MOBILE_VIEWPORT } from '@/ui/theme/constants/theme';
import { MOBILE_VIEWPORT } from '@/ui/theme/constants/MobileViewport';
import { useIsMobile } from '@/ui/utilities/responsive/hooks/useIsMobile';
const StyledContainer = styled.div<{ isLast: boolean }>`

2
packages/twenty-front/src/modules/ui/navigation/step-bar/components/StepBar.tsx
View File

@ -1,7 +1,7 @@
import React from 'react';
import styled from '@emotion/styled';
import { MOBILE_VIEWPORT } from '@/ui/theme/constants/theme';
import { MOBILE_VIEWPORT } from '@/ui/theme/constants/MobileViewport';
import { useIsMobile } from '@/ui/utilities/responsive/hooks/useIsMobile';
import { Step, StepProps } from './Step';