Update blocknote (#3517)

* update blocknote, remove feature flag

* Fix backend

---------

Co-authored-by: Charles Bochet <charles@twenty.com>
This commit is contained in:
brendanlaschke
2024-01-18 09:40:00 +01:00
committed by GitHub
parent c8de37860f
commit f6f4e6c769
7 changed files with 124 additions and 268 deletions

View File

@ -9,8 +9,8 @@ import { IconFile } from '@/ui/display/icon';
import { blockSchema } from './schema';
export const getSlashMenu = (imagesActivated: boolean) => {
let items = [
export const getSlashMenu = () => {
const items = [
...getDefaultReactSlashMenuItems(blockSchema),
{
name: 'File',
@ -40,10 +40,5 @@ export const getSlashMenu = (imagesActivated: boolean) => {
},
},
];
if (!imagesActivated) {
items = items.filter((x) => x.name !== 'Image');
}
return items;
};

View File

@ -9,7 +9,6 @@ import { Activity } from '@/activities/types/Activity';
import { CoreObjectNameSingular } from '@/object-metadata/types/CoreObjectNameSingular';
import { useUpdateOneRecord } from '@/object-record/hooks/useUpdateOneRecord';
import { BlockEditor } from '@/ui/input/editor/components/BlockEditor';
import { useIsFeatureEnabled } from '@/workspace/hooks/useIsFeatureEnabled';
import { REACT_APP_SERVER_BASE_URL } from '~/config';
import { FileFolder, useUploadFileMutation } from '~/generated/graphql';
@ -17,6 +16,8 @@ import { blockSpecs } from '../blocks/blockSpecs';
import { getSlashMenu } from '../blocks/slashMenu';
import { getFileType } from '../files/utils/getFileType';
import '@blocknote/react/style.css';
const StyledBlockNoteStyledContainer = styled.div`
width: 100%;
`;
@ -55,8 +56,7 @@ export const ActivityBodyEditor = ({
return debounce(onInternalChange, 200);
}, [updateOneRecord, activity.id]);
const imagesActivated = useIsFeatureEnabled('IS_NOTE_CREATE_IMAGES_ENABLED');
const slashMenuItems = getSlashMenu(imagesActivated);
const slashMenuItems = getSlashMenu();
const [uploadFile] = useUploadFileMutation();

View File

@ -1,6 +1,5 @@
export type FeatureFlagKey =
| 'IS_MESSAGING_ENABLED'
| 'IS_NOTE_CREATE_IMAGES_ENABLED'
| 'IS_QUICK_ACTIONS_ENABLED'
| 'IS_RATING_FIELD_TYPE_ENABLED'
| 'IS_RELATION_FIELD_CARD_ENABLED'

View File

@ -16,7 +16,6 @@ import { Workspace } from 'src/core/workspace/workspace.entity';
export enum FeatureFlagKeys {
IsRelationFieldTypeEnabled = 'IS_RELATION_FIELD_TYPE_ENABLED',
IsMessagingEnabled = 'IS_MESSAGING_ENABLED',
IsNoteCreateImagesEnabled = 'IS_NOTE_CREATE_IMAGES_ENABLED',
IsSelectFieldTypeEnabled = 'IS_SELECT_FIELD_TYPE_ENABLED',
IsRatingFieldTypeEnabled = 'IS_RATING_FIELD_TYPE_ENABLED',
IsWorkspaceCleanable = 'IS_WORKSPACE_CLEANABLE',

View File

@ -25,11 +25,6 @@ export const seedFeatureFlags = async (
workspaceId: workspaceId,
value: true,
},
{
key: FeatureFlagKeys.IsNoteCreateImagesEnabled,
workspaceId: workspaceId,
value: true,
},
{
key: FeatureFlagKeys.IsSelectFieldTypeEnabled,
workspaceId: workspaceId,