admin/twenty
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

fix: Fixed API typo and webhook checkerror (#6779)

Browse Source 
## Issue
1.There was an Api typo with API under Developers section #6778
2. Webhook lacked an check method for the `TextInput` #6774

## After- 

<img width="649" alt="Screenshot 2024-08-29 at 2 13 21 AM"
src="https://github.com/user-attachments/assets/bc9595f8-533f-430e-bc18-56373983eec8">



https://github.com/user-attachments/assets/8e2b06bc-308a-48ad-8ecb-9d0a130877bc

---------

Co-authored-by: Charles Bochet <charles@twenty.com>
This commit is contained in:
Harshit Singh
2024-08-31 22:47:14 +05:30
committed by GitHub
parent 96d659cf56
commit f8890689ee
4 changed files with 54 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
packages/twenty-front/src/pages/settings/developers/webhooks/SettingsDevelopersWebhooksNew.tsx
View File

@ -11,6 +11,7 @@ import { TextInput } from '@/ui/input/components/TextInput';
import { SubMenuTopBarContainer } from '@/ui/layout/page/SubMenuTopBarContainer';
import { Section } from '@/ui/layout/section/components/Section';
import { Breadcrumb } from '@/ui/navigation/bread-crumb/components/Breadcrumb';
import { isValidUrl } from '~/utils/url/isValidUrl';
export const SettingsDevelopersWebhooksNew = () => {
const navigate = useNavigate();
@ -21,9 +22,18 @@ export const SettingsDevelopersWebhooksNew = () => {
targetUrl: '',
operation: '*.*',
});
const [isTargetUrlValid, setIsTargetUrlValid] = useState(true);
const { createOneRecord: createOneWebhook } = useCreateOneRecord<Webhook>({
objectNameSingular: CoreObjectNameSingular.Webhook,
});
const handleValidate = async (value: string) => {
const trimmedUrl = value.trim();
setIsTargetUrlValid(isValidUrl(trimmedUrl));
};
const handleSave = async () => {
const newWebhook = await createOneWebhook?.(formValues);
@ -32,7 +42,10 @@ export const SettingsDevelopersWebhooksNew = () => {
}
navigate(`/settings/developers/webhooks/${newWebhook.id}`);
};
const canSave = !!formValues.targetUrl && createOneWebhook;
const canSave =
!!formValues.targetUrl && isTargetUrlValid && createOneWebhook;
return (
<SubMenuTopBarContainer
Icon={IconCode}
@ -63,6 +76,7 @@ export const SettingsDevelopersWebhooksNew = () => {
<TextInput
placeholder="URL"
value={formValues.targetUrl}
error={!isTargetUrlValid ? 'Please enter a valid URL' : undefined}
onKeyDown={(e) => {
if (e.key === 'Enter') {
handleSave();
@ -73,6 +87,7 @@ export const SettingsDevelopersWebhooksNew = () => {
...prevState,
targetUrl: value,
}));
handleValidate(value);
}}
fullWidth
/>