From f990b68f0ef2aa06a03f5933188363284093c87d Mon Sep 17 00:00:00 2001 From: Vasco Paisana Date: Mon, 4 Mar 2024 12:38:20 +0000 Subject: [PATCH] Fix Internal Server Error when removing profile picture (#4257) (#4278) * Fix Internal Server Error when removing profile picture (#4257) This commit addresses the issue where attempting to remove a profile picture resulted in an Internal Server Error. The fix involves: * Adding isNullable property to workspace-member avatar; * Implementing exception handling to handle errors during avatar removal. * Update packages/twenty-server/src/workspace/workspace-sync-metadata/standard-objects/workspace-member.object-metadata.ts --------- Co-authored-by: Charles Bochet --- .../components/ProfilePictureUploader.tsx | 26 +++++++++++-------- 1 file changed, 15 insertions(+), 11 deletions(-) diff --git a/packages/twenty-front/src/modules/settings/profile/components/ProfilePictureUploader.tsx b/packages/twenty-front/src/modules/settings/profile/components/ProfilePictureUploader.tsx index 2ce5ecfc4..59856007d 100644 --- a/packages/twenty-front/src/modules/settings/profile/components/ProfilePictureUploader.tsx +++ b/packages/twenty-front/src/modules/settings/profile/components/ProfilePictureUploader.tsx @@ -79,18 +79,22 @@ export const ProfilePictureUploader = () => { }; const handleRemove = async () => { - if (!currentWorkspaceMember?.id) { - throw new Error('User is not logged in'); + try { + if (!currentWorkspaceMember?.id) { + throw new Error('User is not logged in'); + } + + await updateOneRecord({ + idToUpdate: currentWorkspaceMember?.id, + updateOneRecordInput: { + avatarUrl: null, + }, + }); + + setCurrentWorkspaceMember({ ...currentWorkspaceMember, avatarUrl: null }); + } catch (error) { + setErrorMessage('An error occured while removing the picture.'); } - - await updateOneRecord({ - idToUpdate: currentWorkspaceMember?.id, - updateOneRecordInput: { - avatarUrl: null, - }, - }); - - setCurrentWorkspaceMember({ ...currentWorkspaceMember, avatarUrl: null }); }; return (