chore: extend root eslint config in twenty-server (#5101)

Reopening @thaisguigon work from
https://github.com/twentyhq/twenty/pull/4781

---------

Co-authored-by: Thaïs Guigon <guigon.thais@gmail.com>

packages/twenty-server/src/engine/core-modules/analytics/analytics.service.ts

@@ -1,4 +1,4 @@
-import { Injectable } from '@nestjs/common';
+import { Injectable, Logger } from '@nestjs/common';
 import { HttpService } from '@nestjs/axios';
 
 import { Request } from 'express';
@@ -12,6 +12,8 @@ import { CreateAnalyticsInput } from './dto/create-analytics.input';
 
 @Injectable()
 export class AnalyticsService {
+  private readonly logger = new Logger(AnalyticsService.name);
+
   constructor(
     private readonly environmentService: EnvironmentService,
     private readonly httpService: HttpService,
@@ -53,7 +55,11 @@ export class AnalyticsService {
 
     try {
       await this.httpService.axiosRef.post('/v1', data);
-    } catch {}
+    } catch {
+      this.logger.error('Failed to send analytics event');
+
+      return { success: false };
+    }
 
     return { success: true };
   }

packages/twenty-server/src/engine/core-modules/auth/guards/google-apis-oauth.guard.ts

@@ -10,18 +10,14 @@ export class GoogleAPIsOauthGuard extends AuthGuard('google-apis') {
   }
 
   async canActivate(context: ExecutionContext) {
-    try {
-      const request = context.switchToHttp().getRequest();
-      const transientToken = request.query.transientToken;
+    const request = context.switchToHttp().getRequest();
+    const transientToken = request.query.transientToken;
 
-      if (transientToken && typeof transientToken === 'string') {
-        request.params.transientToken = transientToken;
-      }
-      const activate = (await super.canActivate(context)) as boolean;
-
-      return activate;
-    } catch (ex) {
-      throw ex;
+    if (transientToken && typeof transientToken === 'string') {
+      request.params.transientToken = transientToken;
     }
+    const activate = (await super.canActivate(context)) as boolean;
+
+    return activate;
   }
 }

packages/twenty-server/src/engine/core-modules/auth/guards/google-oauth.guard.ts

@@ -10,18 +10,14 @@ export class GoogleOauthGuard extends AuthGuard('google') {
   }
 
   async canActivate(context: ExecutionContext) {
-    try {
-      const request = context.switchToHttp().getRequest();
-      const workspaceInviteHash = request.query.inviteHash;
+    const request = context.switchToHttp().getRequest();
+    const workspaceInviteHash = request.query.inviteHash;
 
-      if (workspaceInviteHash && typeof workspaceInviteHash === 'string') {
-        request.params.workspaceInviteHash = workspaceInviteHash;
-      }
-      const activate = (await super.canActivate(context)) as boolean;
-
-      return activate;
-    } catch (ex) {
-      throw ex;
+    if (workspaceInviteHash && typeof workspaceInviteHash === 'string') {
+      request.params.workspaceInviteHash = workspaceInviteHash;
     }
+    const activate = (await super.canActivate(context)) as boolean;
+
+    return activate;
   }
 }

packages/twenty-server/src/engine/core-modules/billing/billing.service.ts

@@ -202,7 +202,11 @@ export class BillingService {
       quantity = await this.userWorkspaceService.getWorkspaceMemberCount(
         user.defaultWorkspaceId,
       );
-    } catch (e) {}
+    } catch (e) {
+      this.logger.error(
+        `Failed to get workspace member count for workspace ${user.defaultWorkspaceId}`,
+      );
+    }
 
     const session = await this.stripeService.createCheckoutSession(
       user,

packages/twenty-server/src/engine/core-modules/calendar/timeline-calendar-event.service.ts

@@ -32,7 +32,7 @@ export class TimelineCalendarEventService {
     workspaceMemberId: string,
     workspaceId: string,
     personIds: string[],
-    page: number = 1,
+    page = 1,
     pageSize: number = TIMELINE_CALENDAR_EVENTS_DEFAULT_PAGE_SIZE,
   ): Promise<TimelineCalendarEventsWithTotal> {
     const offset = (page - 1) * pageSize;
@@ -234,7 +234,7 @@ export class TimelineCalendarEventService {
     workspaceMemberId: string,
     workspaceId: string,
     companyId: string,
-    page: number = 1,
+    page = 1,
     pageSize: number = TIMELINE_CALENDAR_EVENTS_DEFAULT_PAGE_SIZE,
   ): Promise<TimelineCalendarEventsWithTotal> {
     const dataSourceSchema =

packages/twenty-server/src/engine/core-modules/messaging/timeline-messaging.service.ts

@@ -24,7 +24,7 @@ export class TimelineMessagingService {
     workspaceMemberId: string,
     workspaceId: string,
     personIds: string[],
-    page: number = 1,
+    page = 1,
     pageSize: number = TIMELINE_THREADS_DEFAULT_PAGE_SIZE,
   ): Promise<TimelineThreadsWithTotal> {
     const offset = (page - 1) * pageSize;
@@ -478,7 +478,7 @@ export class TimelineMessagingService {
     workspaceMemberId: string,
     workspaceId: string,
     companyId: string,
-    page: number = 1,
+    page = 1,
     pageSize: number = TIMELINE_THREADS_DEFAULT_PAGE_SIZE,
   ): Promise<TimelineThreadsWithTotal> {
     const dataSourceSchema =