From fb737e20212f0570bcb839714b4f1174e6ce1828 Mon Sep 17 00:00:00 2001 From: gitstart-twenty <140154534+gitstart-twenty@users.noreply.github.com> Date: Sun, 10 Sep 2023 19:39:17 +0100 Subject: [PATCH] Refactor icons passed as props with the new way (#1492) * Refactor icons passed as props with the new way Co-authored-by: v1b3m Co-authored-by: Matheus * Update more files Co-authored-by: v1b3m Co-authored-by: Matheus * Fix according to review * Fix according to review * Fix according to review * Fix chromatic regressions --------- Co-authored-by: v1b3m Co-authored-by: Matheus Co-authored-by: Charles Bochet --- front/src/AppNavbar.tsx | 16 +++---- .../components/ActivityCreateButton.tsx | 17 ++----- .../activities/notes/components/Notes.tsx | 6 +-- .../components/ActivityActionBar.tsx | 2 +- .../tasks/components/AddTaskButton.tsx | 5 +- .../tasks/components/TaskGroups.tsx | 4 +- .../sign-in-up/components/SignInUpForm.tsx | 10 +++- .../command-menu/components/CommandMenu.tsx | 19 ++++---- .../components/CommandMenuItem.tsx | 47 ++++++------------- .../src/modules/command-menu/types/Command.ts | 4 +- .../components/AddPersonToCompany.tsx | 2 +- .../hooks/useCompanyTableActionBarEntries.tsx | 6 +-- .../favorites/components/Favorites.tsx | 14 ++---- .../modules/people/components/PeopleCard.tsx | 2 +- .../hooks/usePersonTableActionBarEntries.tsx | 6 +-- .../pipeline/components/PipelineAddButton.tsx | 2 +- .../settings/components/SettingsNavbar.tsx | 16 ++----- .../components/ContinueButton.tsx | 2 +- .../components/ModalCloseButton.tsx | 2 +- .../ValidationStep/ValidationStep.tsx | 2 +- .../action-bar/components/ActionBarEntry.tsx | 11 +++-- .../board/hooks/useBoardActionBarEntries.tsx | 2 +- .../modules/ui/button/components/Button.tsx | 21 +++------ .../ui/button/components/FloatingButton.tsx | 22 +++------ .../button/components/FloatingIconButton.tsx | 22 +++------ .../components/FloatingIconButtonGroup.tsx | 5 +- .../ui/button/components/IconButton.tsx | 22 +++------ .../ui/button/components/IconButtonGroup.tsx | 14 +++--- .../ui/button/components/LightIconButton.tsx | 22 +++------ .../ui/button/components/MainButton.tsx | 15 ++++-- .../button/components/RoundedIconButton.tsx | 20 ++++++-- .../components/__stories__/Button.stories.tsx | 12 ++--- .../__stories__/ButtonGroup.stories.tsx | 12 ++--- .../__stories__/FloatingButton.stories.tsx | 6 +-- .../FloatingButtonGroup.stories.tsx | 12 ++--- .../FloatingIconButton.stories.tsx | 6 +-- .../__stories__/IconButton.stories.tsx | 10 ++-- .../__stories__/LightIconButton.stories.tsx | 6 +-- .../__stories__/MainButton.stories.tsx | 11 +---- .../__stories__/RoundedIconButton.stories.tsx | 4 +- .../components/EditableFieldEditButton.tsx | 2 +- .../components/AutosizeTextInput.tsx | 2 +- .../ui/input/image/components/ImageInput.tsx | 6 +-- .../ui/layout/components/PageAddButton.tsx | 2 +- .../layout/components/PageFavoriteButton.tsx | 2 +- .../ui/layout/components/PageHeader.tsx | 25 +++++----- .../components/SubMenuTopBarContainer.tsx | 14 ++++-- .../components/ShowPageAddButton.tsx | 2 +- .../components/ShowPageRightContainer.tsx | 11 ++--- .../menu-item/components/MenuItemCommand.tsx | 2 +- .../navbar/components/NavCollapseButton.tsx | 19 +++++--- .../modules/ui/navbar/components/NavItem.tsx | 20 ++++++-- .../ui/navbar/components/SupportChat.tsx | 4 +- .../src/modules/ui/navbar/constants/index.ts | 5 -- .../RightDrawerTopBarCloseButton.tsx | 2 +- .../RightDrawerTopBarExpandButton.tsx | 10 ++-- front/src/modules/ui/tab/components/Tab.tsx | 14 ++++-- .../src/modules/ui/tab/components/TabList.tsx | 9 ++-- .../components/__stories__/Tab.stories.tsx | 2 +- .../__stories__/Tablist.stories.tsx | 8 ++-- .../ui/table/components/EntityTableHeader.tsx | 2 +- .../editable-cell/components/EditableCell.tsx | 2 +- .../ui/view-bar/components/DropdownButton.tsx | 18 +++++-- .../components/FilterDropdownButton.tsx | 23 +++++---- .../MultipleFiltersDropdownButton.tsx | 23 +++++---- .../view-bar/components/SortOrFilterChip.tsx | 2 +- .../components/UpdateViewButtonGroup.tsx | 2 +- .../ui/view-bar/components/ViewBarDetails.tsx | 2 +- front/src/modules/users/components/Avatar.tsx | 4 +- .../components/WorkspaceInviteLink.tsx | 2 +- front/src/pages/companies/Companies.tsx | 8 +--- .../src/pages/companies/CompaniesMockMode.tsx | 8 +--- front/src/pages/companies/CompanyShow.tsx | 4 +- .../src/pages/opportunities/Opportunities.tsx | 8 +--- front/src/pages/people/People.tsx | 8 +--- front/src/pages/people/PersonShow.tsx | 9 +--- .../src/pages/settings/SettingsExperience.tsx | 2 +- front/src/pages/settings/SettingsProfile.tsx | 2 +- .../src/pages/settings/SettingsWorkspace.tsx | 2 +- .../settings/SettingsWorkspaceMembers.tsx | 14 +++--- front/src/pages/tasks/Tasks.tsx | 11 ++--- front/src/sync-hooks/PageChangeEffect.tsx | 10 ++-- 82 files changed, 341 insertions(+), 425 deletions(-) diff --git a/front/src/AppNavbar.tsx b/front/src/AppNavbar.tsx index 34436bc2f..0bdf5e2db 100644 --- a/front/src/AppNavbar.tsx +++ b/front/src/AppNavbar.tsx @@ -1,5 +1,4 @@ import { useLocation, useNavigate } from 'react-router-dom'; -import { useTheme } from '@emotion/react'; import { useCommandMenu } from '@/command-menu/hooks/useCommandMenu'; import { Favorites } from '@/favorites/components/Favorites'; @@ -21,7 +20,6 @@ import NavTitle from '@/ui/navbar/components/NavTitle'; import { measureTotalFrameLoad } from './utils/measureTotalFrameLoad'; export function AppNavbar() { - const theme = useTheme(); const currentPath = useLocation().pathname; const { openCommandMenu } = useCommandMenu(); @@ -35,7 +33,7 @@ export function AppNavbar() { } + Icon={IconSearch} onClick={() => { openCommandMenu(); }} @@ -43,26 +41,26 @@ export function AppNavbar() { } + Icon={IconBell} soon={true} /> } + Icon={IconSettings} /> } + Icon={IconCheckbox} /> } + Icon={IconBuildingSkyscraper} active={currentPath === '/companies'} /> } + Icon={IconUser} active={currentPath === '/people'} /> } + Icon={IconTargetArrow} active={currentPath === '/opportunities'} /> diff --git a/front/src/modules/activities/components/ActivityCreateButton.tsx b/front/src/modules/activities/components/ActivityCreateButton.tsx index d2293bf80..09b35d1a7 100644 --- a/front/src/modules/activities/components/ActivityCreateButton.tsx +++ b/front/src/modules/activities/components/ActivityCreateButton.tsx @@ -1,5 +1,3 @@ -import { useTheme } from '@emotion/react'; - import { Button } from '@/ui/button/components/Button'; import { ButtonGroup } from '@/ui/button/components/ButtonGroup'; import { IconCheckbox, IconNotes, IconTimelineEvent } from '@/ui/icon/index'; @@ -15,21 +13,12 @@ export function ActivityCreateButton({ onTaskClick, onActivityClick, }: ActivityCreateButtonProps) { - const theme = useTheme(); return ( +