Improved activity editor re-renders (#4149)

* Refactor task count

* Fixed show page rerender

* Less rerenders and way better title and body UX

* Finished breaking down activity editor subscriptions

* Removed console.log

* Last console.log

* Fixed bugs and cleaned

packages/twenty-front/src/modules/activities/hooks/useCreateActivityInCache.ts

@@ -1,4 +1,4 @@
-import { useRecoilValue } from 'recoil';
+import { useRecoilCallback, useRecoilValue } from 'recoil';
 import { v4 } from 'uuid';
 
 import { useAttachRelationInBothDirections } from '@/activities/hooks/useAttachRelationInBothDirections';
@@ -6,13 +6,15 @@ import { useInjectIntoActivityTargetInlineCellCache } from '@/activities/inline-
 import { Activity, ActivityType } from '@/activities/types/Activity';
 import { ActivityTarget } from '@/activities/types/ActivityTarget';
 import { ActivityTargetableObject } from '@/activities/types/ActivityTargetableEntity';
-import { getActivityTargetsToCreateFromTargetableObjects } from '@/activities/utils/getActivityTargetsToCreateFromTargetableObjects';
+import { makeActivityTargetsToCreateFromTargetableObjects } from '@/activities/utils/getActivityTargetsToCreateFromTargetableObjects';
 import { currentWorkspaceMemberState } from '@/auth/states/currentWorkspaceMemberState';
 import { CoreObjectNameSingular } from '@/object-metadata/types/CoreObjectNameSingular';
 import { useCreateManyRecordsInCache } from '@/object-record/hooks/useCreateManyRecordsInCache';
 import { useCreateOneRecordInCache } from '@/object-record/hooks/useCreateOneRecordInCache';
 import { useFindOneRecord } from '@/object-record/hooks/useFindOneRecord';
+import { recordStoreFamilyState } from '@/object-record/record-store/states/recordStoreFamilyState';
 import { WorkspaceMember } from '@/workspace-member/types/WorkspaceMember';
+import { isDefined } from '~/utils/isDefined';
 
 export const useCreateActivityInCache = () => {
   const { createManyRecordsInCache: createManyActivityTargetsInCache } =
@@ -39,58 +41,86 @@ export const useCreateActivityInCache = () => {
   const { attachRelationInBothDirections } =
     useAttachRelationInBothDirections();
 
-  const createActivityInCache = ({
-    type,
-    targetableObjects,
-    customAssignee,
-  }: {
-    type: ActivityType;
-    targetableObjects: ActivityTargetableObject[];
-    customAssignee?: WorkspaceMember;
-  }) => {
-    const activityId = v4();
-
-    const createdActivityInCache = createOneActivityInCache({
-      id: activityId,
-      author: currentWorkspaceMemberRecord,
-      authorId: currentWorkspaceMemberRecord?.id,
-      assignee: customAssignee ?? currentWorkspaceMemberRecord,
-      assigneeId: customAssignee?.id ?? currentWorkspaceMemberRecord?.id,
-      type,
-    });
-
-    const activityTargetsToCreate =
-      getActivityTargetsToCreateFromTargetableObjects({
-        activityId,
+  const createActivityInCache = useRecoilCallback(
+    ({ snapshot, set }) =>
+      ({
+        type,
         targetableObjects,
-      });
+        customAssignee,
+      }: {
+        type: ActivityType;
+        targetableObjects: ActivityTargetableObject[];
+        customAssignee?: WorkspaceMember;
+      }) => {
+        const activityId = v4();
 
-    const createdActivityTargetsInCache = createManyActivityTargetsInCache(
-      activityTargetsToCreate,
-    );
+        const createdActivityInCache = createOneActivityInCache({
+          id: activityId,
+          author: currentWorkspaceMemberRecord,
+          authorId: currentWorkspaceMemberRecord?.id,
+          assignee: customAssignee ?? currentWorkspaceMemberRecord,
+          assigneeId: customAssignee?.id ?? currentWorkspaceMemberRecord?.id,
+          type,
+        });
 
-    injectIntoActivityTargetInlineCellCache({
-      activityId,
-      activityTargetsToInject: createdActivityTargetsInCache,
-    });
+        const targetObjectRecords = targetableObjects
+          .map((targetableObject) => {
+            const targetObject = snapshot
+              .getLoadable(recordStoreFamilyState(targetableObject.id))
+              .getValue();
 
-    attachRelationInBothDirections({
-      sourceRecord: createdActivityInCache,
-      fieldNameOnSourceRecord: 'activityTargets',
-      sourceObjectNameSingular: CoreObjectNameSingular.Activity,
-      fieldNameOnTargetRecord: 'activity',
-      targetObjectNameSingular: CoreObjectNameSingular.ActivityTarget,
-      targetRecords: createdActivityTargetsInCache,
-    });
+            return targetObject;
+          })
+          .filter(isDefined);
 
-    return {
-      createdActivityInCache: {
-        ...createdActivityInCache,
-        activityTargets: createdActivityTargetsInCache,
+        const activityTargetsToCreate =
+          makeActivityTargetsToCreateFromTargetableObjects({
+            activityId,
+            targetableObjects,
+            targetObjectRecords,
+          });
+
+        const createdActivityTargetsInCache = createManyActivityTargetsInCache(
+          activityTargetsToCreate,
+        );
+
+        injectIntoActivityTargetInlineCellCache({
+          activityId,
+          activityTargetsToInject: createdActivityTargetsInCache,
+        });
+
+        attachRelationInBothDirections({
+          sourceRecord: createdActivityInCache,
+          fieldNameOnSourceRecord: 'activityTargets',
+          sourceObjectNameSingular: CoreObjectNameSingular.Activity,
+          fieldNameOnTargetRecord: 'activity',
+          targetObjectNameSingular: CoreObjectNameSingular.ActivityTarget,
+          targetRecords: createdActivityTargetsInCache,
+        });
+
+        // TODO: should refactor when refactoring make activity connection utils
+        set(recordStoreFamilyState(activityId), {
+          ...createdActivityInCache,
+          activityTargets: createdActivityTargetsInCache,
+          comments: [],
+        });
+
+        return {
+          createdActivityInCache: {
+            ...createdActivityInCache,
+            activityTargets: createdActivityTargetsInCache,
+          },
+          createdActivityTargetsInCache,
+        };
       },
-      createdActivityTargetsInCache,
-    };
-  };
+    [
+      attachRelationInBothDirections,
+      createManyActivityTargetsInCache,
+      createOneActivityInCache,
+      currentWorkspaceMemberRecord,
+      injectIntoActivityTargetInlineCellCache,
+    ],
+  );
 
   return {
     createActivityInCache,