admin/twenty
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Improved activity editor re-renders (#4149)

Browse Source 
* Refactor task count

* Fixed show page rerender

* Less rerenders and way better title and body UX

* Finished breaking down activity editor subscriptions

* Removed console.log

* Last console.log

* Fixed bugs and cleaned
This commit is contained in:
Lucas Bordeau
2024-02-23 17:54:27 +01:00
committed by GitHub
parent 5de1c2c31d
commit fb920a92e7
48 changed files with 1114 additions and 527 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
packages/twenty-front/src/modules/activities/right-drawer/components/RightDrawerActivity.tsx
View File

@ -1,7 +1,7 @@
import styled from '@emotion/styled';
import { ActivityEditor } from '@/activities/components/ActivityEditor';
import { useActivityById } from '@/activities/hooks/useActivityById';
import { ActivityEditorEffect } from '@/activities/components/ActivityEditorEffect';
const StyledContainer = styled.div`
box-sizing: border-box;
@ -24,18 +24,11 @@ export const RightDrawerActivity = ({
showComment = true,
fillTitleFromBody = false,
}: RightDrawerActivityProps) => {
const { activity, loading } = useActivityById({
activityId,
});
if (!activity || loading) {
return <></>;
}
return (
<StyledContainer>
<ActivityEditorEffect activityId={activityId} />
<ActivityEditor
activity={activity}
activityId={activityId}
showComment={showComment}
fillTitleFromBody={fillTitleFromBody}
/>