Fixes for production (#13164)
Some checks failed
CI Demo check / test (push) Has been cancelled
CD deploy main / deploy-main (push) Has been cancelled
CI Chrome Extension / changed-files-check (push) Has been cancelled
CI E2E Playwright Tests / changed-files-check (push) Has been cancelled
CI Emails / changed-files-check (push) Has been cancelled
CI Front / changed-files-check (push) Has been cancelled
CI Server / changed-files-check (push) Has been cancelled
CI Shared / changed-files-check (push) Has been cancelled
CI Website / changed-files-check (push) Has been cancelled
Push translations to Crowdin / Extract and upload translations (push) Has been cancelled
CI Chrome Extension / chrome-extension-build (push) Has been cancelled
CI Chrome Extension / ci-chrome-extension-status-check (push) Has been cancelled
CI E2E Playwright Tests / test (push) Has been cancelled
CI E2E Playwright Tests / ci-e2e-status-check (push) Has been cancelled
CI Emails / emails-test (push) Has been cancelled
CI Emails / ci-emails-status-check (push) Has been cancelled
CI Front / front-sb-build (push) Has been cancelled
CI Front / front-sb-test (1, modules) (push) Has been cancelled
CI Front / front-sb-test (1, pages) (push) Has been cancelled
CI Front / front-sb-test (1, performance) (push) Has been cancelled
CI Front / front-sb-test (2, modules) (push) Has been cancelled
CI Front / front-sb-test (2, pages) (push) Has been cancelled
CI Front / front-sb-test (2, performance) (push) Has been cancelled
CI Front / front-sb-test (3, modules) (push) Has been cancelled
CI Front / front-sb-test (3, pages) (push) Has been cancelled
CI Front / front-sb-test (3, performance) (push) Has been cancelled
CI Front / front-sb-test (4, modules) (push) Has been cancelled
CI Front / front-sb-test (4, pages) (push) Has been cancelled
CI Front / front-sb-test (4, performance) (push) Has been cancelled
CI Front / merge-reports-and-check-coverage (modules) (push) Has been cancelled
CI Front / merge-reports-and-check-coverage (pages) (push) Has been cancelled
CI Front / merge-reports-and-check-coverage (performance) (push) Has been cancelled
CI Front / front-chromatic-deployment (push) Has been cancelled
CI Front / front-task (lint) (push) Has been cancelled
CI Front / front-task (test) (push) Has been cancelled
CI Front / front-task (typecheck) (push) Has been cancelled
CI Front / ci-front-status-check (push) Has been cancelled
CI Server / server-setup (push) Has been cancelled
CI Server / server-test (push) Has been cancelled
CI Server / server-integration-test (1) (push) Has been cancelled
CI Server / server-integration-test (2) (push) Has been cancelled
CI Server / server-integration-test (3) (push) Has been cancelled
CI Server / server-integration-test (4) (push) Has been cancelled
CI Server / ci-server-status-check (push) Has been cancelled
CI Shared / shared-test (lint) (push) Has been cancelled
CI Shared / shared-test (test) (push) Has been cancelled
CI Shared / shared-test (typecheck) (push) Has been cancelled
CI Shared / ci-shared-status-check (push) Has been cancelled
CI Website / website-build (push) Has been cancelled
CI Website / ci-website-status-check (push) Has been cancelled
Some checks failed
CI Demo check / test (push) Has been cancelled
CD deploy main / deploy-main (push) Has been cancelled
CI Chrome Extension / changed-files-check (push) Has been cancelled
CI E2E Playwright Tests / changed-files-check (push) Has been cancelled
CI Emails / changed-files-check (push) Has been cancelled
CI Front / changed-files-check (push) Has been cancelled
CI Server / changed-files-check (push) Has been cancelled
CI Shared / changed-files-check (push) Has been cancelled
CI Website / changed-files-check (push) Has been cancelled
Push translations to Crowdin / Extract and upload translations (push) Has been cancelled
CI Chrome Extension / chrome-extension-build (push) Has been cancelled
CI Chrome Extension / ci-chrome-extension-status-check (push) Has been cancelled
CI E2E Playwright Tests / test (push) Has been cancelled
CI E2E Playwright Tests / ci-e2e-status-check (push) Has been cancelled
CI Emails / emails-test (push) Has been cancelled
CI Emails / ci-emails-status-check (push) Has been cancelled
CI Front / front-sb-build (push) Has been cancelled
CI Front / front-sb-test (1, modules) (push) Has been cancelled
CI Front / front-sb-test (1, pages) (push) Has been cancelled
CI Front / front-sb-test (1, performance) (push) Has been cancelled
CI Front / front-sb-test (2, modules) (push) Has been cancelled
CI Front / front-sb-test (2, pages) (push) Has been cancelled
CI Front / front-sb-test (2, performance) (push) Has been cancelled
CI Front / front-sb-test (3, modules) (push) Has been cancelled
CI Front / front-sb-test (3, pages) (push) Has been cancelled
CI Front / front-sb-test (3, performance) (push) Has been cancelled
CI Front / front-sb-test (4, modules) (push) Has been cancelled
CI Front / front-sb-test (4, pages) (push) Has been cancelled
CI Front / front-sb-test (4, performance) (push) Has been cancelled
CI Front / merge-reports-and-check-coverage (modules) (push) Has been cancelled
CI Front / merge-reports-and-check-coverage (pages) (push) Has been cancelled
CI Front / merge-reports-and-check-coverage (performance) (push) Has been cancelled
CI Front / front-chromatic-deployment (push) Has been cancelled
CI Front / front-task (lint) (push) Has been cancelled
CI Front / front-task (test) (push) Has been cancelled
CI Front / front-task (typecheck) (push) Has been cancelled
CI Front / ci-front-status-check (push) Has been cancelled
CI Server / server-setup (push) Has been cancelled
CI Server / server-test (push) Has been cancelled
CI Server / server-integration-test (1) (push) Has been cancelled
CI Server / server-integration-test (2) (push) Has been cancelled
CI Server / server-integration-test (3) (push) Has been cancelled
CI Server / server-integration-test (4) (push) Has been cancelled
CI Server / ci-server-status-check (push) Has been cancelled
CI Shared / shared-test (lint) (push) Has been cancelled
CI Shared / shared-test (test) (push) Has been cancelled
CI Shared / shared-test (typecheck) (push) Has been cancelled
CI Shared / ci-shared-status-check (push) Has been cancelled
CI Website / website-build (push) Has been cancelled
CI Website / ci-website-status-check (push) Has been cancelled
This PR fixes two bugs : - Some important push item to focus stack calls were setting global hotkey conflicting keys to true (like open dropdown) - Icon picker matrix items were broken
This commit is contained in:
@ -79,6 +79,10 @@ export const useRecordTitleCell = () => {
|
|||||||
prefix: containerType,
|
prefix: containerType,
|
||||||
}),
|
}),
|
||||||
},
|
},
|
||||||
|
globalHotkeysConfig: {
|
||||||
|
enableGlobalHotkeysConflictingWithKeyboard: false,
|
||||||
|
enableGlobalHotkeysWithModifiers: false,
|
||||||
|
},
|
||||||
});
|
});
|
||||||
|
|
||||||
const recordTitleCellId = getRecordFieldInputInstanceId({
|
const recordTitleCellId = getRecordFieldInputInstanceId({
|
||||||
|
|||||||
@ -60,6 +60,15 @@ const StyledLightIconButton = styled(LightIconButton)<{
|
|||||||
: 'transparent'};
|
: 'transparent'};
|
||||||
`;
|
`;
|
||||||
|
|
||||||
|
const StyledMatrixItem = styled.div`
|
||||||
|
width: 32px;
|
||||||
|
height: 32px;
|
||||||
|
display: flex;
|
||||||
|
align-items: center;
|
||||||
|
justify-content: center;
|
||||||
|
box-sizing: border-box;
|
||||||
|
`;
|
||||||
|
|
||||||
const convertIconKeyToLabel = (iconKey: string) =>
|
const convertIconKeyToLabel = (iconKey: string) =>
|
||||||
iconKey.replace(/[A-Z]/g, (letter) => ` ${letter}`).trim();
|
iconKey.replace(/[A-Z]/g, (letter) => ` ${letter}`).trim();
|
||||||
|
|
||||||
@ -84,18 +93,20 @@ const IconPickerIcon = ({
|
|||||||
);
|
);
|
||||||
|
|
||||||
return (
|
return (
|
||||||
<SelectableListItem itemId={iconKey} onEnter={onClick}>
|
<StyledMatrixItem>
|
||||||
<StyledLightIconButton
|
<SelectableListItem itemId={iconKey} onEnter={onClick}>
|
||||||
key={iconKey}
|
<StyledLightIconButton
|
||||||
aria-label={convertIconKeyToLabel(iconKey)}
|
key={iconKey}
|
||||||
size="medium"
|
aria-label={convertIconKeyToLabel(iconKey)}
|
||||||
title={iconKey}
|
size="medium"
|
||||||
isSelected={iconKey === selectedIconKey || !!isSelectedItemId}
|
title={iconKey}
|
||||||
isFocused={iconKey === focusedIconKey}
|
isSelected={iconKey === selectedIconKey || !!isSelectedItemId}
|
||||||
Icon={Icon}
|
isFocused={iconKey === focusedIconKey}
|
||||||
onClick={onClick}
|
Icon={Icon}
|
||||||
/>
|
onClick={onClick}
|
||||||
</SelectableListItem>
|
/>
|
||||||
|
</SelectableListItem>
|
||||||
|
</StyledMatrixItem>
|
||||||
);
|
);
|
||||||
};
|
};
|
||||||
|
|
||||||
|
|||||||
@ -50,7 +50,14 @@ export const useOpenDropdown = () => {
|
|||||||
type: FocusComponentType.DROPDOWN,
|
type: FocusComponentType.DROPDOWN,
|
||||||
instanceId: dropdownComponentInstanceId,
|
instanceId: dropdownComponentInstanceId,
|
||||||
},
|
},
|
||||||
globalHotkeysConfig: args?.globalHotkeysConfig ?? undefined,
|
globalHotkeysConfig: {
|
||||||
|
enableGlobalHotkeysConflictingWithKeyboard:
|
||||||
|
args?.globalHotkeysConfig
|
||||||
|
?.enableGlobalHotkeysConflictingWithKeyboard ?? false,
|
||||||
|
enableGlobalHotkeysWithModifiers:
|
||||||
|
args?.globalHotkeysConfig?.enableGlobalHotkeysWithModifiers ??
|
||||||
|
false,
|
||||||
|
},
|
||||||
});
|
});
|
||||||
},
|
},
|
||||||
[
|
[
|
||||||
|
|||||||
Reference in New Issue
Block a user