Replace all hardcoded core object name by enum (#3170)

* Replace hardcoded core object name by enum

Signed-off-by: Florian Grabmeier <flo.grabmeier@gmail.com>

* Fix typo

Signed-off-by: Florian Grabmeier <flo.grabmeier@gmail.com>

* Fixed duplicate import

---------

Signed-off-by: Florian Grabmeier <flo.grabmeier@gmail.com>
Co-authored-by: Lucas Bordeau <bordeau.lucas@gmail.com>

packages/twenty-front/src/modules/companies/components/AddPersonToCompany.tsx

@@ -16,6 +16,7 @@ import { LightIconButton } from '@/ui/input/button/components/LightIconButton';
 import { usePreviousHotkeyScope } from '@/ui/utilities/hotkey/hooks/usePreviousHotkeyScope';
 import { RecoilScope } from '@/ui/utilities/recoil-scope/components/RecoilScope';
 import { FieldMetadataType } from '~/generated-metadata/graphql';
+import { CoreObjectNameSingular } from '@/object-metadata/types/CoreObjectNameSingular';
 
 const StyledContainer = styled.div`
   position: static;
@@ -73,7 +74,7 @@ export const AddPersonToCompany = ({
     updateOneRecordMutation,
     createOneRecordMutation,
   } = useObjectMetadataItem({
-    objectNameSingular: 'person',
+    objectNameSingular: CoreObjectNameSingular.Person,
   });
 
   const [updatePerson] = useMutation(updateOneRecordMutation);

packages/twenty-front/src/modules/companies/components/CompanyBoardCard.tsx

@@ -24,6 +24,7 @@ import { getLogoUrlFromDomainName } from '~/utils';
 import { companyProgressesFamilyState } from '../states/companyProgressesFamilyState';
 
 import { CompanyChip } from './CompanyChip';
+import { CoreObjectNameSingular } from '@/object-metadata/types/CoreObjectNameSingular';
 
 const StyledBoardCard = styled.div<{ selected: boolean }>`
   background-color: ${({ theme, selected }) =>
@@ -151,7 +152,7 @@ export const CompanyBoardCard = () => {
 
   const useUpdateOneRecordMutation: RecordUpdateHook = () => {
     const { updateOneRecord: updateOneOpportunity } = useUpdateOneRecord({
-      objectNameSingular: 'opportunity',
+      objectNameSingular: CoreObjectNameSingular.Opportunity,
     });
 
     const updateEntity = ({ variables }: RecordUpdateHookParams) => {

packages/twenty-front/src/modules/companies/components/CompanyTeam.tsx

@@ -8,6 +8,7 @@ import { mapPaginatedRecordsToRecords } from '@/object-record/utils/mapPaginated
 import { PeopleCard } from '@/people/components/PeopleCard';
 
 import { AddPersonToCompany } from './AddPersonToCompany';
+import { CoreObjectNameSingular } from '@/object-metadata/types/CoreObjectNameSingular';
 
 export type CompanyTeamProps = {
   company: Pick<Company, 'id'>;
@@ -48,7 +49,7 @@ const StyledTitle = styled.div`
 
 export const CompanyTeam = ({ company }: { company: any }) => {
   const { findManyRecordsQuery } = useObjectMetadataItem({
-    objectNameSingular: 'person',
+    objectNameSingular: CoreObjectNameSingular.Person,
   });
 
   const { data } = useQuery(findManyRecordsQuery, {

packages/twenty-front/src/modules/companies/components/HooksCompanyBoardEffect.tsx

@@ -14,6 +14,7 @@ import { useViewScopedStates } from '@/views/hooks/internal/useViewScopedStates'
 import { useViewBar } from '@/views/hooks/useViewBar';
 import { ViewType } from '@/views/types/ViewType';
 import { mapViewFieldsToBoardFieldDefinitions } from '@/views/utils/mapViewFieldsToBoardFieldDefinitions';
+import { CoreObjectNameSingular } from '@/object-metadata/types/CoreObjectNameSingular';
 
 type HooksCompanyBoardEffectProps = {
   viewBarId: string;
@@ -33,7 +34,7 @@ export const HooksCompanyBoardEffect = ({
   } = useViewBar({ viewBarId });
 
   const { objectMetadataItem } = useObjectMetadataItem({
-    objectNameSingular: 'opportunity',
+    objectNameSingular: CoreObjectNameSingular.Opportunity,
   });
 
   const { columnDefinitions, filterDefinitions, sortDefinitions } =

packages/twenty-front/src/modules/companies/components/NewOpportunityButton.tsx

@@ -11,6 +11,7 @@ import { RelationPickerHotkeyScope } from '@/object-record/relation-picker/types
 import { useFilteredSearchEntityQuery } from '@/search/hooks/useFilteredSearchEntityQuery';
 import { useSnackBar } from '@/ui/feedback/snack-bar-manager/hooks/useSnackBar';
 import { usePreviousHotkeyScope } from '@/ui/utilities/hotkey/hooks/usePreviousHotkeyScope';
+import { CoreObjectNameSingular } from '@/object-metadata/types/CoreObjectNameSingular';
 
 export const NewOpportunityButton = () => {
   const [isCreatingCard, setIsCreatingCard] = useState(false);
@@ -57,7 +58,7 @@ export const NewOpportunityButton = () => {
 
   // TODO: refactor useFilteredSearchEntityQuery
   const { findManyRecordsQuery } = useObjectMetadataItem({
-    objectNameSingular: 'company',
+    objectNameSingular: CoreObjectNameSingular.Company,
   });
   const useFindManyQuery = (options: any) =>
     useQuery(findManyRecordsQuery, options);
@@ -74,7 +75,7 @@ export const NewOpportunityButton = () => {
     orderByField: 'createdAt',
     selectedIds: [],
     mappingFunction: (record: any) => identifiersMapper?.(record, 'company'),
-    objectNameSingular: 'company',
+    objectNameSingular: CoreObjectNameSingular.Company,
   });
 
   return (

packages/twenty-front/src/modules/companies/components/OpportunityPicker.tsx

@@ -17,6 +17,7 @@ import { DropdownMenuSearchInput } from '@/ui/layout/dropdown/components/Dropdow
 import { DropdownMenuSeparator } from '@/ui/layout/dropdown/components/DropdownMenuSeparator';
 import { MenuItem } from '@/ui/navigation/menu-item/components/MenuItem';
 import { RecoilScope } from '@/ui/utilities/recoil-scope/components/RecoilScope';
+import { CoreObjectNameSingular } from '@/object-metadata/types/CoreObjectNameSingular';
 
 export type OpportunityPickerProps = {
   companyId: string | null;
@@ -37,7 +38,7 @@ export const OpportunityPicker = ({
 
   // TODO: refactor useFilteredSearchEntityQuery
   const { findManyRecordsQuery: findManyCompanies } = useObjectMetadataItem({
-    objectNameSingular: 'company',
+    objectNameSingular: CoreObjectNameSingular.Company,
   });
   const useFindManyQuery = (options: any) =>
     useQuery(findManyCompanies, options);
@@ -54,7 +55,7 @@ export const OpportunityPicker = ({
     orderByField: 'createdAt',
     selectedIds: [],
     mappingFunction: (record: any) => identifiersMapper?.(record, 'company'),
-    objectNameSingular: 'company',
+    objectNameSingular: CoreObjectNameSingular.Company,
   });
 
   const [isProgressSelectionUnfolded, setIsProgressSelectionUnfolded] =