Replace all hardcoded core object name by enum (#3170)

* Replace hardcoded core object name by enum

Signed-off-by: Florian Grabmeier <flo.grabmeier@gmail.com>

* Fix typo

Signed-off-by: Florian Grabmeier <flo.grabmeier@gmail.com>

* Fixed duplicate import

---------

Signed-off-by: Florian Grabmeier <flo.grabmeier@gmail.com>
Co-authored-by: Lucas Bordeau <bordeau.lucas@gmail.com>

packages/twenty-front/src/modules/views/components/ViewBarEffect.tsx

@@ -8,6 +8,7 @@ import { GraphQLView } from '@/views/types/GraphQLView';
 import { isDeeplyEqual } from '~/utils/isDeeplyEqual';
 
 import { useViewScopedStates } from '../hooks/internal/useViewScopedStates';
+import { CoreObjectNameSingular } from '@/object-metadata/types/CoreObjectNameSingular';
 
 export const ViewBarEffect = () => {
   const {
@@ -35,7 +36,7 @@ export const ViewBarEffect = () => {
 
   const { records: newViews } = useFindManyRecords<GraphQLView>({
     skip: !viewObjectMetadataId,
-    objectNameSingular: 'view',
+    objectNameSingular: CoreObjectNameSingular.View,
     filter: {
       type: { eq: viewType },
       objectMetadataId: { eq: viewObjectMetadataId },

packages/twenty-front/src/modules/views/hooks/internal/useViewFields.ts

@@ -5,15 +5,16 @@ import { useObjectMetadataItem } from '@/object-metadata/hooks/useObjectMetadata
 import { ViewField } from '@/views/types/ViewField';
 import { getViewScopedStatesFromSnapshot } from '@/views/utils/getViewScopedStatesFromSnapshot';
 import { getViewScopedStateValuesFromSnapshot } from '@/views/utils/getViewScopedStateValuesFromSnapshot';
+import { CoreObjectNameSingular } from '@/object-metadata/types/CoreObjectNameSingular';
 
 export const useViewFields = (viewScopeId: string) => {
   const { updateOneRecordMutation, createOneRecordMutation } =
     useObjectMetadataItem({
-      objectNameSingular: 'viewField',
+      objectNameSingular: CoreObjectNameSingular.ViewField,
     });
 
   const { modifyRecordFromCache } = useObjectMetadataItem({
-    objectNameSingular: 'view',
+    objectNameSingular: CoreObjectNameSingular.View,
   });
 
   const apolloClient = useApolloClient();

packages/twenty-front/src/modules/views/hooks/internal/useViewFilters.ts

@@ -9,6 +9,7 @@ import { ViewFilter } from '@/views/types/ViewFilter';
 import { getViewScopedStateValuesFromSnapshot } from '@/views/utils/getViewScopedStateValuesFromSnapshot';
 
 import { useViewScopedStates } from './useViewScopedStates';
+import { CoreObjectNameSingular } from '@/object-metadata/types/CoreObjectNameSingular';
 
 export const useViewFilters = (viewScopeId: string) => {
   const {
@@ -16,11 +17,11 @@ export const useViewFilters = (viewScopeId: string) => {
     createOneRecordMutation,
     deleteOneRecordMutation,
   } = useObjectMetadataItem({
-    objectNameSingular: 'viewFilter',
+    objectNameSingular: CoreObjectNameSingular.ViewFilter,
   });
 
   const { modifyRecordFromCache } = useObjectMetadataItem({
-    objectNameSingular: 'view',
+    objectNameSingular: CoreObjectNameSingular.View,
   });
 
   const apolloClient = useApolloClient();

packages/twenty-front/src/modules/views/hooks/internal/useViewSorts.ts

@@ -9,6 +9,7 @@ import { ViewSort } from '@/views/types/ViewSort';
 import { getViewScopedStateValuesFromSnapshot } from '@/views/utils/getViewScopedStateValuesFromSnapshot';
 
 import { useViewScopedStates } from './useViewScopedStates';
+import { CoreObjectNameSingular } from '@/object-metadata/types/CoreObjectNameSingular';
 
 export const useViewSorts = (viewScopeId: string) => {
   const {
@@ -16,11 +17,11 @@ export const useViewSorts = (viewScopeId: string) => {
     createOneRecordMutation,
     deleteOneRecordMutation,
   } = useObjectMetadataItem({
-    objectNameSingular: 'viewSort',
+    objectNameSingular: CoreObjectNameSingular.ViewSort,
   });
 
   const { modifyRecordFromCache } = useObjectMetadataItem({
-    objectNameSingular: 'view',
+    objectNameSingular: CoreObjectNameSingular.View,
   });
   const apolloClient = useApolloClient();
 

packages/twenty-front/src/modules/views/hooks/internal/useViews.ts

@@ -4,6 +4,7 @@ import { useRecoilCallback } from 'recoil';
 import { useObjectMetadataItem } from '@/object-metadata/hooks/useObjectMetadataItem';
 import { GraphQLView } from '@/views/types/GraphQLView';
 import { getViewScopedStateValuesFromSnapshot } from '@/views/utils/getViewScopedStateValuesFromSnapshot';
+import { CoreObjectNameSingular } from '@/object-metadata/types/CoreObjectNameSingular';
 
 export const useViews = (scopeId: string) => {
   const {
@@ -12,7 +13,7 @@ export const useViews = (scopeId: string) => {
     deleteOneRecordMutation: deleteOneMutation,
     findManyRecordsQuery: findManyQuery,
   } = useObjectMetadataItem({
-    objectNameSingular: 'view',
+    objectNameSingular: CoreObjectNameSingular.View,
   });
 
   const apolloClient = useApolloClient();