admin/twenty
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

fix: don't use previous view group state when creating a new view (#8370)

Browse Source 
When creating a new view we don't want to use view-groups from previous
view.
This commit is contained in:
Jérémy M
2024-11-06 16:33:51 +01:00
committed by GitHub
parent a6007d4376
commit ffd790c8fd
1 changed files with 28 additions and 33 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
packages/twenty-front/src/modules/views/hooks/useCreateViewFromCurrentView.ts
View File

@ -18,7 +18,6 @@ import { GraphQLView } from '@/views/types/GraphQLView';
import { View } from '@/views/types/View'; import { View } from '@/views/types/View';
import { ViewGroup } from '@/views/types/ViewGroup'; import { ViewGroup } from '@/views/types/ViewGroup';
import { ViewType } from '@/views/types/ViewType'; import { ViewType } from '@/views/types/ViewType';
import { isNonEmptyArray } from '@sniptt/guards';
import { useContext } from 'react'; import { useContext } from 'react';
import { useRecoilCallback } from 'recoil'; import { useRecoilCallback } from 'recoil';
import { isDefined } from 'twenty-ui'; import { isDefined } from 'twenty-ui';
@ -113,7 +112,6 @@ export const useCreateViewFromCurrentView = (viewBarComponentId?: string) => {
await createViewFieldRecords(sourceView.viewFields, newView); await createViewFieldRecords(sourceView.viewFields, newView);
if (type === ViewType.Kanban) { if (type === ViewType.Kanban) {
if (!isNonEmptyArray(sourceView.viewGroups)) {
if (!isDefined(kanbanFieldMetadataId)) { if (!isDefined(kanbanFieldMetadataId)) {
throw new Error('Kanban view must have a kanban field'); throw new Error('Kanban view must have a kanban field');
} }
@ -143,9 +141,6 @@ export const useCreateViewFromCurrentView = (viewBarComponentId?: string) => {
} satisfies ViewGroup); } satisfies ViewGroup);
await createViewGroupRecords(viewGroupsToCreate, newView); await createViewGroupRecords(viewGroupsToCreate, newView);
} else {
await createViewGroupRecords(sourceView.viewGroups, newView);
}
} }
if (shouldCopyFiltersAndSorts === true) { if (shouldCopyFiltersAndSorts === true) {