747a1549e9
fix: defaultHomePagePath to be last visited page or alphatically first active object with the name ( #6629 )
...
### ISSUE
- Closes #6612
- Closes #6125
- Closes #5949
- Closes #6652
### Description
- [x] need to check changes in jest test.
- [x] fallback to alphabetically firstActiveObject with the name if no
last visited exist
https://github.com/user-attachments/assets/dd11480b-c47f-4393-9857-8a55467061e3
- [x] fallback to last visited page with the last visited view by
default if no views would have toggled with subNav or viewChangeDropdown
it will fallback to INDEX or if no INDEX view then zero position view,
works with both subNavViewBar and viewChangeDropdown.
https://github.com/user-attachments/assets/33e97e55-2aa2-4c45-a3ab-fc8e43f4964c
https://github.com/user-attachments/assets/d1db76a2-da59-4cd2-81bf-d6119408fbbf
- [x] lastVisited view across the objects have been persisted so now
navigating back from x object to y or z to x will open always last
visited view and defaults to index or zero position view.
https://github.com/user-attachments/assets/70a01a11-a7ef-4031-926e-02923551466c
- [x] lastVisited Page with view has been persisted across the
workspace, scope is per workspace so jumping between workspace will also
work to have lastvisited object of particular workspace.
https://github.com/user-attachments/assets/25107339-8ec1-4421-9f6e-1da43b8f4816
- [x] when lastVisitedObject has been deactivated and going back from
settings should have a fallback Object that is alphabetically First
activeObject.
https://github.com/user-attachments/assets/6b24a933-b139-49ac-82b2-eac5e4848516
- [x] Creation of new View of **anyType** should also get persist and
that should get lastVisitedObject with View in case the user leaves from
there right away.
https://github.com/user-attachments/assets/80ff7114-051d-4e9b-ab58-0e1e3a7d328c
- [x] Similarly deleted view also works.
https://github.com/user-attachments/assets/cb0b8043-fba4-4a66-941d-b3fa0a57eb22
- [x] fixed active subnav background when opening object directly with
root path **/** , it wasn't showing active subNav background.
Before:
https://github.com/user-attachments/assets/db341c4a-f1f9-43c4-9838-37d1a1f5ab8e
Fixed:
https://github.com/user-attachments/assets/0f0fd492-bc5d-4efe-b695-bee4e3f41d4e
---------
Co-authored-by: Lucas Bordeau <bordeau.lucas@gmail.com >
2024-08-28 17:15:54 +02:00
33e455655f
Added sync status on the FE ( #6730 )
...
Issue #6685
How do we make sure we get the latest syncStatus on the frontend?
For now we dont get it unless refreshed.
useInterval() on fetching account details?
2024-08-27 11:11:24 +02:00
d61d5857f8
View becomes blank after deleting select ( #6703 )
...
This PR was created by [GitStart](https://gitstart.com/ ) to address the
requirements from this ticket:
[TWNTY-6027](https://clients.gitstart.com/twenty/5449/tickets/TWNTY-6027 ).
This ticket was imported from:
[TWNTY-6027](https://github.com/twentyhq/twenty/issues/6027 )
---
### Description
- Delete corresponding view simultaneously once select field is
deactivated instead of deleted because the bug happens on the
deactivation (one step before deleting), confirmation:
<https://discord.com/channels/1130383047699738754/1268662542172028971/1270367244509249651 >
- Is still possible to create Kanban views with deactivated Select
fields, but this is not related to the PR.
- The changes on the frontend are for refreshing the data after the view
deletion
### Refs
#6027
### Demo
<https://www.loom.com/share/4f705344e3054cd5b3d5eadd398d2c9c?sid=8db3d8b9-4dce-4e31-8359-0e31cbc0e2e7 >
Fixes #6027
---------
Co-authored-by: gitstart-twenty <gitstart-twenty@users.noreply.github.com >
Co-authored-by: Lucas Bordeau <bordeau.lucas@gmail.com >
2024-08-27 11:10:32 +02:00
55685d3c5b
Fix currency field edition form ( #6723 )
...
This PR was created by [GitStart](https://gitstart.com/ ) to address the
requirements from this ticket:
[TWNTY-6692](https://clients.gitstart.com/twenty/5449/tickets/TWNTY-6692 ).
This ticket was imported from:
[TWNTY-6692](https://github.com/twentyhq/twenty/issues/6692 )
---
### Description
The problem is not related to the API, what was happening was a failure
in the form validation, because in the changed file, the `currencyCode`
value, which should be a string with single quotes around it, was
receiving single quotes again, unnecessarily, and this affected field
validation in
`packages/twenty-front/src/modules/object-record/record-field/validation-schemas/currencyFieldDefaultValueSchema.ts`
please, make this change below before testing the PR(to fix a bug, the
slice is not updated yet):\
<aa4ae53fb4https://www.loom.com/share/2ce130f2e2fe46868e9b1e9119f65cde?sid=dbcb2da2-3641-423c-bdfc-01b0fc52162a >
### Refs
#6692
Fixes #6692
---------
Co-authored-by: gitstart-twenty <gitstart-twenty@users.noreply.github.com >
Co-authored-by: Marie Stoppa <marie.stoppa@essec.edu >
2024-08-26 15:02:12 +02:00
873a4c1bd1
Fix serverless save when name empty ( #6720 )
...
- fix serverless function error on save when name empty
- remove useless unique constraint on serverless function names
2024-08-23 17:34:31 +02:00
5d8162dc09
Added hotkeyScopes to serverless functions in settings ( #6710 )
...
Fixes #6656
Is this the right way to implement keyboard listeners?
Please let me know, I'll make the changes accordingly.
:)
https://github.com/user-attachments/assets/af71d340-ead9-4659-81e6-a440522a194f
---------
Co-authored-by: Lucas Bordeau <bordeau.lucas@gmail.com >
2024-08-23 16:54:21 +02:00
f9af25b57e
Fix sentry issue ( #6719 )
...
https://twenty-v7.sentry.io/issues/5677123076/?environment=prod&project=4507072499810304&query=is%3Aunresolved+issue.priority%3A%5Bhigh%2C+medium%5D&referrer=issue-stream&statsPeriod=7d&stream_index=12
Removes billing section when is_free_access_enabled
2024-08-23 16:01:40 +02:00
981f311ed0
Fix addition of new option in select field if there are no existing options ( #6718 )
...
Fixes
[sentry](https://twenty-v7.sentry.io/issues/5745628875/?alert_rule_id=15135099&alert_type=issue¬ification_uuid=95108411-b431-4abd-bdd6-687c96a7353e&project=4507072563183616&referrer=discord )
2024-08-23 12:13:49 +02:00
6f9aa1e870
6654 serverless functions add a deploy button disable deploy when autosave ( #6715 )
...
- improvements on serverless function behavior (autosave performances,
deploy on execution only)
- add versioning to serverless functions
- add a publish endpoint to create a new version of a serverless
function
- add deploy and reset to lastVersion button in the settings section:
<img width="736" alt="image"
src="https://github.com/user-attachments/assets/2001f8d2-07a4-4f79-84dd-ec74b6f301d3 ">
2024-08-23 12:06:03 +02:00
1030ff43d8
Created a specific scroll wrapper context per scroll wrapper and made ScrollTop and ScrollLeft componentStates ( #6645 )
...
@lucasbordeau @charlesBochet
Issue #4826
Could u review this changes.
Let me know what do you think.
---------
Co-authored-by: Lucas Bordeau <bordeau.lucas@gmail.com >
2024-08-22 18:21:14 +02:00
3ae89d15de
Fix post merge ( #6699 )
...
Fixed settingsPreviewRecordId state naming.
2024-08-20 16:45:00 +02:00
db54469c8a
feat: soft delete ( #6576 )
...
Implement soft delete on standards and custom objects.
This is a temporary solution, when we drop `pg_graphql` we should rely
on the `softDelete` functions of TypeORM.
---------
Co-authored-by: Félix Malfait <felix.malfait@gmail.com >
Co-authored-by: Lucas Bordeau <bordeau.lucas@gmail.com >
2024-08-16 21:20:02 +02:00
59e14fabb4
[Issue-5772] Add sort feature on settings tables ( #5787 )
...
## Proposed Changes
- Introduce a new custom hook - useTableSort to sort table content
- Add test cases for the new custom hook
- Integrate useTableSort hook on to the table in settings object and
settings object field pages
## Related Issue
https://github.com/twentyhq/twenty/issues/5772
## Evidence
https://github.com/twentyhq/twenty/assets/87609792/8be456ce-2fa5-44ec-8bbd-70fb6c8fdb30
## Evidence after addressing review comments
https://github.com/twentyhq/twenty/assets/87609792/c267e3da-72f9-4c0e-8c94-a38122d6395e
## Further comments
Apologies for the large PR. Looking forward for the review
---------
Co-authored-by: Félix Malfait <felix.malfait@gmail.com >
Co-authored-by: Lucas Bordeau <bordeau.lucas@gmail.com >
2024-08-14 17:11:17 +02:00
d5350e11a3
Remove some dead code ( #6611 )
...
We could remove a lot more than this, this is just a start.
There are various tools to help with this, knip is a good one
2024-08-11 20:43:18 +02:00
39512a779e
Fix storybook tests ( #6594 )
...
As title
2024-08-09 19:39:16 +02:00
b4e2ada3b0
Fixes Empty Label Identifer Preview in Settings/DataModel/Object/Edit ( #6370 )
...
fixes #6143
---------
Co-authored-by: Félix Malfait <felix.malfait@gmail.com >
2024-08-08 18:30:02 +02:00
74229a80c8
Fix broken tests batch 2 ( #6573 )
...
As title
2024-08-08 11:16:59 +02:00
a7941315e7
Replace entityId by recordId in the front end. ( #6355 )
...
Hey @lucasbordeau, I replaced every `entityId` with `recordId` in the
frontend.
### Some clarifications:
1. At [this
line](0b207d26b6 (diff-b4f415dd1f060307ad61f64394ee96b2912f6015e26c7fd2eab4b8c6a84d2d07L14)0b207d26b6 (diff-b4f415dd1f060307ad61f64394ee96b2912f6015e26c7fd2eab4b8c6a84d2d07L55)0b207d26b6 (diff-52b780bdd4cfc582ca7e1b457dbbd63733bfbb7790fc421054bbd2dbf0389e16)0b207d26b6 (diff-6d47cb9a59dfcf6b1495937084ae799a61da6afccb21208f04ce8e1f5afca0e4)0b207d26b6 (diff-821815783f9968f1da3cd437fc9d1d1666d12dc331d279cc5fbd9817bc2df2bf)felix.malfait@gmail.com >
2024-08-07 08:52:57 +02:00
8373dfdc26
Webhook wip ( #6371 )
...
This PR introduces the following changes:
- Add the ability to filter webhooks by objectSingularName and Actions
- Refactor SettingsWebhookDetails edition to not use react-hook-form
(which will be deprecated on the whole project)
- Updating the tests with a complex set of mock (we just need to fix ~30
of them now :D)
<img width="1053" alt="image"
src="https://github.com/user-attachments/assets/4e56d972-f129-4789-8d1c-4b5797a8ffd7 ">
2024-08-05 23:14:29 +02:00
fa738ec373
fix #5660 standardized relation icon ( #6504 )
...
fix #5660
- updated One to many [1:N] icon across app
- created many to one icon [N:1] , and added it in app
---------
Co-authored-by: Félix Malfait <felix.malfait@gmail.com >
2024-08-05 15:47:25 +02:00
c543716381
Various fixes: profilePicture / logo upload, imageIdentifiers ( #6530 )
...
In this PR:
- refactoring auth module to extract a jwt module that can be re-used
from other part of the app (avoiding circular dependencies file module
=> auth => file (file and auth both need jwt actually)
- activating imageIdentfier on person on workspace creation (this will
put back the images on people)
- fixing picture upload (we were missing some fileToken)
2024-08-04 15:08:25 +02:00
6e0c1b4c73
Fallback to default value when migrating value from enum ( #6517 )
...
When migrating the option values of a select type, if the field is non
nullable (for now, only available for opportunity's "stage" standard
field), we fallback to the (potentially updated) default value instead
of nullifying the value to avoid getting a database error.
---------
Co-authored-by: Charles Bochet <charles@twenty.com >
2024-08-03 17:53:01 +02:00
5f88caf409
Refacto default value ( #6507 )
...
A quick followup of #6506 to add clarity and differentiate emptyValue
from defaultValue
2024-08-03 16:43:53 +02:00
6432ad39b9
feat: add new ACTOR field type and createdBy standard fields ( #6324 )
...
This pull request introduces a new `FieldMetadataType` called `ACTOR`.
The primary objective of this new type is to add an extra column to the
following objects: `person`, `company`, `opportunity`, `note`, `task`,
and all custom objects.
This composite type contains three properties:
- `source`
```typescript
export enum FieldActorSource {
EMAIL = 'EMAIL',
CALENDAR = 'CALENDAR',
API = 'API',
IMPORT = 'IMPORT',
MANUAL = 'MANUAL',
}
```
- `workspaceMemberId`
- This property can be `undefined` in some cases and refers to the
member who created the record.
- `name`
- Serves as a fallback if the `workspaceMember` is deleted and is used
for other source types like `API`.
### Functionality
The pre-hook system has been updated to allow real-time argument
updates. When a record is created, a pre-hook can now compute and update
the arguments accordingly. This enhancement enables the `createdBy`
field to be populated with the correct values based on the
`authContext`.
The `authContext` now includes:
- An optional User entity
- An optional ApiKey entity
- The workspace entity
This provides access to the necessary data for the `createdBy` field.
In the GraphQL API, only the `source` can be specified in the
`createdBy` input. This allows the front-end to specify the source when
creating records from a CSV file.
### Front-End Handling
On the front-end, `orderBy` and `filter` are only applied to the name
property of the `ACTOR` composite type. Currently, we are unable to
apply these operations to the workspace member relation. This means that
if a workspace member changes their first name or last name, there may
be a mismatch because the name will differ from the new one. The name
displayed on the screen is based on the workspace member entity when
available.
### Missing Components
Currently, this PR does not include a `createdBy` value for the `MAIL`
and `CALENDAR` sources. These records are created in a job, and at
present, we only have access to the workspaceId within the job. To
address this, we should use a function similar to
`loadServiceWithContext`, which was recently removed from `TwentyORM`.
This function would allow us to pass the `authContext` to the jobs
without disrupting existing jobs.
Another PR will be created to handle these cases.
### Related Issues
Fixes issue #5155 .
### Additional Notes
This PR doesn't include the migrations of the current records and views.
Everything works properly when the database is reset but this part is
still missing for now. We'll add that in another PR.
- There is a minor issue: front-end tests are broken since this commit:
[80c0fc7ff1bordeau.lucas@gmail.com >
Co-authored-by: Charles Bochet <charles@twenty.com >
2024-08-03 15:43:31 +02:00
281bf689fa
Make api name editable and add expiry ( #6473 )
...
Fixes #6302
---------
Co-authored-by: martmull <martmull@hotmail.fr >
2024-08-02 13:31:06 +02:00
0dcdda3928
Add updated at column ( #6506 )
...
Introduced `updatedAt` column. and fix an existing bug where the field
edition page was crashing because we were trying to compute Date('now')
(param coming from the default value)
2024-08-02 10:03:36 +02:00
80c0fc7ff1
Activity as standard object ( #6219 )
...
In this PR I layout the first steps to migrate Activity to a traditional
Standard objects
Since this is a big transition, I'd rather split it into several
deployments / PRs
<img width="1512" alt="image"
src="https://github.com/user-attachments/assets/012e2bbf-9d1b-4723-aaf6-269ef588b050 ">
---------
Co-authored-by: Charles Bochet <charles@twenty.com >
Co-authored-by: bosiraphael <71827178+bosiraphael@users.noreply.github.com >
Co-authored-by: Weiko <corentin@twenty.com >
Co-authored-by: Faisal-imtiyaz123 <142205282+Faisal-imtiyaz123@users.noreply.github.com >
Co-authored-by: Prateek Jain <prateekj1171998@gmail.com >
2024-07-31 15:36:11 +02:00
6b4c79ff0d
Add workflow runner ( #6458 )
...
- add workflow runner module
- add an endpoint to trigger a workflow via api
- improve error handling for serverless functions
## Testing
- create 2 serverless functions
- create a workflow
- create this workflow Version
```
{
"type": "MANUAL",
"input": {"b": "bb"},
"nextAction": {
"name": "step_1",
"displayName": "Code",
"type": "CODE",
"valid": true,
"settings": {
"serverlessFunctionId": "Serverless function 1 Id",
"errorHandlingOptions": {
"retryOnFailure": {
"value": false
},
"continueOnFailure": {
"value": false
}
}
},
"nextAction": {
"name": "step_1",
"displayName": "Code",
"type": "CODE",
"valid": true,
"settings": {
"serverlessFunctionId": "Serverless function 1 Id",
"errorHandlingOptions": {
"retryOnFailure": {
"value": false
},
"continueOnFailure": {
"value": false
}
}
},
"nextAction": {
"name": "step_1",
"displayName": "Code",
"type": "CODE",
"valid": true,
"settings": {
"serverlessFunctionId": "Serverless function 2 Id",
"errorHandlingOptions": {
"retryOnFailure": {
"value": false
},
"continueOnFailure": {
"value": false
}
}
}
}
}
}
}
`
``
- call
```
mutation Trigger {
triggerWorkflow(workflowVersionId: "WORKFLOW_VERSION_ID") {
result
}
}
```
- try when errors are injected in serverless function
2024-07-31 12:48:33 +02:00
50f1cd352d
Add description for Developers/webhook page ( #6327 )
...
- Add optional description field to webhook page in developer settings.
Fix https://github.com/twentyhq/twenty/issues/6236
---------
Co-authored-by: Thomas Trompette <thomas.trompette@sfr.fr >
2024-07-31 10:59:30 +02:00
ccf4d1eeec
Date formatting per workspace member settings ( #6408 )
...
Implement date formatting per workspace member settings
We'll need another round to maybe initialize all workspaces on the
default settings.
For now the default behavior is to take system settings if nothing is
found in DB.
---------
Co-authored-by: Weiko <corentin@twenty.com >
2024-07-30 14:52:10 +02:00
fed12ddfcd
Improve performance of demo workspace - Rename getImageAbsoluteURIOrBase64 function ( #6282 )
...
### Description
1. This PR is a continuation of a previous PR:
https://github.com/twentyhq/twenty/pull/6201#pullrequestreview-2175601222
2. One test case was removed here:
`packages/twenty-front/src/utils/image/__tests__/getImageAbsoluteURI.test.ts`
because since we are not handling base64 images anymore, the result is
the same of the last test case. Would you rather we update the test
instead?
### Refs
- #3514
- https://github.com/twentyhq/twenty/pull/6201
### Demo
https://www.loom.com/share/4f32b535c77a4d418e319b095d09452c?sid=df34adf8-b013-44ef-b794-d54846f52d2d
Fixes #3514
---------
Co-authored-by: gitstart-twenty <gitstart-twenty@users.noreply.github.com >
2024-07-29 14:07:21 +02:00
00fea17920
Serverless function UI ( #6388 )
...
https://www.figma.com/design/xt8O9mFeLl46C5InWwoMrN/Twenty?node-id=36235-120877
Did not do the file manager part. A Function is defined using one unique
file at the moment
Feature protected by featureFlag `IS_FUNCTION_SETTINGS_ENABLED`
## Demo
https://github.com/user-attachments/assets/0acb8291-47b4-4521-a6fa-a88b9198609b
2024-07-29 13:03:09 +02:00
6728e40256
5899 display a banner to alert users which need to reconnect their account ( #6301 )
...
Closes #5899
<img width="1280" alt="Index - banner"
src="https://github.com/twentyhq/twenty/assets/71827178/313cf20d-eb34-496a-8c7c-7589fbd55954 ">
---------
Co-authored-by: Charles Bochet <charles@twenty.com >
2024-07-27 18:34:52 +02:00
b9c8d607aa
Test revert crm integration ( #6321 )
...
PR to test revert integration in production
2024-07-25 09:38:55 +02:00
01fe3b673e
Datamodel overview show other fields ( #6352 )
...
<img width="638" alt="Bildschirmfoto 2024-07-19 um 23 49 00"
src="https://github.com/user-attachments/assets/57b600c4-d985-4e4c-afc0-e0c6dd5bc9f6 ">
---------
Co-authored-by: Marie Stoppa <marie.stoppa@essec.edu >
2024-07-22 16:13:49 +02:00
284e75791c
Fixes Strange behaviour when reordering options of select field ( #6103 ) ( #6339 )
...
fixes #6103
---------
Co-authored-by: Marie Stoppa <marie.stoppa@essec.edu >
2024-07-22 14:33:02 +02:00
b64e8096d6
Fixed scoped hotkeys ( #6322 )
...
- Removed enabled props from useScopedHotkeys becayse it doesn't work
- Moved enter useScopedHotkeys in a handler that we drill down to the
text inputs on the settings form
---------
Co-authored-by: Charles Bochet <charles@twenty.com >
2024-07-19 19:25:12 +02:00
a4e82d643a
Support custom composite field deletion ( #6320 )
...
as per title
Fixes #6033 and closes #4841
2024-07-18 15:28:32 +02:00
62e9492e8b
Fix email and calendar settings not displayed when only one channel is present
2024-07-18 09:23:14 +02:00
94c2358c89
#6094 Prevent creating a custom field with an existing name ( #6100 )
...
Fixes #6094
Description: Added logic inside SettingsObjectNewFieldStep2.tsx to
prevent form submission
Current Behaviours:
<img width="947" alt="Screenshot 2024-07-03 at 1 45 31 PM"
src="https://github.com/twentyhq/twenty/assets/95612797/bef54bc4-fc83-48f3-894a-34445ec64723 ">
---------
Co-authored-by: Marie Stoppa <marie.stoppa@essec.edu >
2024-07-17 11:43:57 +02:00
a8dfff3a6d
fix: conditionally rendered Tablist only if there are multiple accounts. ( #6274 )
...
issue - 6267
---------
Co-authored-by: Charles Bochet <charles@twenty.com >
2024-07-16 13:51:08 +02:00
364caf0fdf
fix: remove usage of probability field ( #5877 )
...
- fixes #5735
---------
Co-authored-by: Marie Stoppa <marie.stoppa@essec.edu >
2024-07-16 10:24:35 +02:00
f68bd1be66
Fixes 6223 graph button indistinguishable ( #6223 ). Replaces Button with FloatingButton ( #6234 )
...
fixes #6223
---------
Co-authored-by: Charles Bochet <charles@twenty.com >
2024-07-12 20:29:15 +02:00
4350279c64
fix: settings object slug link ( #6228 )
...
fixes https://github.com/twentyhq/twenty/issues/6213
fixed the mentioned case + tried to find&fix other possible broken links
2024-07-11 23:31:58 +02:00
9917fb0f9e
Fix/disable cancel button on save ( #6204 )
...
# This PR
- Fix #5675
- Fix #6118
Similarly to #5673 I have improved the field creation time by
re-fetching data on page redirection to the object page
<img width="1511" alt="Screenshot 2024-07-10 at 16 06 37"
src="https://github.com/twentyhq/twenty/assets/61581306/8ef8f4cb-4334-4f4c-b5d9-fea11fd5d99a ">
@FellipeMTX @Bonapara
---------
Co-authored-by: Félix Malfait <felix.malfait@gmail.com >
2024-07-11 07:56:07 +02:00
9ba211055a
Add message import granulary on non-pro emails, group emails and received contact creation ( #6156 )
...
1) Remove featureFlag
2) Base contactCreation on messageChannel.autoContactCreationPolicy
4) add excludeProfessionalEmails + excludeGroupEmails logic
2024-07-08 14:33:48 +02:00
ef849d316f
Small fixes on accounts settings ( #6157 )
...
- Add keys in components map
2024-07-08 12:00:00 +02:00
af83879d7a
Add new Settings to front-end ( #6154 )
...
<img width="1512" alt="image"
src="https://github.com/twentyhq/twenty/assets/12035771/cfcc6ac9-feeb-4d91-aa68-bd0119780d6d ">
2024-07-08 10:47:55 +02:00
87dc95c594
Refactor Calendar Settings into tabs ( #6153 )
...
This PR migrates Calendar Settings into Tabs:
<img width="1512" alt="image"
src="https://github.com/twentyhq/twenty/assets/12035771/2531d0f1-ddfd-46c6-8678-bd76d78447b6 ">
2024-07-08 09:11:47 +02:00
46dac5a0ef
Fix storybook tests ( #6150 )
...
The PRs merged on Friday introduced regressions on our storybook tests
suite
2024-07-06 09:32:30 +02:00
