Paul Rastoin
7fd89678b7
[CHORE] Avoid isDefined duplicated reference, move it to twenty-shared ( #9967 )
...
# Introduction
Avoid having multiple `isDefined` definition across our pacakges
Also avoid importing `isDefined` from `twenty-ui` which exposes a huge
barrel for a such little util function
## In a nutshell
Removed own `isDefined.ts` definition from `twenty-ui` `twenty-front`
and `twenty-server` to move it to `twenty-shared`.
Updated imports for each packages, and added explicit dependencies to
`twenty-shared` if not already in place
Related PR https://github.com/twentyhq/twenty/pull/9941
2025-02-01 12:10:10 +01:00
Khuddite and Félix Malfait
62df0f0445
Display a generic fallback component when initial config load fails ( #8588 )
...
Fixes : #8487 #5027
1. Summary
The purpose of these changes is to elevate the dev/user experience when
the initial config load call fails for whatever reason by displaying a
fallback component.
2. Solution
I ended up making more changes than I initially planned. I had to update
the order of the contexts a bit because `GenericErrorFallback` is
dependent on `AppThemeProvider` for styling and `AppThemeProvider` is
dependent on `ObjectMetadataItemsProvider` for
[`useObjectMetadataItem`](https://github.com/khuddite/twenty/blob/ae2f193d68c6168e4c8323297d58f6dbc1de9fdf/packages/twenty-front/src/modules/object-metadata/hooks/useObjectMetadataItem.ts#L22 )
hook (`AppThemeProvider` -> `useColorScheme` -> `useUpdateOneRecord` ->
`useObjectMetadataItem`). I had to create a wrapper component for
`AppThemeProvider` and stylize it in a way that it looks responsive on
both mobile and desktop devices. Finally, I had to introduce the
`isErrored` flag to differentiate the loading and error states.
There are some improvements we can make later -
- Display a loading state for the initial config load
- Implement a refetch logic for the initial config loading failure
3. Recording
https://github.com/user-attachments/assets/c2f43573-8006-4118-8e18-8576099d78fd
https://github.com/user-attachments/assets/9c5853d3-539b-4880-aa38-c416c3e13594
---------
Co-authored-by: Félix Malfait <felix@twenty.com >
2024-11-22 09:45:23 +01:00
0a28c15747
Migrate to twenty-ui - input/button ( #7994 )
...
This PR was created by [GitStart](https://gitstart.com/ ) to address the
requirements from this ticket:
[TWNTY-7529](https://clients.gitstart.com/twenty/5449/tickets/TWNTY-7529 ).
---
### Description
- Migrated all button components to `twenty-ui` \
\
`Button`\
`ButtonGroup`\
`ColorPickerButton`\
`FloatingButton`\
`FloatingButtonGroup`\
`FloatingIconButton`\
`FloatingIconButtonGroup`\
`IconButton`\
`IconButtonGroup`\
`LightButton`\
`LightIconButton`\
`LightIconButtonGroup`\
`MainButton`\
\
Fixes twentyhq/private-issues#89
Co-authored-by: gitstart-twenty <gitstart-twenty@users.noreply.github.com >
Co-authored-by: Charles Bochet <charles@twenty.com >
2024-10-24 13:20:02 +02:00
Charles Bochet
eccf0bf8ba
Enforce front project structure through ESLINT ( #7863 )
...
Fixes: https://github.com/twentyhq/twenty/issues/7329
2024-10-20 20:20:19 +02:00
brendanlaschke and Marie Stoppa
4545ba2737
Update blocknote ( #6349 )
...
Updating blocknote providing bugfixes & new block types
---------
Co-authored-by: Marie Stoppa <marie.stoppa@essec.edu >
2024-07-22 16:00:14 +02:00
Thaïs
9f83cc1426
refactor: move @/ui/display/icon to twenty-ui ( #4820 )
...
Split from https://github.com/twentyhq/twenty/pull/4518
Part of https://github.com/twentyhq/twenty/issues/4766
2024-04-12 15:30:48 +02:00
Thaïs
5d07b6347e
refactor: move Tabler Icon exports to twenty-ui ( #4727 )
...
Split from https://github.com/twentyhq/twenty/pull/4518
2024-04-01 13:15:47 +02:00
brendanlaschke
017b09ba35
Blocknote custom slash menu ( #4517 )
...
blocknote v12, cleaned up blockschema & specs, added custom slash menu
2024-03-20 08:38:05 +01:00
Lucas Bordeau
581dfafe11
Renamed nullable utils into isDefined and isUndefinedOrNull ( #4402 )
...
* Renamed nullable utils into isDefined and isUndefinedOrNull
2024-03-11 14:28:57 +01:00
17511be0cf
TWNTY-3794 - ESLint rule: only take explicit boolean predicates in if statements ( #4354 )
...
* ESLint rule: only take explicit boolean predicates in if statements
Co-authored-by: v1b3m <vibenjamin6@gmail.com >
Co-authored-by: Toledodev <rafael.toledo@engenharia.ufjf.br >
* Merge main
Co-authored-by: v1b3m <vibenjamin6@gmail.com >
Co-authored-by: Toledodev <rafael.toledo@engenharia.ufjf.br >
* Fix frontend linter errors
Co-authored-by: v1b3m <vibenjamin6@gmail.com >
Co-authored-by: Toledodev <rafael.toledo@engenharia.ufjf.br >
* Fix jest
Co-authored-by: v1b3m <vibenjamin6@gmail.com >
Co-authored-by: Toledodev <rafael.toledo@engenharia.ufjf.br >
* Refactor according to review
Co-authored-by: v1b3m <vibenjamin6@gmail.com >
Co-authored-by: Toledodev <rafael.toledo@engenharia.ufjf.br >
* Refactor according to review
Co-authored-by: v1b3m <vibenjamin6@gmail.com >
Co-authored-by: Toledodev <rafael.toledo@engenharia.ufjf.br >
* Fix lint on new code
Co-authored-by: v1b3m <vibenjamin6@gmail.com >
Co-authored-by: Toledodev <rafael.toledo@engenharia.ufjf.br >
---------
Co-authored-by: gitstart-twenty <gitstart-twenty@users.noreply.github.com >
Co-authored-by: v1b3m <vibenjamin6@gmail.com >
Co-authored-by: Toledodev <rafael.toledo@engenharia.ufjf.br >
2024-03-09 10:48:19 +01:00
brendanlaschke and Charles Bochet
f6f4e6c769
Update blocknote ( #3517 )
...
* update blocknote, remove feature flag
* Fix backend
---------
Co-authored-by: Charles Bochet <charles@twenty.com >
2024-01-18 09:40:00 +01:00
ebe8698910
Increase test coverage for /modules/ui ( #3314 )
...
* Increase test coverage for `/modules/ui`
Co-authored-by: v1b3m <vibenjamin6@gmail.com >
Co-authored-by: FellipeMTX <fellipefacdir@gmail.com >
Co-authored-by: Fellipe Montes <102544529+FellipeMTX@users.noreply.github.com >
* Merge main
Co-authored-by: v1b3m <vibenjamin6@gmail.com >
Co-authored-by: FellipeMTX <fellipefacdir@gmail.com >
Co-authored-by: Fellipe Montes <102544529+FellipeMTX@users.noreply.github.com >
* Fix tests
* Fix tests
* Fix
---------
Co-authored-by: gitstart-twenty <gitstart-twenty@users.noreply.github.com >
Co-authored-by: v1b3m <vibenjamin6@gmail.com >
Co-authored-by: FellipeMTX <fellipefacdir@gmail.com >
Co-authored-by: Fellipe Montes <102544529+FellipeMTX@users.noreply.github.com >
Co-authored-by: Charles Bochet <charles@twenty.com >
2024-01-11 08:51:36 +01:00
Charles Bochet
96264e264c
Refactor recoil v4 ( #3266 )
...
* Refactor recoil v4
* Fix ci
2024-01-05 19:18:22 +01:00
brendanlaschke and Lucas Bordeau
9def3d5b57
Activity editor add File block ( #3146 )
...
* - added file block
* fised auth useeffect
* - add cmd v for file block
* remove feature flag for attachment upload in blockeditor
---------
Co-authored-by: Lucas Bordeau <bordeau.lucas@gmail.com >
2024-01-05 17:42:50 +01:00