khuddite
183fd877c4
Add a confirmation modal for relation object deletion ( #8818 )
...
Fixes #8698
1. Summary
We decided to add a confirmation modal for the relation object deletion.
It's gonna a bit of safety to the user interactions because this action
can be disruptive even though it can be restored.
2. Solution
Used `createPortal` function to address the issue where the vertical
scrollbar shows over the modal. Added a logic that displays a
confirmation modal for deletion in [this
file](https://github.com/twentyhq/twenty/blob/d284419d66cf52e418d6622b9635334486b51040/packages/twenty-front/src/modules/object-record/record-show/record-detail-section/components/RecordDetailRelationRecordsListItem.tsx ).
I can update the text(title, description, and CTA) as necessary based on
the feedback.
_**However, I observed an issue that the deleted object still shows up
under the list until hard-refresh. I figured that can be addressed as a
separate issue.**_
3. Recording
https://github.com/user-attachments/assets/1a64b702-a915-49f3-a226-2c2d5af8a1d7
2024-12-11 18:23:27 +01:00
Thomas Trompette
4d9facb9bd
Add address composite form field ( #9022 )
...
- Create FormCountrySelectInput using the existing FormSelectFieldInput
- Create AddressFormFieldInput component
- Fix FormSelectFieldInput dropdown + add leftIcon
<img width="554" alt="Capture d’écran 2024-12-11 à 15 56 32"
src="https://github.com/user-attachments/assets/c3019f29-af76-44e1-96bd-a0c6283674e1 "
/>
2024-12-11 16:57:42 +00:00
Murali Singh and guillim
6067852c1c
fix(chip): update padding for transparent variant ( #7164 ) ( #8823 )
...
This PR addresses the issue described in #7164 , where the Chip
component's padding for the Transparent variant was not correctly
aligned. The following changes have been made:
The padding-left for the Transparent variant is now set to 2px to
improve alignment.
Other chip variants retain the default horizontal padding values.
These changes ensure that the Transparent chip variant is rendered
consistently with the rest of the design, as described in #7164 .
See screenshots below for before and after comparison:
Before:
After:
Please review @Bonapara and let me know if you have any feedback or
concerns.
---------
Co-authored-by: guillim <guigloo@msn.com >
2024-12-11 14:52:55 +01:00
Raphaël Bosi
5c60a5511e
8929 move recordindexactionmenu menu inside the recordindexpageheader ( #9007 )
...
Closes #8929
Users with the feature flag `IS_PAGE_HEADER_V2_ENABLED` set to false
will still have the old behavior with the action bar.
To test the PR, test with and without the feature flag.
2024-12-11 11:51:33 +01:00
Guillim
89f6f32243
Title overflow ( #9009 )
...
fix #8803
2024-12-11 11:37:08 +01:00
Marie
8ecf07f112
[Aggregate queries for table views - #1 ] Introduce aggregateOperationForViewFieldState ( #9010 )
...
Introducing aggregateOperationForViewFieldState to add a state storing
the aggregate operation for each view field
2024-12-10 18:03:38 +00:00
Thomas Trompette
b6e02b630d
Add full name composite field ( #9008 )
...
- Add composite field
- Add test
- Fix search variable dropdown scroll
<img width="548" alt="Capture d’écran 2024-12-10 à 16 52 43"
src="https://github.com/user-attachments/assets/c337f0c3-8a70-401a-abd0-7206489ba73e ">
2024-12-10 16:29:55 +00:00
Lucas Bordeau
013eda4a32
Fixed dropdown bugs on 0.34 ( #9000 )
...
- New task dropdown wasn't using the proper dropdown id
- Action menu triggered by context menu (right click) on table cell was
listening in edit mode.
2024-12-10 16:01:03 +01:00
Raphaël Bosi
f0dbeea704
Remove buttons for activity empty state ( #8999 )
...
Before:
<img width="482" alt="Capture d’écran 2024-12-10 à 11 17 53"
src="https://github.com/user-attachments/assets/3641e902-10b9-4fbf-8383-d6e5d5b2de79 ">
After:
<img width="453" alt="Capture d’écran 2024-12-10 à 11 33 01"
src="https://github.com/user-attachments/assets/9f949933-0740-4c91-abf3-2c1817a68968 ">
2024-12-10 11:09:40 +00:00
Raphaël Bosi
c553361f25
Fix RecordDetailSectionHeader spacing ( #8997 )
...
Before:
<img width="339" alt="Capture d’écran 2024-12-10 à 11 02 30"
src="https://github.com/user-attachments/assets/4fd1d598-0efe-4ee9-931e-dd307af21c95 ">
After:
<img width="345" alt="Capture d’écran 2024-12-10 à 11 02 19"
src="https://github.com/user-attachments/assets/fb72a661-ac66-43c7-906c-9020171dbf3b ">
2024-12-10 11:16:45 +01:00
Raphaël Bosi
d70987653b
8964 add feature flag is page header v2 enabled ( #8995 )
...
Closes #8964
2024-12-10 10:56:28 +01:00
Suhotra Dey and Félix Malfait
f4ef51fbe5
Fix : Small fixes for the options menu ( #8983 )
...
Fix #8789 : fixed options menu with current view hook to fetch the view
name
---------
Co-authored-by: Félix Malfait <felix@twenty.com >
2024-12-10 09:19:46 +01:00
Guillim
310bba758b
fix ( #8963 )
...
fixing
2024-12-09 13:44:19 +00:00
Raphaël Bosi
387f5259a7
8928 refactor page header buttons ( #8952 )
...
Closes #8928
<img width="1296" alt="Capture d’écran 2024-12-09 à 10 26 37"
src="https://github.com/user-attachments/assets/f33202b0-9c11-48da-8daa-e867d62a1803 ">
<img width="1296" alt="Capture d’écran 2024-12-09 à 10 26 54"
src="https://github.com/user-attachments/assets/a94f89d4-ca12-403f-bfcb-12168a82f77c ">
2024-12-09 10:55:33 +01:00
Lucas Bordeau
1749793bc1
More fixes ( #8931 )
...
Fixes https://github.com/twentyhq/twenty/issues/8888
2024-12-07 16:49:53 +01:00
Charles Bochet
ab8ad46685
Fix bug reoder on table in view groups mode ( #8894 )
...
Fixes #8403
Added comments on the PR to explain changes
2024-12-06 19:19:27 +01:00
Raphaël Bosi
9c67a109af
Fix SingleRecordSelectMenuItemsWithSearch ( #8932 )
...
- Fix all fields being selected when opening dropdown
- Fix not being able to set back to no selection when a record is
selected and there is only one record to select
Before:
https://github.com/user-attachments/assets/31185a05-7e1a-4550-aa2a-591683934224
After:
https://github.com/user-attachments/assets/e3cd388b-44de-42e2-970b-b4d4f31253bc
2024-12-06 17:41:58 +01:00
Lucas Bordeau
a9cb20f317
Refactor and fixes dropdown bugs ( #8807 )
...
Fixes https://github.com/twentyhq/twenty/issues/8788
Fixes https://github.com/twentyhq/twenty/issues/8793
Fixes https://github.com/twentyhq/twenty/issues/8791
Fixes https://github.com/twentyhq/twenty/issues/8890
Fixes https://github.com/twentyhq/twenty/issues/8893
- [x] Also :
Icon buttons under dropdown are visible without blur :
- [x] Also :
<img width="237" alt="image"
src="https://github.com/user-attachments/assets/e4c70936-beff-4481-89cb-0a32a36e0ee2 ">
- [x] Also :
<img width="335" alt="image"
src="https://github.com/user-attachments/assets/5be60395-6baf-49eb-8d40-197add049e20 ">
- [x] Also :
<img width="287" alt="image"
src="https://github.com/user-attachments/assets/a317561f-7986-4d70-a1c0-deee4f4e268a ">
- Button create new without padding
- Container is expanding
- [x] Also :
<img width="303" alt="image"
src="https://github.com/user-attachments/assets/09f8a27f-91db-4191-acdc-aaaeedaf6da5 ">
- [x] Also :
<img width="133" alt="image"
src="https://github.com/user-attachments/assets/fe17b32e-f7a4-46c4-8040-239eaf8198e8 ">
Font is cut at bottom ?
- [x] Also :
<img width="385" alt="image"
src="https://github.com/user-attachments/assets/7bab2092-2936-4112-a2ee-d32d6737e304 ">
The component should flip and not resize in this situation
- [x] Also :
<img width="244" alt="image"
src="https://github.com/user-attachments/assets/5384f49a-71f9-4638-a60c-158cc8c83f81 ">
- [x] Also :
2024-12-06 14:27:48 +00:00
14b7bcf262
Fix phone not reactive ( #8918 )
...
Fixin reactivity on the multi items phone component (add/delete/edit
phones)
<img width="325" alt="Screenshot 2024-12-06 at 11 03 34"
src="https://github.com/user-attachments/assets/96ddaf82-19ae-4a09-aa45-04caad2f0af1 ">
---------
Co-authored-by: khuddite <khuddite@gmail.com >
Co-authored-by: Weiko <deniaud.corentin@gmail.com >
2024-12-06 14:45:14 +01:00
50af41f170
Remove duplicate plus sign for phone numbers ( #8871 )
...
Fixes #8838
1. Summary
It seems [this PR](https://github.com/twentyhq/twenty/pull/8614 ) caused
the issue. We added a plus sign on front-end when the
[callingCode](https://github.com/twentyhq/twenty/blob/c735026f6c4f011e82e80713f1554b5cdb4fda5b/packages/twenty-front/src/modules/ui/field/display/components/PhonesDisplay.tsx#L70 )
retrieved from back-end already has a plus sign.
2. Solution
@guillim Please let me know if I missed a case where the plus sign is
not there for the `callingCode`. If so, I think we should check whether
or not `callingCode` has a leading plus sign on front-end before adding
it. For now, I just removed the code that appends a plus sign on
front-end.
3. Screenshots
---------
Co-authored-by: guillim <guigloo@msn.com >
Co-authored-by: Guillim <guillim@users.noreply.github.com >
Co-authored-by: Weiko <deniaud.corentin@gmail.com >
2024-12-05 22:41:14 +01:00
eliasylonen and ad-elias
f60ce384c6
CSV importing and exporting fixes ( #8824 )
...
Fixes issue https://github.com/twentyhq/twenty/issues/5793 (and
duplicate https://github.com/twentyhq/twenty/issues/8822 )
- Fix importing multi-select and array fields.
- Fix exporting and importing RAW_JSON fields.
---------
Co-authored-by: ad-elias <elias@autodiligence.com >
2024-12-05 18:44:53 +01:00
Marie
26ff344f56
Refetch aggregate queries on record creation/update/deletion of record ( #8885 )
...
Closes #8755 .
Refetching the aggregate queries on an object following creation,
update, deletion of a record.
2024-12-05 15:23:54 +01:00
Guillim
6c78cac908
Fix wrapping text side effects ( #8895 )
...
- ellipsis on the letter level instead of work level
- summaryCard title line-height diffferent from the record line-height
2024-12-05 14:43:16 +01:00
Jérémy M and Charles Bochet
7ab00a4c82
feat: record group fetch more ( #8868 )
...
Fix #8756
This PR is adding a load more button when we're grouping by a field in
table view.
Only 8 records are printed at first, and a click on `Load more` is
needed to show more records.
<img width="1347" alt="Screenshot 2024-12-04 at 11 54 15 AM"
src="https://github.com/user-attachments/assets/4ad6ad4f-8de9-424d-b7b6-5f82f28c53df ">
<img width="1352" alt="Screenshot 2024-12-04 at 11 54 23 AM"
src="https://github.com/user-attachments/assets/2a94b4ac-7285-4ba2-9cff-d2f653e36302 ">
---------
Co-authored-by: Charles Bochet <charles@twenty.com >
2024-12-05 10:51:56 +01:00
Baptiste Devessier
99caab1412
Select all fields even those not loaded yet when doing Ctrl+A or Cmd+A on Record Table ( #8849 )
...
Solves
https://github.com/twentyhq/twenty/pull/8282#issuecomment-2508641480
2024-12-05 06:11:48 +01:00
Jérémy M
2fa5fb7de7
fix: record group issues ( #8854 )
...
This PR is fixing the following issues with record groups:
- [x] [Backend] - Only update view groups when a field is edited if this
one already has view groups
- [x] [Backend] - Editing a Select field metadata option brake view
groups
- [x] [Frontend] - Changing the group by field from one to another brake
record group and doesn't remove the previous ones
- [x] [Frontend & Backend] - Mark `kanbanFieldMetadataId` as deprecated
in favour of `viewGroups.fieldMetadataId`
Also the following has been checked:
- [x] Properly displayed a table with only one view groups
- [x] Properly displayed a table without view groups
2024-12-04 16:03:25 +01:00
Baptiste Devessier
9142bdfb92
Add Select form field ( #8815 )
...
Closes https://github.com/twentyhq/twenty/pull/8815
I took inspiration from existing parts of the codebase. Please, see the
comments I left below.
Remaining questions:
- I'm not sure about the best way to handle hotkey scopes in the
components easily
https://github.com/user-attachments/assets/7a6dd144-d528-4f68-97cd-c9181f3954f9
2024-12-04 15:39:14 +01:00
Marie and Weiko
2fc247cb21
Display and update aggregate queries in kanban views ( #8833 )
...
Closes #8752 , #8753 , #8754
Implements usage of aggregate queries in kanban views.
https://github.com/user-attachments/assets/732590ca-2785-4c57-82d5-d999a2279e92
TO DO
1. write tests + storybook
2. Fix values displayed should have the same format as defined in number
fields + Fix display for amountMicros
---------
Co-authored-by: Weiko <corentin@twenty.com >
2024-12-03 22:46:57 +01:00
nitin
9a65e80566
Remove the heart icon button to add the view as a favorite from the top bar ( #8769 )
...
closes #8546
@Bonapara please check the behaviour, if this is what you were looking
for! ;)
2024-12-03 13:49:00 +01:00
martmull
d0ff1ffd5f
8723 workflow add editor in serverless function code step ( #8805 )
...
- create a serverless function when creating a new workflow code step
- add code editor in workflow code step
- move workflowVersion steps management from frontend to backend
- add a custom resolver for workflow-version management
- fix optimistic rendering on frontend
- fix css
- delete serverless function when deleting workflow code step
TODO
- Don't update serverlessFunction if no code change
- Factorize what can be between crud trigger and crud step
- Publish serverless version when activating workflow
- delete serverless functions when deleting workflow or workflowVersion
- fix optimistic rendering for code updates
- Unify CRUD types
<img width="1279" alt="image"
src="https://github.com/user-attachments/assets/3d97ee9f-4b96-4abc-9d36-5c0280058be4 ">
2024-12-03 08:41:13 +00:00
Nathaniel Brough
64500d07d3
Use builtin number validation ( #8819 )
...
The regex approach doesn't work great for the many different number
formats. Even a simple decimal failed e.g. '1.1' was considered invalid.
I've switched this over to use javascripts builtin conversion and
validation. This now supports other formats e.g. '-1.0e15' would now be
considered valid.
Closes : #8820
2024-12-02 15:03:49 +01:00
Guillim and Charles Bochet
0527bc296e
Default address country 🗺️ & Phone prefix ☎️ ( #8614 )
...
# Default address 🗺️ country & Phone ☎️ country
We add the ability to add a Default address country and a default Phone
country for fields in the Data model.
fix #8081
---------
Co-authored-by: Charles Bochet <charles@twenty.com >
2024-12-02 12:34:05 +00:00
Félix Malfait
29eb9fe77b
Don't show summary/fields on workflow record pages ( #8804 )
...
Hiding the left column on workflow pages
This raises additional questions: how do we edit the title then?
Probably need a significant refacto of PageHeader
<img width="1094" alt="Screenshot 2024-11-29 at 10 01 08"
src="https://github.com/user-attachments/assets/b98d55cb-5097-4e46-bac5-5570d9ca0ad8 ">
2024-11-29 18:11:44 +01:00
Jérémy M
a2d55a8694
feat: table record group ( #8781 )
...
Fix #8401 #8402
This PR is only taking care or displaying properly the record group on
the table.
Record-reorder within group has also been prepared.
Start of collapsible animation has been done, but not working for now.
<img width="1381" alt="Screenshot 2024-11-28 at 2 52 07 PM"
src="https://github.com/user-attachments/assets/514bb3e6-3475-4c47-a91c-64f7d20bbe73 ">
2024-11-29 13:04:27 +01:00
eliasylonen and ad-elias
c878f09d72
Fix token expiration error loop ( #6731 ) ( #8802 )
...
Fixes issue https://github.com/twentyhq/twenty/issues/6731
**Problem:** After access token token expires, scrolling down the
`RecordTable` component will put it to an infinite loop of trying to
fetch records and printing errors on every iteration.
**Solution:** Disable fetching until component remount if a `FORBIDDEN`
error is encountered.
---------
Co-authored-by: ad-elias <elias@autodiligence.com >
2024-11-29 10:59:19 +01:00
Thomas Trompette
83223eeae3
Upgrade relation picker ( #8795 )
...
- Rename all parts using the name "relation" to "record" when component
is only selecting record
- Remove the use of scope states in folder
- Rename entities to records
This PR prepares the use of the record picker in workflows
2024-11-28 18:08:39 +01:00
Baptiste Devessier
d73dc1a728
Create form field number ( #8634 )
...
- Refactor VariableTagInput to have a reusable low-level TipTap editor
- Create three primitive form fields:
- Text
- Number
- Boolean
## Notes
- We should automatically recognize the placeholder to use for every
FormFieldInput, as it's done for FieldInputs.
## Design decisions
Our main challenge was for variables and inputs to be able to
communicate between each other. We chose an API that adds some
duplication but remains simple and doesn't rely on "hacks" to work.
Common styles are centralized.
## Demo
"Workflow" mode with variables:
FormFieldInput mode, without variables:
Behavior difference between fields that can contain variables and static
content, and inputs that can have either a variable value or a static
value:
2024-11-28 17:03:24 +00:00
Guillim and guillim
041b1f21bf
line breaks in tooltips & text ( #8783 )
...
This feature goal is to :
1 - clean variables not used any longer
2 - add line breaks for tooltips and text wrapped
<img width="329" alt="Screenshot 2024-11-27 at 18 37 18"
src="https://github.com/user-attachments/assets/b3d7ed76-df30-4377-9d73-08d55c0f5c49 ">
<img width="468" alt="Screenshot 2024-11-27 at 18 37 31"
src="https://github.com/user-attachments/assets/48ef343e-6071-4a89-a73f-fb271f8284c0 ">
Request From @Bonapara
---------
Co-authored-by: guillim <guillaume@twenty.com >
2024-11-28 14:30:23 +01:00
Jérémy M
812ed6ed69
feat: record board component state refactor ( #8779 )
...
Fix #8758
This PR is migrating the recoil component state from v1 to v2 for board.
It also now share some states and logics between board and table,
further can be done later.
Lastly this PR fix an issue since the PR #8613 that was treating
no-value as a normal record-group.
2024-11-28 13:44:21 +01:00
Harsh Singh and Lucas Bordeau
3ad1113173
fix: scroll dropdown listing in hidden fields ( #8738 )
...
Fixes : #8716
[Screencast from 2024-11-25
22-06-24.webm](https://github.com/user-attachments/assets/35bd66cc-942f-4903-abda-0d67a75b6582 )
---------
Co-authored-by: Lucas Bordeau <bordeau.lucas@gmail.com >
2024-11-27 18:06:11 +01:00
Guillim and guillim
315938215e
Fix Table text wrapping ( #8683 )
...
As discovered during the last release, text fields in the table were
wrapped. This PR fixes this unwanted behaviour
Current :
<img width="1077" alt="Screenshot 2024-11-22 at 14 17 42"
src="https://github.com/user-attachments/assets/080c5b1f-b793-46de-8733-9c69a4eb6b3b ">
Wanted :
One line ellipsed
<img width="244" alt="Screenshot 2024-11-22 at 14 20 46"
src="https://github.com/user-attachments/assets/c1d32859-4ffe-42e3-bfed-66db20c8c0c7 ">
---------
Co-authored-by: guillim <guillaume@twenty.com >
2024-11-26 17:58:05 +01:00
Khuddite
dfb966d47e
Treat no value view group as normal & enable hide/dnd for no value ( #8613 )
...
Fixes #8591
1. Summary
We disabled hide/dnd(drag-and-drop) options for `No value` view group
intentionally in the first implementation. We want to change it to
behave like normal view groups, so enable hide/dnd for `No value` view
group as well.
2. Solution
I have removed the code that filters the `No value` group out of view
groups, so `No value` is stored in the same array as other view groups.
I have removed the `No value` flag check for `Hide` button on the
hamburger menu of the Kanban header. I had to update the code in
`packages/twenty-front/src/modules/views/utils/mapViewGroupsToRecordGroupDefinitions.ts`
because it was ignoring the visibility flag of the `No value` view group
and set it always to true. Also, it was always putting the `No value`
group last ignoring the previous position.
>**_I am not 100% confident in the changes I made in
`packages/twenty-front/src/modules/views/utils/mapViewGroupsToRecordGroupDefinitions.ts`.
I'd like to have a review from someone more familiar with that part._**
3. Recording
https://github.com/user-attachments/assets/e135e22e-6e3a-4f94-a898-aafc03bba060
2024-11-26 17:47:42 +01:00
ad-elias and Félix Malfait
eea2885cbd
Fix: open filter from column ( #8747 )
...
Column filter button (image below) was broken for all filter types, this
PR fixes it.
<img width="1053" alt="broken-filter-button"
src="https://github.com/user-attachments/assets/febd10a8-f360-4245-ba06-ef847c79fde1 ">
---------
Co-authored-by: Félix Malfait <felix@twenty.com >
2024-11-26 10:52:45 +01:00
Félix Malfait
9f2e774113
Fix Error field type rich text ( #8739 )
...
fix #8445
It seems linked to commandBar search where we filter tasks/notes by body
with ilike.
2024-11-26 10:11:41 +01:00
Harsh Singh and Félix Malfait
a19349bdae
fix: table deselect doesn't work with few selected records ( #8692 )
...
Fixes : #8665
[Screencast from 2024-11-23
00-33-14.webm](https://github.com/user-attachments/assets/e3b86955-4e12-4d10-9c13-ee60d7695cb3 )
Co-authored-by: Félix Malfait <felix@twenty.com >
2024-11-24 17:59:49 +01:00
ad-elias
bad7ad464b
Add boolean filtering ( #7190 ) ( #8700 )
...
<img width="956" alt="filter-icp-true"
src="https://github.com/user-attachments/assets/fc5fe18d-c7b6-463d-9ce7-8e5facb7352f ">
Link to issue: https://github.com/twentyhq/twenty/issues/7190
2024-11-24 09:43:44 +01:00
Balaji Krishnamurthy
fd8e0d04a2
Fix array edit option ( #8697 )
...
Closes #8578
There was no case to handle a FieldMetadataType.Array and thus an error
was thrown every time the edit button was clicked on an Array type.
It has been added now with an explicit break statement.
2024-11-23 13:13:15 +01:00
Raphaël Bosi
f44e2935df
Fix filter multi select ( #8682 )
...
- Created a dropdown inside a dropdown for the
`ObjectFilterDropdownOperandDropdown` so the operand can be opened over
the selection with an offset
- Refactored dropdown component and introduced `DropdownUnmountEffect`
to close the dropdown when the component unmounts
- Removed old logic
Before:
<img width="216" alt="Capture d’écran 2024-11-22 à 14 03 58"
src="https://github.com/user-attachments/assets/3c1bba03-af03-4993-a070-f009b8dc876f ">
After:
<img width="222" alt="Capture d’écran 2024-11-22 à 14 03 40"
src="https://github.com/user-attachments/assets/a8a784b4-8672-4b02-bb21-e4a749682f2e ">
2024-11-22 14:08:29 +00:00
Weiko
ac9cf737fb
Fix RICH_TEXT display on cell ( #8676 )
...
## Context
We added a check of the field type in
[useTextFieldDisplay.ts](https://github.com/twentyhq/twenty/compare/c--fix-rich-text-display?expand=1#diff-8e53a2496b9faa67ac9aad3f7016efed19147557904da1bc44e895688513330d )
however this hook is also used for RICH_TEXT fields so it fails.
I'm removing this check since I don't think this is necessary, the
caller should already know its a TEXT or RICH_TEXT
2024-11-22 12:09:47 +01:00
martmull
76be1df66a
Fix array and links display ( #8671 )
...
## Before
## After
2024-11-22 12:06:31 +01:00
khuddite