Commit Graph

62 Commits

Author SHA1 Message Date
cbadcba188 FieldDisplay & FieldInput (#1708)
* Removed view field duplicate types

* wip

* wip 2

* wip 3

* Unified state for fields

* Renaming

* Wip

* Post merge

* Post post merge

* wip

* Delete unused file

* Boolean and Probability

* Finished InlineCell

* Renamed EditableCell to TableCell

* Finished double texts

* Finished MoneyField

* Fixed bug inline cell click outside

* Fixed hotkey scope

* Final fixes

* Phone

* Fix url and number input validation

* Fix

* Fix position

* wip refactor activity editor

* Fixed activity editor

---------

Co-authored-by: Charles Bochet <charles@twenty.com>
2023-09-27 18:18:02 +02:00
8639cb921e Chore: corrects syntax for type only imports (#1716)
* chore: removes replaces 'import type xxx from 'xxx'' with 'import { type xxx} from 'xxx'''

* chore: remove typed imports

* chore: remove typed imports

* chore: cleanup

---------

Co-authored-by: Lucas Bordeau <bordeau.lucas@gmail.com>
2023-09-26 11:47:35 +02:00
f777fa22e9 Create consistent ui/input and ui/display for Cell and Fields type : … (#1658)
* Create consistent ui/input and ui/display for Cell and Fields type : Probability, DoubleText, DoubleTextChip

Co-authored-by: v1b3m <vibenjamin6@gmail.com>

* Move components to `ui/input`

Co-authored-by: v1b3m <vibenjamin6@gmail.com>

* Update imports in ProbabilityEditableFieldEditMode

Co-authored-by: v1b3m <vibenjamin6@gmail.com>

* Refactor according to review

Co-authored-by: v1b3m <vibenjamin6@gmail.com>

* Create consistent ui/input and ui/display for Cell and Fields type : Probability, DoubleText, DoubleTextChip

Co-authored-by: v1b3m <vibenjamin6@gmail.com>

* Merge main

Co-authored-by: v1b3m <vibenjamin6@gmail.com>

* Add more refactors

Co-authored-by: v1b3m <vibenjamin6@gmail.com>

* Refactor according to review

Co-authored-by: v1b3m <vibenjamin6@gmail.com>

---------

Co-authored-by: v1b3m <vibenjamin6@gmail.com>
2023-09-25 11:10:14 +02:00
00a3c8ca2b Change to using arrow functions (#1603)
* Change to using arrow functions

Co-authored-by: v1b3m <vibenjamin6@gmail.com>
Co-authored-by: Matheus <matheus_benini@hotmail.com>

* Add lint rule

---------

Co-authored-by: v1b3m <vibenjamin6@gmail.com>
Co-authored-by: Matheus <matheus_benini@hotmail.com>
Co-authored-by: Charles Bochet <charles@twenty.com>
2023-09-15 18:41:10 -07:00
0a7a0ac6cb Refactor/context and scopes (#1602)
* Put onImport in a context

* Refactored RecoilScopeContexts

* Refactored naming

* Fix tests

---------

Co-authored-by: Charles Bochet <charles@twenty.com>
2023-09-15 12:51:46 -07:00
8a27fd6ca5 Fix bug opportunity new button company search 2023-09-13 21:41:48 -07:00
28e12d492c feat: toggle board field visibilities (#1547)
Closes #1537, Closes #1539
2023-09-13 11:58:52 +02:00
84b474c3cc Number display formatting (#1556)
* number display formatting

* - add tests
2023-09-13 10:12:25 +02:00
9b5e24105b Refactor/display input part 2 (#1555)
* Email - Money - Number

* Date
2023-09-12 11:04:26 -07:00
564a7c97b1 refactor: improve SingleEntitySelect empty option (#1543)
Closes #1331

Co-authored-by: Charles Bochet <charles@twenty.com>
2023-09-11 17:27:17 -07:00
a766c60aa5 Reafactor/UI input and displays (#1544)
* WIP

* Text field

* URL

* Finished PhoneInput

* Refactored input sub-folders

* Boolean

* Fix lint

* Fix lint

* Fix useOutsideClick

---------

Co-authored-by: Charles Bochet <charles@twenty.com>
2023-09-11 17:11:20 -07:00
b6eb280639 fix: POC assigning in opportunities (#1443)
* fix: opportunities-poc-select

* gql codegen

* code review changes
2023-09-10 16:08:44 -07:00
fb737e2021 Refactor icons passed as props with the new way (#1492)
* Refactor icons passed as props with the new way

Co-authored-by: v1b3m <vibenjamin6@gmail.com>
Co-authored-by: Matheus <matheus_benini@hotmail.com>

* Update more files

Co-authored-by: v1b3m <vibenjamin6@gmail.com>
Co-authored-by: Matheus <matheus_benini@hotmail.com>

* Fix according to review

* Fix according to review

* Fix according to review

* Fix chromatic regressions

---------

Co-authored-by: v1b3m <vibenjamin6@gmail.com>
Co-authored-by: Matheus <matheus_benini@hotmail.com>
Co-authored-by: Charles Bochet <charles@twenty.com>
2023-09-10 11:39:17 -07:00
28ca9a9e49 Refactor/new menu item (#1448)
* wip

* finished

* Added disabled

* Fixed disabled

* Finished cleaning

* Minor fixes from merge

* Added docs

* Added PascalCase

* Fix from review

* Fixes from merge

* Fix lint

* Fixed storybook tests
2023-09-06 16:41:26 +02:00
08b56ec7e2 fix: can't set ARR of company to empty (#1474) 2023-09-06 11:22:42 +02:00
cbcb49cd1e fix: allow null value for number and date (#1472) 2023-09-06 11:03:12 +02:00
421066c4b8 fix: Boolean editable field not align properly (#1444) 2023-09-05 09:50:23 +02:00
ae072b6ce5 refactor: index ViewField by viewId and key (#1416)
* refactor: index ViewField by viewId and key

Closes #1413

* refactor: rename ViewField properties
2023-09-04 10:55:03 +02:00
96c41563cf chore: Make a twenty Eslint Rule to make sure that icons are imported from @/ui/icons (#1370)
Fix the imports

Co-authored-by: v1b3m <vibenjamin6@gmail.com>
Co-authored-by: Mael FOSSO <fosso.mael.elvis@gmail.com>
2023-08-29 13:40:17 +02:00
74919eff7a refactor: add ColumnDefinition type (#1357)
* refactor: add ColumnDefinition type

Closes #1193

* refactor: code review - rename things

* fix: fix wrong import and lint
2023-08-28 18:33:03 +02:00
27bb3a8126 switch back editable field hover from lighter to light 2023-08-28 12:03:07 +02:00
1b187350c0 Refactor buttons (#1257)
* Refactor buttons

* Complete components creation

* Complete refactoring

* fix lint

* Complete button work
2023-08-26 23:59:45 +02:00
8a3a176571 Add idealCustomerProfile to company show page (#1312)
* Add idealCustomerProfile to company show page

* remove editMode

* add xUrl
2023-08-25 21:11:43 +02:00
67cf6cd7e2 Rework tel input (#1316)
* Rework tel input

* Fix lint
2023-08-25 20:54:00 +02:00
4f7e1fb60e Feat/phone email link enhancements (#1172)
* feat: Add type guards for ViewField email values and definitions, update ViewFieldTypes & peopleViewFields

* feat: use ContactLink for EditablePhoneCell & create EditableEmailCell & EmailInputDisplay comp

* fix: set second value for field

* enhance: add edit btn for phone cell

* feat: install dependencies intl-tel-input

* feat: add phone cell input & connect intl-tel-input

* fix: resolve rebase errors

* fix: remove placeholder

* feat(storybook): create stories for EmailInputDisplay, PhoneInputDisplay, and PhoneEditableField components

---------

Co-authored-by: Charles Bochet <charlesBochet@users.noreply.github.com>
2023-08-25 18:42:22 +02:00
baf92d6d65 Chore: New standard fields on Companies (#1276)
* New standard fields on Companies

Co-authored-by: Thiago Nascimbeni <tnascimbeni@gmail.com>
Co-authored-by: Matheus <matheus_benini@hotmail.com>

* New standard fields on Companies

Co-authored-by: v1b3m <vibenjamin6@gmail.com>
Co-authored-by: Thiago Nascimbeni <tnascimbeni@gmail.com>
Co-authored-by: Matheus <matheus_benini@hotmail.com>

* Add requested changes

Co-authored-by: Thiago Nascimbeni <tnascimbeni@gmail.com>
Co-authored-by: v1b3m <vibenjamin6@gmail.com>
Co-authored-by: Matheus <matheus_benini@hotmail.com>

* Make some fields hidden by default

Co-authored-by: Thiago Nascimbeni <tnascimbeni@gmail.com>
Co-authored-by: v1b3m <vibenjamin6@gmail.com>
Co-authored-by: Matheus <matheus_benini@hotmail.com>

* Add minor refactors

Co-authored-by: Thiago Nascimbeni <tnascimbeni@gmail.com>
Co-authored-by: v1b3m <vibenjamin6@gmail.com>
Co-authored-by: Matheus <matheus_benini@hotmail.com>

---------

Co-authored-by: Thiago Nascimbeni <tnascimbeni@gmail.com>
Co-authored-by: Matheus <matheus_benini@hotmail.com>
Co-authored-by: v1b3m <vibenjamin6@gmail.com>
2023-08-24 17:36:12 +02:00
10b68618d3 New behavior for editable fields (#1300)
* New behavior for editable fields

* fix

* fix

* fix coverage

* Add tests on NotFound

* fix

* fix

---------

Co-authored-by: Charles Bochet <charles@twenty.com>
2023-08-24 15:56:43 +02:00
76246ec880 Fix confirmation modal size (#1295) 2023-08-23 15:38:37 +02:00
22dbe21bcd Add Empty as value of empty fields inputs #1042 (#1243)
* Add Empty as value of empty fields inputs #1042

* rebase
2023-08-22 16:46:15 +02:00
9b34a0ff3d Add styled component rule (#1261)
* Add StyledComponent rule

* update doc

* update doc

* update doc
2023-08-17 20:58:02 -07:00
7d900ad1c6 Reorganize context/states/selectors in dedicated folders (#1205)
* Reorganize context/states/selectors in dedicated folders

* linter
2023-08-14 15:08:47 -07:00
bf09a4d6a2 Improve editable field performances (#1182)
* [EditableField] improve performances

* remove FieldHotkeyScopeContext.ts
2023-08-12 17:27:02 -07:00
09ab1300a3 Remove unused components (#1180)
* Remove unused components

* Fix company not being created issue

* Fix company not being created issue

* Fix company not being created issue

* Optimize rendering

* Optimize rendering
2023-08-12 16:29:18 -07:00
a30222fe76 [PersonShow] use fieldDefinition for editable fields (#1178)
* [PersonShow] use fieldDefinition for editable fields

* remove unused files

* fix company chip display field
2023-08-12 01:36:38 +02:00
4eb4d1488c Use FieldDefinition for company show page (#1171)
* Use FieldDefinition for company show page

* removing console.log

* fix conflicts

* fix address placeholder + company show page field definition ordering

* fix story

* add replacePlaceholder

* use AppPath enum in stories

* add routeParams

* fix people input story
2023-08-11 14:31:52 -07:00
4288cef096 refactoring editableFieldContext to match with table implementation (#1164) 2023-08-10 12:26:05 -07:00
07a8f68ef1 Add FieldDefinition (#1162)
* add fieldDefinition

* update naming

* use a unique contextProvider for editable fields

* remove EntityUpdateMutationHookContext.Provider usage in CompanyBoardCard

* add fieldDefinitionState

* remove unnecessary refetchQueries to avoid re-render

* add FieldMetadata

* add type guards and update useUpdateGenericEntityField

* restore refetchQueries
2023-08-10 11:26:27 -07:00
ecf18312ce Fix typing issue with positive number 2023-08-09 22:40:49 -07:00
4717f4cb90 fix(882): fixes negative number submission for employees input (#1130)
* fix(882): fixes negative number submission for employees input

* formatting

* fix linting
2023-08-09 22:25:57 -07:00
a2891e50e6 [opportunities] fix poc being removed after pipeline update (#1148) 2023-08-10 02:52:36 +02:00
cd831af53d Use dedicated EditableFieldEntityIdContext for editable fields instead of CardIds (#1145)
* Use dedicated EntityIdContext for editable fields instead of CardIds

* update context name

* remove unused hook
2023-08-10 01:32:28 +02:00
702b6e5154 fix update pipelineProgress with 0 probability (#1144) 2023-08-09 20:01:44 +02:00
3666980ccc Feat/generic editable board card (#1089)
* Fixed BoardColumnMenu

* Fixed naming

* Optimized board loading

* Added GenericEditableField

* Introduce GenericEditableField for BoardCards

* remove logs

* delete unused files

* fix stories

---------

Co-authored-by: corentin <corentin@twenty.com>
2023-08-08 20:08:37 -07:00
7028a8098e style(urls): Updated link style to round chips (#1010)
* style(urls): Updated link style to round chips

* restored RawLink changes

* feat:(rounded): introduced newchip varient rounded

* feat(rounded-link): added rounded link component
2023-08-05 11:50:59 -07:00
2b21e05524 Improve mouse tracking (#1061)
* Improve mouse tracking

* Fix lint

* Fix regression on Filters

* Fix according to review
2023-08-03 10:36:11 -07:00
ade5e52e55 Clean and re-organize post table refactoring (#1000)
* Clean and re-organize post table refactoring

* Fix tests
2023-07-30 18:26:32 -07:00
fc7380e0b8 Add ability to properly cast a string, number, null to an integer (#990) 2023-07-29 21:06:03 -07:00
8601ed04ae Add dueDate and assignee on notes (#988)
* Add dueDate and assignee on notes

* Fix tests

* Fix tests
2023-07-29 15:36:21 -07:00
b52745533a Added unused imports and vars and fixed lint (#929) 2023-07-25 17:18:25 -07:00
07180af8c0 Improve tests (#871) 2023-07-24 00:57:56 -07:00