Félix Malfait
ebc381f009
Small text improvement to number field type ( #8816 )
...
Micro improvement to the number field type text
2024-11-29 18:06:00 +01:00
ad-elias and Marie Stoppa
2e75fae3ad
Allow standard field default value and settings editing ( #7104 ) ( #8559 )
...
Co-authored-by: Marie Stoppa <marie.stoppa@essec.edu >
2024-11-26 10:03:48 +01:00
Guillim and guillim
cb5a0c1cc6
fix-percentage ( #8684 )
...
Following previous release, a suggestion was noticed by @martmull . Here
is a suggested fix.
Before :

After :
<img width="611" alt="Screenshot 2024-11-22 at 14 56 07"
src="https://github.com/user-attachments/assets/67298633-4513-41a4-90aa-5e2366d3cd88 ">
---------
Co-authored-by: guillim <guillaume@twenty.com >
2024-11-22 14:20:37 +00:00
Guillim and guillim
4a8234d18c
Feature 7552 patch ( #8574 )
...
Related to #7552
<img width="556" alt="Screenshot 2024-11-18 at 17 57 30"
src="https://github.com/user-attachments/assets/e89e575b-9adb-4910-ab0d-b60079727f70 ">
---------
Co-authored-by: guillim <guillaume@twenty.com >
2024-11-19 12:47:33 +01:00
Guillim and guillim
2f3c41620c
Wrap Long text fields (textarea) ( #8557 )
...
Here we add the option for Text inputs to be wrapped, and to select on
how many lines text should be displayed.
Fix #7552
---------
Co-authored-by: guillim <guillaume@twenty.com >
2024-11-18 17:36:19 +01:00
nitin and Charles Bochet
2f5dc26545
Settings Option Card component ( #8456 )
...
fixes - #8195
---------
Co-authored-by: Charles Bochet <charles@twenty.com >
2024-11-18 09:22:33 +00:00
Ketan Mehta and Félix Malfait
51c54d4c5b
validation on Select field ( #8316 )
...
fix #8204
I changed "API keys" to "API values".
Stopped inputting special characters in Select field option keys.
@lucasbordeau please check the changes and tell me if I need to do any
other changes. :)
---------
Co-authored-by: Félix Malfait <felix@twenty.com >
2024-11-14 17:46:18 +01:00
Guillim and guillim
15b8b9b158
Feature : Adding percentage option to Input Number ( #8481 )
...
fixing #7375
---------
Co-authored-by: guillim <guillaume@twenty.com >
2024-11-14 14:23:25 +01:00
6264d509bd
Migrate to twenty-ui - navigation/menu-item ( #8213 )
...
This PR was created by [GitStart](https://gitstart.com/ ) to address the
requirements from this ticket:
[TWNTY-7536](https://clients.gitstart.com/twenty/5449/tickets/TWNTY-7536 ).
---
### Description
Migrate all menu items components to twenty ui and update imports.
```typescript
MenuItem
MenuItemAvata
MenuItemCommand
MenuItemCommandHotKeys
MenuItemDraggable
MenuItemMultiSelect
MenuItemMultiSelectAvatar
MenuItemMultiSelectTag
MenuItemNavigate
MenuItemSelect
MenuItemSelectAvatar
MenuItemSelectColor
MenuItemSelectTag
MenuItemSuggestion
MenuItemToggle
```
\
Also migrate all other dependent components and utilities like
`Checkbox` & `Toggle`\
\
Fixes twentyhq/private-issues#82
---------
Co-authored-by: gitstart-twenty <gitstart-twenty@users.noreply.github.com >
Co-authored-by: gitstart-twenty <140154534+gitstart-twenty@users.noreply.github.com >
Co-authored-by: Lucas Bordeau <bordeau.lucas@gmail.com >
2024-11-07 16:51:39 +00:00
Thomas Trompette
74291e531c
Fix storybook tests ( #8260 )
...
Before
<img width="717" alt="Capture d’écran 2024-10-31 à 16 58 34"
src="https://github.com/user-attachments/assets/b8ec61f3-11c2-497f-9e4f-183b7989fb59 ">
After
<img width="717" alt="Capture d’écran 2024-10-31 à 16 58 14"
src="https://github.com/user-attachments/assets/8e0a1fbf-19c4-4cd0-ab7b-58ebb5ded1f5 ">
Before
<img width="586" alt="Capture d’écran 2024-10-31 à 16 57 59"
src="https://github.com/user-attachments/assets/eb6caf91-3953-4a8f-a847-17a50cc40d02 ">
After
<img width="586" alt="Capture d’écran 2024-10-31 à 16 57 29"
src="https://github.com/user-attachments/assets/9eee3502-66b4-41c9-a924-b5d3ddb921e3 ">
2024-10-31 17:19:44 +01:00
Thomas Trompette
f5bde0251b
Put back object type in settings form ( #8234 )
...
Before
<img width="673" alt="Capture d’écran 2024-10-31 à 11 15 27"
src="https://github.com/user-attachments/assets/78d81f5b-88c0-40b7-8901-104365ecdd49 ">
After
<img width="673" alt="Capture d’écran 2024-10-31 à 11 15 07"
src="https://github.com/user-attachments/assets/9427da22-a75b-4257-b948-28807b110b26 ">
2024-10-31 10:27:54 +00:00
Igor Kowalski
3ae987be92
folderStructure.json refactor ( #8088 )
...
#7911
If you encounter any issues or have any questions regarding the library,
feel free to write
[here](https://github.com/Igorkowalski94/eslint-plugin-project-structure/discussions/new?category=help ),
I’d be happy to help.
2024-10-28 12:06:58 +01:00
1dfeba39eb
Migrate to twenty-ui - layout/card ( #8003 )
...
This PR was created by [GitStart](https://gitstart.com/ ) to address the
requirements from this ticket:
[TWNTY-7532](https://clients.gitstart.com/twenty/5449/tickets/TWNTY-7532 ).
---
### Description
Migrate:
- Card
- CardContent
- CardFooter
- CardHeader
### Demo
Card in Storybook

###### Fixes twentyhq/private-issues#86
---------
Co-authored-by: gitstart-twenty <gitstart-twenty@users.noreply.github.com >
Co-authored-by: Charles Bochet <charles@twenty.com >
2024-10-24 16:36:06 +02:00
0a28c15747
Migrate to twenty-ui - input/button ( #7994 )
...
This PR was created by [GitStart](https://gitstart.com/ ) to address the
requirements from this ticket:
[TWNTY-7529](https://clients.gitstart.com/twenty/5449/tickets/TWNTY-7529 ).
---
### Description
- Migrated all button components to `twenty-ui` \
\
`Button`\
`ButtonGroup`\
`ColorPickerButton`\
`FloatingButton`\
`FloatingButtonGroup`\
`FloatingIconButton`\
`FloatingIconButtonGroup`\
`IconButton`\
`IconButtonGroup`\
`LightButton`\
`LightIconButton`\
`LightIconButtonGroup`\
`MainButton`\
\
Fixes twentyhq/private-issues#89
Co-authored-by: gitstart-twenty <gitstart-twenty@users.noreply.github.com >
Co-authored-by: Charles Bochet <charles@twenty.com >
2024-10-24 13:20:02 +02:00
430644448a
Migrate to twenty-ui - navigation/link ( #7837 )
...
This PR was created by [GitStart](https://gitstart.com/ ) to address the
requirements from this ticket:
[TWNTY-7535](https://clients.gitstart.com/twenty/5449/tickets/TWNTY-7535 ).
---
### Description.
Migrate link components to `twenty-ui` \
\
Fixes #7535
---------
Co-authored-by: gitstart-twenty <gitstart-twenty@users.noreply.github.com >
Co-authored-by: gitstart-twenty <140154534+gitstart-twenty@users.noreply.github.com >
Co-authored-by: Charles Bochet <charles@twenty.com >
2024-10-22 17:36:26 +02:00
Charles Bochet
eccf0bf8ba
Enforce front project structure through ESLINT ( #7863 )
...
Fixes: https://github.com/twentyhq/twenty/issues/7329
2024-10-20 20:20:19 +02:00
Syed Hamza Hussain and Charles Bochet
6f5dc1c924
Bug Fix: created new div and p tag styles and wrap it on the workspace member as container ( #7581 )
...
Hello,
Hope you are doing well.I created a special style for the text to make
sure it stays in one line and wont exceed the width if the text width
will be more then 80px it will ecplise and set ... at the end of the
text.
I created these 2 styles variables and wrap my text in these styles
StyledObjectSummary
StyledEllipsisParagraph
Fixes #7574
#Screens Shots
<img width="1268" alt="Screenshot 2024-10-10 at 10 58 04 PM"
src="https://github.com/user-attachments/assets/2d3ef2c5-c4c8-489b-a205-50a48b986d60 ">
<img width="530" alt="Screenshot 2024-10-10 at 10 58 20 PM"
src="https://github.com/user-attachments/assets/e0d1cb48-dbc9-427a-99ac-54269c574360 ">
---------
Co-authored-by: Charles Bochet <charles@twenty.com >
2024-10-17 23:55:50 +02:00
nitin and Lucas Bordeau
d350143c92
Fix field forms ( #7595 )
...
@lucasbordeau
forms are broken!
revert - #7363
used useRelationSettingsFormInitialValues hook from that commit.
TODO - figure out a way to change the relation name label from singular
to plural and vice versa, until it is edited.
related issue - #7355
---------
Co-authored-by: Lucas Bordeau <bordeau.lucas@gmail.com >
2024-10-11 19:07:56 +02:00
Thomas Trompette
c91a8c6abf
Check if relation before trying to input relation label ( #7605 )
...
Bug introduced by https://github.com/twentyhq/twenty/pull/7363
Input value was not set during edition for field that were not relations
Fixed
<img width="893" alt="Capture d’écran 2024-10-11 à 16 53 56"
src="https://github.com/user-attachments/assets/511077c6-5dff-49a1-b058-24a83d998dcf ">
2024-10-11 17:11:11 +02:00
7ceaa879fe
Avanced Settings: Custom API names for Select & Multi-Select Keys ( #7489 )
...
### Description
- text input was changed because it renders an empty div as the right
icon, but the margin and padding affect the layout
- we have duplicated code on ExpandedWidthAnimationVariants.ts, because
of an eslint rule that prevents more than one const definition, can we
ignore the rule?
-
### Demo
<https://www.loom.com/share/17a37bf5549a4a23ba12343b6046ec6b?sid=4cf297f3-66db-44c9-9a9b-7bde89b90d02 >
### Refs
<https://github.com/twentyhq/twenty/issues/6146 >
---------
Co-authored-by: gitstart-twenty <gitstart-twenty@users.noreply.github.com >
Co-authored-by: gitstart-twenty <140154534+gitstart-twenty@users.noreply.github.com >
Co-authored-by: Marie Stoppa <marie.stoppa@essec.edu >
2024-10-11 10:34:31 +02:00
Charles Bochet
a58236e6da
Remove deprecated EMAIL, PHONE, LINK ( #7551 )
...
In this PR:
- remove deprecated EMAIL, PHONE, LINK field types (except for Zapier
package as there is another work ongoing)
- remove composite currency filter on currencyCode, actor filter on name
and workspaceMember as the UX is not great yet
2024-10-10 14:14:58 +02:00
e45e45d8b2
Prefill Relation Fields with Initiating Object Icon and Name ( #7363 )
...
feat: #7355
Behaviour implemented:
1. Relation field name field is updated when relation type is updated
2. Icon is only prefilled in the beginning
3. If user manually edits the field name, then no subsequent updates are
made to that field upon relation type change.
https://github.com/user-attachments/assets/d372b106-8dcb-458d-8374-a76cd130f091
---------
Co-authored-by: sid0-0 <a@b.com >
Co-authored-by: Lucas Bordeau <bordeau.lucas@gmail.com >
2024-10-10 08:29:37 +02:00
nitin and Félix Malfait
c57d8f1346
Breadcrumb DropDown improvement ( #7546 )
...
context -
https://github.com/twentyhq/twenty/pull/7397#pullrequestreview-2356581785
P.S. Apologies for the background music in the screen recording—I didn’t
realize my mic was on while capturing it. 😅
https://github.com/user-attachments/assets/0cd31aa7-9ce2-4577-a79a-73c9890f2905
---------
Co-authored-by: Félix Malfait <felix@twenty.com >
2024-10-09 22:04:56 +02:00
NitinPSingh
855060a308
fix #7486 enable save button on adding options in select/multiselect ( #7495 )
...
issue : #7486
demo
https://github.com/user-attachments/assets/0b1ed9de-2aa1-4910-bfc7-01732b89367f
2024-10-09 19:39:52 +02:00
nitin
58cbcbfe70
Remove step 1 of new object field ( #7397 )
...
fixes #7356
fixes #6967
fixes #7102
fixes #7121
fixes #7505
2024-10-09 11:24:49 +02:00
Pacifique LINJANJA and Lucas Bordeau
4156d7821c
Ability to filter by composite's subfields ( #6832 )
...
# This PR
- Fix #6425
See https://github.com/twentyhq/twenty/issues/7188 because there's some
more work to do.
---------
Co-authored-by: Lucas Bordeau <bordeau.lucas@gmail.com >
2024-10-08 11:25:42 +02:00
Ngan Phan and Lucas Bordeau
2bc7974da9
fix: Improve Usability of Adding Options via Return Key for Multi-Select Field ( #7450 )
...
Fixes #6602
This is the approach that I followed based on these comments
https://github.com/twentyhq/twenty/issues/6602#issuecomment-2356870311 ,
https://github.com/twentyhq/twenty/issues/6602#issuecomment-2330737907
- Create forward ref in `<TextInput>` component
- Create ref to select text in parent component
`<SettingsDataModelFieldSelectFormOptionRow>` and pass it to
`<TextInput>`
---------
Co-authored-by: Lucas Bordeau <bordeau.lucas@gmail.com >
2024-10-07 13:06:51 +02:00
Charles Bochet
d8c4af9279
Fix all broken CIs ( #7439 )
...
Fix all the broken CIs :p
This includes an ongoing effort to simplify test maintenance by having 1
unique source of truth about metadata and data mocks (that will later be
generated from a unique source of seeds: dev = demo = test)
Regressions:
- Unit line coverage: 60 > 55
- Storybook Pages branch coverage: 40 > 35
We will need to write tests to increase those coverage
- RelationFieldDisplay perf: 0.2ms to 0.22ms > We might have a
regression here
- Removed perf story about RawJSON > We will need to re-add it
2024-10-05 00:23:23 +02:00
424c4890b0
fix: New Relation Design hot fix ( #7423 )
...
## Description
- This PR solves the issue #7353
- [x] Improved layout for mobile and desktop
- [ ] Added tooltip on hover
---------
Co-authored-by: Nitin Koche <nitinkoche03@gmail.com >
Co-authored-by: Félix Malfait <felix@twenty.com >
2024-10-04 16:38:15 +02:00
97eff774bd
Allow input and display of floats for Number fields ( #7340 )
...
### Description
- We added a decimal field for a Number Field type in the settings
- We updated the Number Field type create a form with decimals input
- We are not implementing the dropdown present on the Figma because it
seems not related
### Demo
<https://www.loom.com/share/18a8d4b712a14f6d8b66806764f8467f?sid=3fc79b46-ae32-46e3-8635-d0eee02e53b2 >
Fixes #6987
---------
Co-authored-by: gitstart-twenty <gitstart-twenty@users.noreply.github.com >
Co-authored-by: Marie Stoppa <marie.stoppa@essec.edu >
2024-10-04 10:45:25 +02:00
nitin and Félix Malfait
e3ed574420
minor fix - reset single entity search ( #7420 )
...
minor follow up fix #7285
---------
Co-authored-by: Félix Malfait <felix@twenty.com >
2024-10-03 22:31:03 +02:00
Harshit Singh and Félix Malfait
3cd24d542b
Resolved Typescript console errors ( #7408 )
...
## Description
- This PR addresses the issues-
- #7404
- #7359
- and builds on the existing logic from PR #7360
- Handled the 4 Ts console errors
---------
Co-authored-by: Félix Malfait <felix@twenty.com >
2024-10-03 12:02:51 +02:00
Harshit Singh
75b493ba6c
fix: Values field card lacks width in mobile viewports ( #7248 )
...
## Description
- This PR fixes the issue #7230
## Current Behaviour
<img width="411" alt="Screenshot 2024-09-24 at 9 51 42 AM"
src="https://github.com/user-attachments/assets/65d283b8-24fa-4e25-b3bd-2e35efabf768 ">
## After
<img width="556" alt="Screenshot 2024-09-25 at 10 38 40 AM"
src="https://github.com/user-attachments/assets/97a32497-4230-438f-b048-707bdcd9b674 ">
<img width="578" alt="Screenshot 2024-09-25 at 10 38 52 AM"
src="https://github.com/user-attachments/assets/74e7d055-96fc-4bf4-bddc-e84cf03a6599 ">
2024-09-25 17:56:47 +02:00
092496f2db
'Display as relative date' field formatting option for dateTime and date fields #5398 ( #6945 )
...
Implements #5398 .
---------
Co-authored-by: Lucas Bordeau <bordeau.lucas@gmail.com >
Co-authored-by: Félix Malfait <felix@twenty.com >
2024-09-25 11:42:16 +02:00
Ana Sofia Marin Alexandre
cac3e116a3
Add SettingsCard for Config Data Type and Accounts Settings ( #7093 )
...
https://github.com/twentyhq/twenty/issues/6950
Add new Settings Card for Config Data Type and accounts Settings
Before:
<img width="707" alt="Screenshot 2024-09-11 at 17 43 16"
src="https://github.com/user-attachments/assets/63ff9373-fa86-4b22-8e8b-21483039c3be ">
After:
<img width="755" alt="Screenshot 2024-09-17 at 14 15 18"
src="https://github.com/user-attachments/assets/213c24a1-dc1c-4ffb-8890-7c1f63ed376c ">
<img width="755" alt="Screenshot 2024-09-17 at 14 15 38"
src="https://github.com/user-attachments/assets/0fc12d19-b92a-493d-80fa-0064cf491fbc ">
2024-09-18 18:32:41 +02:00
8208a3e976
Introduce ARRAY field type ( #6862 )
...
This PR was created by \[GitStart\](<https://gitstart.com/ >) to address
the requirements from this ticket:
\[TWNTY-6447\](<https://clients.gitstart.com/twenty/5449/tickets/TWNTY-6447 >).
This ticket was imported from:
<https://github.com/twentyhq/twenty/issues/6447 >
### Description
\- We added a new field type
### Refs
#6447
### Demo
<https://jam.dev/c/2b4d7853-ea89-4e9d-a561-6edcb4fdb34b >
Fixes #6447
---------
Co-authored-by: gitstart-twenty <gitstart-twenty@users.noreply.github.com >
Co-authored-by: Charles Bochet <charles@twenty.com >
2024-09-16 14:07:55 +02:00
Charles Bochet
523df5398a
Optimize metadata queries ( #7013 )
...
In this PR:
1. Refactor guards to avoid duplicated queries: WorkspaceAuthGuard and
UserAuthGuard only check for existence of workspace and user in the
request without querying the database
2024-09-13 19:42:22 +02:00
gitstart-app[bot] and gitstart-twenty
846953b0f4
Support for multiple values in the Phone field ( #6882 )
...
### Description
- This is the first PR on Phones field;
- We are introducing new field type(Phones)
- We are Forbidding creation of Phone field
- We Added support for filtering and sorting on Phones field
- We are using the same display mode as used on the Links field type
(chips), check the Domain field of the Company object
- We are also using the same logic of the link when editing the field
**How to Test**
1. Checkout to TWNTY-6260 branch
2. Reset database using "npx nx database:reset twenty-server" command
3. Add custom field of type Phones in settings/data-model
**Loom Video:**\
<https://www.loom.com/share/3c981260be254dcf851256d020a20ab0?sid=58507361-3a3b-452c-9de8-b5b1abda70ac >
### Refs
#6260
Co-authored-by: gitstart-twenty <gitstart-twenty@users.noreply.github.com >
2024-09-11 11:15:04 +02:00
79aba75649
Added new view to select types for objects ( #6700 )
...
Issue #6496
Hi team,
Is this the right approach for handling type selection with states and
conditional rendering, or should these be managed on separate pages
altogether? Please let me know Ill make changes accordingly :)
I’m also working on styling the buttons according to the Figma design
and will be moving constants like categoryDescriptions and categories to
the constants folder.
Thanks for your guidance!
https://github.com/user-attachments/assets/452bea9f-4d0a-4472-9941-421b54cda47f
---------
Co-authored-by: Lucas Bordeau <bordeau.lucas@gmail.com >
Co-authored-by: Charles Bochet <charles@twenty.com >
2024-09-06 22:47:40 +02:00
gitstart-app[bot] and gitstart-twenty
7a9a43b85c
Add composite Emails field and forbid creation of Email field type ( #6689 )
...
### Description
1.
- We are introducing new field type(Emails)
- We are Forbiding creation of Email field
- We Added support for filtering and sorting on Emails field
- We are using the same display mode as used on the Links field type
(chips), check the Domain field of the Company object
- We are also using the same logic of the link when editing the field
\
How To Test\
Follow the below steps for testing locally:\
1. Checkout to TWENTY-6261\
2. Reset database using "npx nx database:reset twenty-server" command\
3. Run both the backend and frontend app\
4. Go to Settings/Data model and choose one of the standard objects like
people\
5. Click on Add Field button and choose Emails as the field type
\
### Refs
#6261\
\
### Demo
\
<https://www.loom.com/share/22979acac8134ed390fef93cc56fe07c?sid=adafba94-840d-4f01-872c-dc9ec256d987 >
Co-authored-by: gitstart-twenty <gitstart-twenty@users.noreply.github.com >
2024-08-29 11:42:24 +02:00
55685d3c5b
Fix currency field edition form ( #6723 )
...
This PR was created by [GitStart](https://gitstart.com/ ) to address the
requirements from this ticket:
[TWNTY-6692](https://clients.gitstart.com/twenty/5449/tickets/TWNTY-6692 ).
This ticket was imported from:
[TWNTY-6692](https://github.com/twentyhq/twenty/issues/6692 )
---
### Description
The problem is not related to the API, what was happening was a failure
in the form validation, because in the changed file, the `currencyCode`
value, which should be a string with single quotes around it, was
receiving single quotes again, unnecessarily, and this affected field
validation in
`packages/twenty-front/src/modules/object-record/record-field/validation-schemas/currencyFieldDefaultValueSchema.ts`
please, make this change below before testing the PR(to fix a bug, the
slice is not updated yet):\
<https://github.com/twentyhq/twenty/commit/aa4ae53fb497d292f9b2319012482b942cbecfa5 >
### Demo
<https://www.loom.com/share/2ce130f2e2fe46868e9b1e9119f65cde?sid=dbcb2da2-3641-423c-bdfc-01b0fc52162a >
### Refs
#6692
Fixes #6692
---------
Co-authored-by: gitstart-twenty <gitstart-twenty@users.noreply.github.com >
Co-authored-by: Marie Stoppa <marie.stoppa@essec.edu >
2024-08-26 15:02:12 +02:00
Marie
981f311ed0
Fix addition of new option in select field if there are no existing options ( #6718 )
...
Fixes
[sentry](https://twenty-v7.sentry.io/issues/5745628875/?alert_rule_id=15135099&alert_type=issue¬ification_uuid=95108411-b431-4abd-bdd6-687c96a7353e&project=4507072563183616&referrer=discord )
2024-08-23 12:13:49 +02:00
Lucas Bordeau
3ae89d15de
Fix post merge ( #6699 )
...
Fixed settingsPreviewRecordId state naming.
2024-08-20 16:45:00 +02:00
Thomas Trompette
39512a779e
Fix storybook tests ( #6594 )
...
As title
2024-08-09 19:39:16 +02:00
Faisal-imtiyaz123 and Félix Malfait
b4e2ada3b0
Fixes Empty Label Identifer Preview in Settings/DataModel/Object/Edit ( #6370 )
...
fixes #6143
---------
Co-authored-by: Félix Malfait <felix.malfait@gmail.com >
2024-08-08 18:30:02 +02:00
Thomas Trompette
74229a80c8
Fix broken tests batch 2 ( #6573 )
...
As title
2024-08-08 11:16:59 +02:00
nitin and Félix Malfait
a7941315e7
Replace entityId by recordId in the front end. ( #6355 )
...
Hey @lucasbordeau, I replaced every `entityId` with `recordId` in the
frontend.
### Some clarifications:
1. At [this
line](https://github.com/ehconitin/twenty/commit/0b207d26b6e78da349af34cf44585d89cb59adb7#diff-b4f415dd1f060307ad61f64394ee96b2912f6015e26c7fd2eab4b8c6a84d2d07L14 ),
I changed `recordId` to `selectedRecordId` because that component has
`entityId` defined in code at [this
line](https://github.com/ehconitin/twenty/commit/0b207d26b6e78da349af34cf44585d89cb59adb7#diff-b4f415dd1f060307ad61f64394ee96b2912f6015e26c7fd2eab4b8c6a84d2d07L55 )
which was to be changed to `recordId`. To avoid repeated constants, I
changed the arguments to `selectedRecordIds`.
2. At the following links:
- [File
1](https://github.com/ehconitin/twenty/commit/0b207d26b6e78da349af34cf44585d89cb59adb7#diff-52b780bdd4cfc582ca7e1b457dbbd63733bfbb7790fc421054bbd2dbf0389e16 )
- [File
2](https://github.com/ehconitin/twenty/commit/0b207d26b6e78da349af34cf44585d89cb59adb7#diff-6d47cb9a59dfcf6b1495937084ae799a61da6afccb21208f04ce8e1f5afca0e4 )
- [File
3](https://github.com/ehconitin/twenty/commit/0b207d26b6e78da349af34cf44585d89cb59adb7#diff-821815783f9968f1da3cd437fc9d1d1666d12dc331d279cc5fbd9817bc2df2bf )
It seems to be the tests. As I can see, it is checking for both
`objectFilterDropdownSelectedEntityIdState` and
`objectFilterDropdownSelectedRecordIdsState`. Since `entityIds` are
supposed to be removed and `recordedId` state is already being checked,
I commented out all the `entityidState` code. If they are to be removed
or uncommented, please let me know, and I will do as expected.
---------
Co-authored-by: Félix Malfait <felix.malfait@gmail.com >
2024-08-07 08:52:57 +02:00
Charles Bochet
8373dfdc26
Webhook wip ( #6371 )
...
This PR introduces the following changes:
- Add the ability to filter webhooks by objectSingularName and Actions
- Refactor SettingsWebhookDetails edition to not use react-hook-form
(which will be deprecated on the whole project)
- Updating the tests with a complex set of mock (we just need to fix ~30
of them now :D)
<img width="1053" alt="image"
src="https://github.com/user-attachments/assets/4e56d972-f129-4789-8d1c-4b5797a8ffd7 ">
2024-08-05 23:14:29 +02:00
Marie and Charles Bochet
6e0c1b4c73
Fallback to default value when migrating value from enum ( #6517 )
...
When migrating the option values of a select type, if the field is non
nullable (for now, only available for opportunity's "stage" standard
field), we fallback to the (potentially updated) default value instead
of nullifying the value to avoid getting a database error.
---------
Co-authored-by: Charles Bochet <charles@twenty.com >
2024-08-03 17:53:01 +02:00
Félix Malfait
5f88caf409
Refacto default value ( #6507 )
...
A quick followup of #6506 to add clarity and differentiate emptyValue
from defaultValue
2024-08-03 16:43:53 +02:00