183dc40916
# Introduction
Lately encountering a lot of out of memory error when running
twenty-front in watch mode with both TypeScript and lint checkers
```ts
Error: Worker terminated due to reaching memory limit: JS heap out of memory
at new NodeError (node:internal/errors:405:5)
at [kOnExit] (node:internal/worker:287:26)
at Worker.<computed>.onexit (node:internal/worker:209:20)
```
The existing configuration looks like this:
```ts
// packages/twenty-front/vite.config.ts
'cd ../.. && eslint packages/twenty-front --report-unused-disable-directives --max-warnings 0 --config .eslintrc.cjs',
```
This is wrong as computing the root eslintrc completely omitting
twenty-front's one ***and its ignorePattern*** so will be checking in
`node_modules` etc checking for project-structure :).
For example this a
[snippet](https://gist.github.com/prastoin/d7f8ad4ef5eb2f7732209b756a38094c)
of the above commands errors. We can see rule that should be disabled by
`eslintrc.react.cjs` extension made from twenty-front `eslintrc` :
```ts
/Users/paulrastoin/ws/twenty-two/packages/twenty-front/src/modules/settings/data-model/fields/forms/components/__stories__/SettingsDataModelFieldSettingsFormCard.stories.tsx
23:27 warning Forbidden non-null assertion @typescript-eslint/no-non-null-assertion
```
## Fixes
- consume the `twenty-front` package eslint configuration within the
vite lint checker
- eslint overrides extends are getting merged based on glob inclusion of
their files declarations
- any linted files should be included in one of our `tsconfig`
- removed redundant and counter-productive negative `ignorePatterns`, as
eslint will naturally only lint files within configuration file
directory by default which will result making it go through local
`node_modules` project structure
## Now
Less cpu usage <3.5 gb and faster
```ts
// from packages/twenty-front
TIMING=1 npx eslint . --report-unused-disable-directives --max-warnings 0 --config .eslintrc.cjs --debug
#...
Rule | Time (ms) | Relative
:-----------------------------------------------|----------:|--------:
project-structure/folder-structure | 19578.927 | 20.2%
prettier/prettier | 13746.156 | 14.2%
no-redeclare | 9546.570 | 9.9%
@nx/workspace-explicit-boolean-predicates-in-if | 8167.805 | 8.4%
@typescript-eslint/no-unused-vars | 6872.803 | 7.1%
import/no-relative-packages | 6577.273 | 6.8%
@nx/enforce-module-boundaries | 6520.945 | 6.7%
import/no-duplicates | 4987.476 | 5.2%
react/no-direct-mutation-state | 2323.082 | 2.4%
react/require-render-return | 1155.261 | 1.2%
```
## Conclusion
Please note that `nx linter` might not be as strict as vite config
eslint runner
---------
Co-authored-by: Charles Bochet <charlesBochet@users.noreply.github.com>
88 lines
2.2 KiB
JavaScript
88 lines
2.2 KiB
JavaScript
const path = require('path');
|
|
|
|
module.exports = {
|
|
extends: ['../../.eslintrc.global.cjs', '../../.eslintrc.react.cjs'],
|
|
ignorePatterns: [
|
|
'node_modules',
|
|
'mockServiceWorker.js',
|
|
'**/generated*/*',
|
|
'**/generated/standard-metadata-query-result.ts',
|
|
'tsup.config.ts',
|
|
'build',
|
|
'coverage',
|
|
'storybook-static',
|
|
'**/*config.js',
|
|
'codegen*',
|
|
'tsup.ui.index.tsx',
|
|
'__mocks__',
|
|
],
|
|
overrides: [
|
|
{
|
|
files: ['**/*.ts', '**/*.tsx'],
|
|
parserOptions: {
|
|
project: ['packages/twenty-front/tsconfig.*.json'],
|
|
},
|
|
plugins: ['project-structure'],
|
|
settings: {
|
|
'project-structure/folder-structure-config-path': path.join(
|
|
__dirname,
|
|
'folderStructure.json',
|
|
),
|
|
},
|
|
rules: {
|
|
'project-structure/folder-structure': 'error',
|
|
/*
|
|
Uncomment this rule when we have a way to work on
|
|
'lingui/no-unlocalized-strings': [
|
|
'error',
|
|
{
|
|
ignore: [
|
|
'^(?![A-Z])\\S+$',
|
|
'^[A-Z0-9_-]+$'
|
|
],
|
|
ignoreNames: [
|
|
{ regex: { pattern: 'className', flags: 'i' } },
|
|
{ regex: { pattern: '^[A-Z0-9_-]+$' } },
|
|
'styleName',
|
|
'src',
|
|
'srcSet',
|
|
'type',
|
|
'id',
|
|
'width',
|
|
'height',
|
|
'displayName',
|
|
'Authorization'
|
|
],
|
|
ignoreFunctions: [
|
|
'cva',
|
|
'cn',
|
|
'track',
|
|
'Error',
|
|
'console.*',
|
|
'*headers.set',
|
|
'*.addEventListener',
|
|
'*.removeEventListener',
|
|
'*.postMessage',
|
|
'*.getElementById',
|
|
'*.dispatch',
|
|
'*.commit',
|
|
'*.includes',
|
|
'*.indexOf',
|
|
'*.endsWith',
|
|
'*.startsWith',
|
|
'require'
|
|
],
|
|
useTsTypes: true,
|
|
ignoreMethodsOnTypes: [
|
|
'Map.get',
|
|
'Map.has',
|
|
'Set.has'
|
|
]
|
|
}
|
|
]
|
|
*/
|
|
},
|
|
},
|
|
],
|
|
};
|