This PR aims at improving readability in sentry and user experience with runtime errors. **GraphQL errors (and ApolloError)** 1. In sentry we have a lot of "Object captured as exception with keys: extensions, message" errors (2k over the last 90d), on which we have zero information. This is because in apollo-factory we were passing on GraphQL errors to sentry directly why sentry expects the structure of a JS Error. We are now changing that, rebuilding an Error object and attempting to help grouping by creating a fingerPrint based on error code and truncated operationName (same as we do in the back for 500 graphql errors). 2. In sentry we have a lot of ApolloError, who actually correspond to errors that should not be logged in sentry (Forbidden errors such as "Email is not verified"), or errors that are already tracked by back-end (Postgres errors such as "column xxx does not exist"). This is because ApolloErrors become unhandled rejections errors if they are not caught and automatically sent to sentry through the basic config. To change that we are now filtering out ApolloErrors created from GraphQL Errors before sending error to sentry: <img width="524" alt="image" src="https://github.com/user-attachments/assets/02974829-26d9-4a9e-8c4c-cfe70155e4ab" /> **Runtime errors** 4. Runtime errors were all caught by sentry with the name "Error", making them not easy to differentiate on sentry (they were not grouped together but all appeared in the list as "Error"). We are replacing the "Error" name with the error message, or the error code if present. We are introducing a CustomError class that allows errors whose message contain dynamic text (an id for instance) to be identified on sentry with a common code. _(TODO: if this approach is validated then I have yet to replace Error with dynamic error messages with CustomError)_ 5. Runtime error messages contain technical details that do not mean anything to users (for instance, "Invalid folder ID: ${droppableId}", "ObjectMetadataItem not found", etc.). Let's replace them with "Please refresh the page." to users and keep the message error for sentry and our dev experience (they will still show in the console as uncaught errors).
193 lines
5.8 KiB
TypeScript
193 lines
5.8 KiB
TypeScript
import { CustomError } from '@/error-handler/CustomError';
|
|
import { Select } from '@/ui/input/components/Select';
|
|
import { SelectControl } from '@/ui/input/components/SelectControl';
|
|
import { TextArea } from '@/ui/input/components/TextArea';
|
|
import { TextInputV2 } from '@/ui/input/components/TextInputV2';
|
|
import { Dropdown } from '@/ui/layout/dropdown/components/Dropdown';
|
|
import { DropdownContent } from '@/ui/layout/dropdown/components/DropdownContent';
|
|
import { DropdownMenuItemsContainer } from '@/ui/layout/dropdown/components/DropdownMenuItemsContainer';
|
|
import { ConfigVariableValue } from 'twenty-shared/types';
|
|
import { MenuItemMultiSelect } from 'twenty-ui/navigation';
|
|
import { ConfigVariableType } from '~/generated/graphql';
|
|
import { ConfigVariableOptions } from '../types/ConfigVariableOptions';
|
|
|
|
type ConfigVariableDatabaseInputProps = {
|
|
label: string;
|
|
value: ConfigVariableValue;
|
|
onChange: (value: string | number | boolean | string[] | null) => void;
|
|
type: ConfigVariableType;
|
|
options?: ConfigVariableOptions;
|
|
disabled?: boolean;
|
|
placeholder?: string;
|
|
};
|
|
|
|
export const ConfigVariableDatabaseInput = ({
|
|
label,
|
|
value,
|
|
onChange,
|
|
type,
|
|
options,
|
|
disabled,
|
|
placeholder,
|
|
}: ConfigVariableDatabaseInputProps) => {
|
|
const selectOptions =
|
|
options && Array.isArray(options)
|
|
? options.map((option) => ({
|
|
value: String(option),
|
|
label: String(option),
|
|
}))
|
|
: [];
|
|
|
|
const booleanOptions = [
|
|
{ value: 'true', label: 'true' },
|
|
{ value: 'false', label: 'false' },
|
|
];
|
|
|
|
const isValueSelected = (optionValue: string) => {
|
|
if (!Array.isArray(value)) return false;
|
|
return value.includes(optionValue);
|
|
};
|
|
|
|
const handleMultiSelectChange = (optionValue: string) => {
|
|
if (!Array.isArray(value)) return;
|
|
|
|
let newValues = [...value];
|
|
if (isValueSelected(optionValue)) {
|
|
newValues = newValues.filter((val) => val !== optionValue);
|
|
} else {
|
|
newValues.push(optionValue);
|
|
}
|
|
onChange(newValues);
|
|
};
|
|
|
|
switch (type) {
|
|
case ConfigVariableType.BOOLEAN:
|
|
return (
|
|
<Select
|
|
label={label}
|
|
value={String(value ?? '')}
|
|
onChange={(newValue: string) => onChange(newValue === 'true')}
|
|
disabled={disabled}
|
|
options={booleanOptions}
|
|
dropdownId="config-variable-boolean-select"
|
|
fullWidth
|
|
/>
|
|
);
|
|
|
|
case ConfigVariableType.NUMBER:
|
|
return (
|
|
<TextInputV2
|
|
label={label}
|
|
value={value !== null && value !== undefined ? String(value) : ''}
|
|
onChange={(text) => {
|
|
const num = Number(text);
|
|
onChange(isNaN(num) ? text : num);
|
|
}}
|
|
disabled={disabled}
|
|
placeholder={placeholder}
|
|
type="number"
|
|
fullWidth
|
|
/>
|
|
);
|
|
|
|
case ConfigVariableType.ARRAY:
|
|
return (
|
|
<>
|
|
{options && Array.isArray(options) ? (
|
|
<Dropdown
|
|
dropdownId="config-variable-array-dropdown"
|
|
dropdownPlacement="bottom-start"
|
|
dropdownOffset={{
|
|
y: 8,
|
|
}}
|
|
clickableComponent={
|
|
<SelectControl
|
|
selectedOption={{
|
|
value: '',
|
|
label:
|
|
Array.isArray(value) && value.length > 0
|
|
? value.join(', ')
|
|
: 'Select options',
|
|
}}
|
|
isDisabled={disabled}
|
|
hasRightElement={false}
|
|
selectSizeVariant="default"
|
|
/>
|
|
}
|
|
dropdownComponents={
|
|
<DropdownContent>
|
|
<DropdownMenuItemsContainer>
|
|
{selectOptions.map((option) => (
|
|
<MenuItemMultiSelect
|
|
key={option.value}
|
|
text={option.label}
|
|
selected={isValueSelected(option.value)}
|
|
className="config-variable-array-menu-item-multi-select"
|
|
onSelectChange={() =>
|
|
handleMultiSelectChange(option.value)
|
|
}
|
|
/>
|
|
))}
|
|
</DropdownMenuItemsContainer>
|
|
</DropdownContent>
|
|
}
|
|
/>
|
|
) : (
|
|
<TextArea
|
|
label={label}
|
|
value={
|
|
Array.isArray(value)
|
|
? JSON.stringify(value)
|
|
: String(value ?? '')
|
|
}
|
|
onChange={(text) => {
|
|
try {
|
|
const arr = JSON.parse(text);
|
|
onChange(Array.isArray(arr) ? arr : value);
|
|
} catch {
|
|
onChange(text);
|
|
}
|
|
}}
|
|
disabled={disabled}
|
|
placeholder={placeholder || 'Enter JSON array'}
|
|
/>
|
|
)}
|
|
</>
|
|
);
|
|
|
|
case ConfigVariableType.ENUM:
|
|
return (
|
|
<Select
|
|
label={label}
|
|
value={String(value ?? '')}
|
|
onChange={(newValue: string) => onChange(newValue)}
|
|
disabled={disabled}
|
|
options={selectOptions}
|
|
dropdownId="config-variable-enum-select"
|
|
fullWidth
|
|
/>
|
|
);
|
|
|
|
case ConfigVariableType.STRING:
|
|
return (
|
|
<TextInputV2
|
|
label={label}
|
|
value={
|
|
typeof value === 'string'
|
|
? value
|
|
: value !== null && value !== undefined
|
|
? JSON.stringify(value)
|
|
: ''
|
|
}
|
|
onChange={(text) => onChange(text)}
|
|
disabled={disabled}
|
|
placeholder={placeholder || 'Enter value'}
|
|
fullWidth
|
|
/>
|
|
);
|
|
|
|
default:
|
|
throw new CustomError(`Unsupported type: ${type}`, 'UNSUPPORTED_TYPE');
|
|
}
|
|
};
|