# Introduction In this PR we've migrated `twenty-shared` from a `vite` app [libary-mode](https://vite.dev/guide/build#library-mode) to a [preconstruct](https://preconstruct.tools/) "atomic" application ( in the future would like to introduce preconstruct to handle of all our atomic dependencies such as `twenty-emails` `twenty-ui` etc it will be integrated at the monorepo's root directly, would be to invasive in the first, starting incremental via `twenty-shared`) For more information regarding the motivations please refer to nor: - https://github.com/twentyhq/core-team-issues/issues/587 - https://github.com/twentyhq/core-team-issues/issues/281#issuecomment-2630949682 close https://github.com/twentyhq/core-team-issues/issues/589 close https://github.com/twentyhq/core-team-issues/issues/590 ## How to test In order to ease the review this PR will ship all the codegen at the very end, the actual meaning full diff is `+2,411 −114` In order to migrate existing dependent packages to `twenty-shared` multi barrel new arch you need to run in local: ```sh yarn tsx packages/twenty-shared/scripts/migrateFromSingleToMultiBarrelImport.ts && \ npx nx run-many -t lint --fix -p twenty-front twenty-ui twenty-server twenty-emails twenty-shared twenty-zapier ``` Note that `migrateFromSingleToMultiBarrelImport` is idempotent, it's atm included in the PR but should not be merged. ( such as codegen will be added before merging this script will be removed ) ## Misc - related opened issue preconstruct https://github.com/preconstruct/preconstruct/issues/617 ## Closed related PR - https://github.com/twentyhq/twenty/pull/11028 - https://github.com/twentyhq/twenty/pull/10993 - https://github.com/twentyhq/twenty/pull/10960 ## Upcoming enhancement: ( in others dedicated PRs ) - 1/ refactor generate barrel to export atomic module instead of `*` - 2/ generate barrel own package with several files and tests - 3/ Migration twenty-ui the same way - 4/ Use `preconstruct` at monorepo global level ## Conclusion As always any suggestions are welcomed !
138 lines
3.9 KiB
TypeScript
138 lines
3.9 KiB
TypeScript
import { getMockCreateObjectInput } from 'test/integration/utils/object-metadata/generate-mock-create-object-metadata-input';
|
|
import { performFailingObjectMetadataCreation } from 'test/integration/utils/object-metadata/perform-failing-object-metadata-creation';
|
|
import { EachTestingContext } from 'twenty-shared/testing';
|
|
|
|
import { ErrorCode } from 'src/engine/core-modules/graphql/utils/graphql-errors.util';
|
|
import { CreateObjectInput } from 'src/engine/metadata-modules/object-metadata/dtos/create-object.input';
|
|
|
|
type CreateObjectInputPayload = Omit<
|
|
CreateObjectInput,
|
|
'workspaceId' | 'dataSourceId'
|
|
>;
|
|
|
|
type CreateOneObjectMetadataItemTestingContext = EachTestingContext<
|
|
Partial<CreateObjectInputPayload>
|
|
>[];
|
|
const failingNamesCreationTestsUseCase: CreateOneObjectMetadataItemTestingContext =
|
|
[
|
|
{
|
|
title: 'when nameSingular has invalid characters',
|
|
context: { nameSingular: 'μ' },
|
|
},
|
|
{
|
|
title: 'when namePlural has invalid characters',
|
|
context: { namePlural: 'μ' },
|
|
},
|
|
{
|
|
title: 'when nameSingular is a reserved keyword',
|
|
context: { nameSingular: 'user' },
|
|
},
|
|
{
|
|
title: 'when namePlural is a reserved keyword',
|
|
context: { namePlural: 'users' },
|
|
},
|
|
{
|
|
title: 'when nameSingular is not camelCased',
|
|
context: { nameSingular: 'Not_Camel_Case' },
|
|
},
|
|
{
|
|
title: 'when namePlural is not camelCased',
|
|
context: { namePlural: 'Not_Camel_Case' },
|
|
},
|
|
{
|
|
title: 'when namePlural is an empty string',
|
|
context: { namePlural: '' },
|
|
},
|
|
{
|
|
title: 'when nameSingular is an empty string',
|
|
context: { nameSingular: '' },
|
|
},
|
|
{
|
|
title: 'when nameSingular contains only whitespaces',
|
|
context: { nameSingular: ' ' },
|
|
},
|
|
{
|
|
title: 'when nameSingular contains only one char and whitespaces',
|
|
context: { nameSingular: ' a a ' },
|
|
},
|
|
{
|
|
title: 'when name exceeds maximum length',
|
|
context: { nameSingular: 'a'.repeat(64) },
|
|
},
|
|
{
|
|
title: 'when names are identical',
|
|
context: {
|
|
nameSingular: 'fooBar',
|
|
namePlural: 'fooBar',
|
|
},
|
|
},
|
|
{
|
|
title: 'when names with whitespaces result to be identical',
|
|
context: {
|
|
nameSingular: ' fooBar ',
|
|
namePlural: 'fooBar',
|
|
},
|
|
},
|
|
];
|
|
|
|
const failingLabelsCreationTestsUseCase: CreateOneObjectMetadataItemTestingContext =
|
|
[
|
|
{
|
|
title: 'when labelSingular is empty',
|
|
context: { labelSingular: '' },
|
|
},
|
|
{
|
|
title: 'when labelPlural is empty',
|
|
context: { labelPlural: '' },
|
|
},
|
|
{
|
|
title: 'when labelSingular exceeds maximum length',
|
|
context: { labelSingular: 'A'.repeat(64) },
|
|
},
|
|
{
|
|
title: 'when labelPlural exceeds maximum length',
|
|
context: { labelPlural: 'A'.repeat(64) },
|
|
},
|
|
{
|
|
title: 'when labelSingular contains only whitespace',
|
|
context: { labelSingular: ' ' },
|
|
},
|
|
{
|
|
title: 'when labelPlural contains only whitespace',
|
|
context: { labelPlural: ' ' },
|
|
},
|
|
{
|
|
title: 'when labels are identical',
|
|
context: {
|
|
labelPlural: 'fooBar',
|
|
labelSingular: 'fooBar',
|
|
},
|
|
},
|
|
{
|
|
title: 'when labels with whitespaces result to be identical',
|
|
context: {
|
|
labelPlural: ' fooBar ',
|
|
labelSingular: 'fooBar',
|
|
},
|
|
},
|
|
];
|
|
|
|
const allTestsUseCases = [
|
|
...failingNamesCreationTestsUseCase,
|
|
...failingLabelsCreationTestsUseCase,
|
|
];
|
|
|
|
describe('Object metadata creation should fail', () => {
|
|
it.each(allTestsUseCases)('$title', async ({ context }) => {
|
|
const errors = await performFailingObjectMetadataCreation(
|
|
getMockCreateObjectInput(context),
|
|
);
|
|
|
|
expect(errors.length).toBe(1);
|
|
const firstError = errors[0];
|
|
|
|
expect(firstError.extensions.code).toBe(ErrorCode.BAD_USER_INPUT);
|
|
expect(firstError.message).toMatchSnapshot();
|
|
});
|
|
});
|