Files
twenty/packages/twenty-server/test/integration/metadata/suites/object-metadata/rename-custom-object.integration-spec.ts
Paul Rastoin 9ad8287dbc [REFACTOR] twenty-shared multi barrel and CJS/ESM build with preconstruct (#11083)
# Introduction

In this PR we've migrated `twenty-shared` from a `vite` app
[libary-mode](https://vite.dev/guide/build#library-mode) to a
[preconstruct](https://preconstruct.tools/) "atomic" application ( in
the future would like to introduce preconstruct to handle of all our
atomic dependencies such as `twenty-emails` `twenty-ui` etc it will be
integrated at the monorepo's root directly, would be to invasive in the
first, starting incremental via `twenty-shared`)

For more information regarding the motivations please refer to nor:
- https://github.com/twentyhq/core-team-issues/issues/587
-
https://github.com/twentyhq/core-team-issues/issues/281#issuecomment-2630949682

close https://github.com/twentyhq/core-team-issues/issues/589
close https://github.com/twentyhq/core-team-issues/issues/590

## How to test
In order to ease the review this PR will ship all the codegen at the
very end, the actual meaning full diff is `+2,411 −114`
In order to migrate existing dependent packages to `twenty-shared` multi
barrel new arch you need to run in local:
```sh
yarn tsx packages/twenty-shared/scripts/migrateFromSingleToMultiBarrelImport.ts && \
npx nx run-many -t lint --fix -p twenty-front twenty-ui twenty-server twenty-emails twenty-shared twenty-zapier
```
Note that `migrateFromSingleToMultiBarrelImport` is idempotent, it's atm
included in the PR but should not be merged. ( such as codegen will be
added before merging this script will be removed )

## Misc
- related opened issue preconstruct
https://github.com/preconstruct/preconstruct/issues/617

## Closed related PR
- https://github.com/twentyhq/twenty/pull/11028
- https://github.com/twentyhq/twenty/pull/10993
- https://github.com/twentyhq/twenty/pull/10960

## Upcoming enhancement: ( in others dedicated PRs )
- 1/ refactor generate barrel to export atomic module instead of `*`
- 2/ generate barrel own package with several files and tests
- 3/ Migration twenty-ui the same way
- 4/ Use `preconstruct` at monorepo global level

## Conclusion
As always any suggestions are welcomed !
2025-03-22 19:16:06 +01:00

320 lines
10 KiB
TypeScript

import { makeGraphqlAPIRequest } from 'test/integration/graphql/utils/make-graphql-api-request.util';
import { createOneObjectMetadataFactory } from 'test/integration/metadata/suites/object-metadata/utils/create-one-object-metadata-factory.util';
import { deleteOneObjectMetadataItemFactory } from 'test/integration/metadata/suites/object-metadata/utils/delete-one-object-metadata-factory.util';
import { objectsMetadataFactory } from 'test/integration/metadata/suites/object-metadata/utils/objects-metadata-factory.util';
import { updateOneObjectMetadataItemFactory } from 'test/integration/metadata/suites/object-metadata/utils/update-one-object-metadata-factory.util';
import { createOneRelationMetadataFactory } from 'test/integration/metadata/suites/utils/create-one-relation-metadata-factory.util';
import { deleteOneRelationMetadataItemFactory } from 'test/integration/metadata/suites/utils/delete-one-relation-metadata-factory.util';
import { fieldsMetadataFactory } from 'test/integration/metadata/suites/utils/fields-metadata-factory.util';
import { makeMetadataAPIRequest } from 'test/integration/metadata/suites/utils/make-metadata-api-request.util';
import { FieldMetadataType } from 'twenty-shared/types';
import { RelationMetadataType } from 'src/engine/metadata-modules/relation-metadata/relation-metadata.entity';
const LISTING_NAME_SINGULAR = 'listing';
describe('Custom object renaming', () => {
let listingObjectId = '';
let customRelationId = '';
const STANDARD_OBJECT_RELATIONS = [
'noteTarget',
'attachment',
'favorite',
'taskTarget',
'timelineActivity',
];
const standardObjectRelationsMap = STANDARD_OBJECT_RELATIONS.reduce(
(acc, relation) => ({
...acc,
[relation]: {
objectMetadataId: '',
foreignKeyFieldMetadataId: '',
relationFieldMetadataId: '',
},
}),
{},
);
const standardObjectsGraphqlOperation = objectsMetadataFactory({
gqlFields: `
id
nameSingular
`,
input: {
filter: {
isCustom: { isNot: true },
},
paging: { first: 1000 },
},
});
const fieldsGraphqlOperation = fieldsMetadataFactory({
gqlFields: `
id
name
label
type
object {
id
}
`,
input: {
filter: {},
paging: { first: 1000 },
},
});
const fillStandardObjectRelationsMapObjectMetadataId = (standardObjects) => {
STANDARD_OBJECT_RELATIONS.forEach((relation) => {
standardObjectRelationsMap[relation].objectMetadataId =
standardObjects.body.data.objects.edges.find(
(object) => object.node.nameSingular === relation,
).node.id;
});
};
it('1. should create one custom object with standard relations', async () => {
// Arrange
const standardObjects = await makeMetadataAPIRequest(
standardObjectsGraphqlOperation,
);
fillStandardObjectRelationsMapObjectMetadataId(standardObjects);
const LISTING_OBJECT = {
namePlural: 'listings',
nameSingular: LISTING_NAME_SINGULAR,
labelPlural: 'Listings',
labelSingular: 'Listing',
description: 'Listing object',
icon: 'IconListNumbers',
isLabelSyncedWithName: false,
};
// Act
const graphqlOperation = createOneObjectMetadataFactory({
input: { object: LISTING_OBJECT },
gqlFields: `
id
nameSingular
`,
});
const response = await makeMetadataAPIRequest(graphqlOperation);
// Assert
expect(response.body.data.createOneObject.nameSingular).toBe(
LISTING_NAME_SINGULAR,
);
listingObjectId = response.body.data.createOneObject.id;
const fields = await makeMetadataAPIRequest(fieldsGraphqlOperation);
const foreignKeyFieldsMetadataForListing = fields.body.data.fields.edges
.filter((field) => field.node.name === `${LISTING_NAME_SINGULAR}Id`)
.map((field) => field.node);
const relationFieldsMetadataForListing = fields.body.data.fields.edges
.filter(
(field) =>
field.node.name === `${LISTING_NAME_SINGULAR}` &&
field.node.type === FieldMetadataType.RELATION,
)
.map((field) => field.node);
expect(foreignKeyFieldsMetadataForListing.length).toBe(5);
STANDARD_OBJECT_RELATIONS.forEach((relation) => {
// foreignKey field
const foreignKeyFieldMetadataId = foreignKeyFieldsMetadataForListing.find(
(field) =>
field.object.id ===
standardObjectRelationsMap[relation].objectMetadataId,
).id;
expect(foreignKeyFieldMetadataId).not.toBeUndefined();
standardObjectRelationsMap[relation].foreignKeyFieldMetadataId =
foreignKeyFieldMetadataId;
// relation field
const relationFieldMetadataId = relationFieldsMetadataForListing.find(
(field) =>
field.object.id ===
standardObjectRelationsMap[relation].objectMetadataId,
).id;
expect(relationFieldMetadataId).not.toBeUndefined();
standardObjectRelationsMap[relation].relationFieldMetadataId =
relationFieldMetadataId;
});
});
let relationFieldMetadataOnPersonId = '';
const RELATION_FROM_NAME = 'guest';
it('2. should create a custom relation with the custom object', async () => {
// Arrange
const standardObjects = await makeMetadataAPIRequest(
standardObjectsGraphqlOperation,
);
const personObjectId = standardObjects.body.data.objects.edges.find(
(object) => object.node.nameSingular === 'person',
).node.id;
// Act
const createRelationGraphqlOperation = createOneRelationMetadataFactory({
input: {
relationMetadata: {
fromDescription: '',
fromIcon: 'IconRelationOneToMany',
fromLabel: 'Guest',
fromName: RELATION_FROM_NAME,
fromObjectMetadataId: listingObjectId,
relationType: RelationMetadataType.ONE_TO_MANY,
toDescription: undefined,
toIcon: 'IconListNumbers',
toLabel: 'Property',
toName: 'property',
toObjectMetadataId: personObjectId,
},
},
gqlFields: `
id
fromFieldMetadataId
`,
});
const relationResponse = await makeMetadataAPIRequest(
createRelationGraphqlOperation,
);
// Assert
customRelationId = relationResponse.body.data.createOneRelationMetadata.id;
relationFieldMetadataOnPersonId =
relationResponse.body.data.createOneRelationMetadata.fromFieldMetadataId;
});
it('3. should rename custom object', async () => {
// Arrange
const HOUSE_NAME_SINGULAR = 'house';
const HOUSE_NAME_PLURAL = 'houses';
const HOUSE_LABEL_SINGULAR = 'House';
const HOUSE_LABEL_PLURAL = 'Houses';
const updateListingNameGraphqlOperation =
updateOneObjectMetadataItemFactory({
gqlFields: `
nameSingular
labelSingular
namePlural
labelPlural
`,
input: {
idToUpdate: listingObjectId,
updatePayload: {
nameSingular: HOUSE_NAME_SINGULAR,
namePlural: HOUSE_NAME_PLURAL,
labelSingular: HOUSE_LABEL_SINGULAR,
labelPlural: HOUSE_LABEL_PLURAL,
},
},
});
// Act
const updateListingNameResponse = await makeMetadataAPIRequest(
updateListingNameGraphqlOperation,
);
// Assert
expect(
updateListingNameResponse.body.data.updateOneObject.nameSingular,
).toBe(HOUSE_NAME_SINGULAR);
expect(updateListingNameResponse.body.data.updateOneObject.namePlural).toBe(
HOUSE_NAME_PLURAL,
);
expect(
updateListingNameResponse.body.data.updateOneObject.labelSingular,
).toBe(HOUSE_LABEL_SINGULAR);
expect(
updateListingNameResponse.body.data.updateOneObject.labelPlural,
).toBe(HOUSE_LABEL_PLURAL);
const fieldsResponse = await makeMetadataAPIRequest(fieldsGraphqlOperation);
const fieldsMetadata = fieldsResponse.body.data.fields.edges.map(
(field) => field.node,
);
expect(
fieldsMetadata.find(
(field) => field.name === `${LISTING_NAME_SINGULAR}Id`,
),
).toBeUndefined();
// standard relations have been updated
STANDARD_OBJECT_RELATIONS.forEach((relation) => {
// foreignKey field
const foreignKeyFieldMetadataId =
standardObjectRelationsMap[relation].foreignKeyFieldMetadataId;
const updatedForeignKeyFieldMetadata = fieldsMetadata.find(
(field) => field.id === foreignKeyFieldMetadataId,
);
expect(updatedForeignKeyFieldMetadata.name).toBe(
`${HOUSE_NAME_SINGULAR}Id`,
);
expect(updatedForeignKeyFieldMetadata.label).toBe(
'House ID (foreign key)',
);
// relation field
const relationFieldMetadataId =
standardObjectRelationsMap[relation].relationFieldMetadataId;
const updatedRelationFieldMetadataId = fieldsMetadata.find(
(field) => field.id === relationFieldMetadataId,
);
expect(updatedRelationFieldMetadataId.name).toBe(HOUSE_NAME_SINGULAR);
expect(updatedRelationFieldMetadataId.label).toBe(HOUSE_LABEL_SINGULAR);
});
// custom relation are unchanged
const updatedRelationFieldMetadata = fieldsMetadata.find(
(field) => field.id === relationFieldMetadataOnPersonId,
);
expect(updatedRelationFieldMetadata.name).toBe(RELATION_FROM_NAME);
});
it('4. should delete custom relation', async () => {
const graphqlOperation = deleteOneRelationMetadataItemFactory({
idToDelete: customRelationId,
});
const response = await makeMetadataAPIRequest(graphqlOperation);
const deleteRelationResponse = response.body.data.deleteOneRelation;
expect(deleteRelationResponse.id).toBe(customRelationId);
});
it('5. should delete custom object', async () => {
const graphqlOperation = deleteOneObjectMetadataItemFactory({
idToDelete: listingObjectId,
});
const response = await makeGraphqlAPIRequest(graphqlOperation);
const deleteListingResponse = response.body.data.deleteOneObject;
expect(deleteListingResponse.id).toBe(listingObjectId);
});
});