# Introduction In this PR we've migrated `twenty-shared` from a `vite` app [libary-mode](https://vite.dev/guide/build#library-mode) to a [preconstruct](https://preconstruct.tools/) "atomic" application ( in the future would like to introduce preconstruct to handle of all our atomic dependencies such as `twenty-emails` `twenty-ui` etc it will be integrated at the monorepo's root directly, would be to invasive in the first, starting incremental via `twenty-shared`) For more information regarding the motivations please refer to nor: - https://github.com/twentyhq/core-team-issues/issues/587 - https://github.com/twentyhq/core-team-issues/issues/281#issuecomment-2630949682 close https://github.com/twentyhq/core-team-issues/issues/589 close https://github.com/twentyhq/core-team-issues/issues/590 ## How to test In order to ease the review this PR will ship all the codegen at the very end, the actual meaning full diff is `+2,411 −114` In order to migrate existing dependent packages to `twenty-shared` multi barrel new arch you need to run in local: ```sh yarn tsx packages/twenty-shared/scripts/migrateFromSingleToMultiBarrelImport.ts && \ npx nx run-many -t lint --fix -p twenty-front twenty-ui twenty-server twenty-emails twenty-shared twenty-zapier ``` Note that `migrateFromSingleToMultiBarrelImport` is idempotent, it's atm included in the PR but should not be merged. ( such as codegen will be added before merging this script will be removed ) ## Misc - related opened issue preconstruct https://github.com/preconstruct/preconstruct/issues/617 ## Closed related PR - https://github.com/twentyhq/twenty/pull/11028 - https://github.com/twentyhq/twenty/pull/10993 - https://github.com/twentyhq/twenty/pull/10960 ## Upcoming enhancement: ( in others dedicated PRs ) - 1/ refactor generate barrel to export atomic module instead of `*` - 2/ generate barrel own package with several files and tests - 3/ Migration twenty-ui the same way - 4/ Use `preconstruct` at monorepo global level ## Conclusion As always any suggestions are welcomed !
244 lines
8.8 KiB
TypeScript
244 lines
8.8 KiB
TypeScript
import { makeGraphqlAPIRequest } from 'test/integration/graphql/utils/make-graphql-api-request.util';
|
|
import { updateFeatureFlagFactory } from 'test/integration/graphql/utils/update-feature-flag-factory.util';
|
|
import { createCustomTextFieldMetadata } from 'test/integration/metadata/suites/field-metadata/utils/create-custom-text-field-metadata.util';
|
|
import { createOneFieldMetadataFactory } from 'test/integration/metadata/suites/field-metadata/utils/create-one-field-metadata-factory.util';
|
|
import { deleteOneFieldMetadataItemFactory } from 'test/integration/metadata/suites/field-metadata/utils/delete-one-field-metadata-factory.util';
|
|
import { updateOneFieldMetadataFactory } from 'test/integration/metadata/suites/field-metadata/utils/update-one-field-metadata-factory.util';
|
|
import { createOneObjectMetadataFactory } from 'test/integration/metadata/suites/object-metadata/utils/create-one-object-metadata-factory.util';
|
|
import { createListingCustomObject } from 'test/integration/metadata/suites/object-metadata/utils/create-test-object-metadata.util';
|
|
import { deleteOneObjectMetadataItemFactory } from 'test/integration/metadata/suites/object-metadata/utils/delete-one-object-metadata-factory.util';
|
|
import { deleteOneObjectMetadataItem } from 'test/integration/metadata/suites/object-metadata/utils/delete-one-object-metadata.util';
|
|
import { updateOneObjectMetadataItemFactory } from 'test/integration/metadata/suites/object-metadata/utils/update-one-object-metadata-factory.util';
|
|
import { makeMetadataAPIRequestWithMemberRole } from 'test/integration/metadata/suites/utils/make-metadata-api-request-with-member-role.util';
|
|
import { FieldMetadataType } from 'twenty-shared/types';
|
|
|
|
import { SEED_APPLE_WORKSPACE_ID } from 'src/database/typeorm-seeds/core/workspaces';
|
|
import { ErrorCode } from 'src/engine/core-modules/graphql/utils/graphql-errors.util';
|
|
import { PermissionsExceptionMessage } from 'src/engine/metadata-modules/permissions/permissions.exception';
|
|
|
|
describe('datamodel permissions', () => {
|
|
beforeAll(async () => {
|
|
const enablePermissionsQuery = updateFeatureFlagFactory(
|
|
SEED_APPLE_WORKSPACE_ID,
|
|
'IsPermissionsEnabled',
|
|
true,
|
|
);
|
|
|
|
await makeGraphqlAPIRequest(enablePermissionsQuery);
|
|
});
|
|
afterAll(async () => {
|
|
const disablePermissionsQuery = updateFeatureFlagFactory(
|
|
SEED_APPLE_WORKSPACE_ID,
|
|
'IsPermissionsEnabled',
|
|
false,
|
|
);
|
|
|
|
await makeGraphqlAPIRequest(disablePermissionsQuery);
|
|
});
|
|
describe('fieldMetadata', () => {
|
|
let listingObjectId = '';
|
|
let testFieldId = '';
|
|
|
|
beforeAll(async () => {
|
|
const { objectMetadataId: createdObjectId } =
|
|
await createListingCustomObject();
|
|
|
|
listingObjectId = createdObjectId;
|
|
|
|
const { fieldMetadataId: createdFieldMetadaId } =
|
|
await createCustomTextFieldMetadata(createdObjectId);
|
|
|
|
testFieldId = createdFieldMetadaId;
|
|
});
|
|
afterAll(async () => {
|
|
await deleteOneObjectMetadataItem(listingObjectId);
|
|
});
|
|
describe('createOne', () => {
|
|
it('should throw a permission error when user does not have permission (member role)', async () => {
|
|
// Arrange
|
|
const FIELD_NAME = 'testFieldForCreateOne';
|
|
const createFieldInput = {
|
|
name: FIELD_NAME,
|
|
label: 'Test Field For CreateOne',
|
|
type: FieldMetadataType.TEXT,
|
|
objectMetadataId: listingObjectId,
|
|
};
|
|
|
|
// Act
|
|
const graphqlOperation = createOneFieldMetadataFactory({
|
|
input: { field: createFieldInput },
|
|
gqlFields: `
|
|
id
|
|
name
|
|
`,
|
|
});
|
|
|
|
const response =
|
|
await makeMetadataAPIRequestWithMemberRole(graphqlOperation);
|
|
|
|
// Assert
|
|
expect(response.body.data).toBeNull();
|
|
expect(response.body.errors).toBeDefined();
|
|
expect(response.body.errors[0].message).toBe(
|
|
PermissionsExceptionMessage.PERMISSION_DENIED,
|
|
);
|
|
expect(response.body.errors[0].extensions.code).toBe(
|
|
ErrorCode.FORBIDDEN,
|
|
);
|
|
});
|
|
});
|
|
|
|
describe('updateOne', () => {
|
|
it('should throw a permission error when user does not have permission (member role)', async () => {
|
|
// Arrange
|
|
const updateFieldInput = {
|
|
name: 'updatedName',
|
|
label: 'Updated Name',
|
|
};
|
|
|
|
const graphqlOperation = updateOneFieldMetadataFactory({
|
|
input: { id: testFieldId, update: updateFieldInput },
|
|
gqlFields: `
|
|
id
|
|
name
|
|
`,
|
|
});
|
|
|
|
const response =
|
|
await makeMetadataAPIRequestWithMemberRole(graphqlOperation);
|
|
|
|
// Assert
|
|
expect(response.body.data).toBeNull();
|
|
expect(response.body.errors).toBeDefined();
|
|
expect(response.body.errors[0].message).toBe(
|
|
PermissionsExceptionMessage.PERMISSION_DENIED,
|
|
);
|
|
expect(response.body.errors[0].extensions.code).toBe(
|
|
ErrorCode.FORBIDDEN,
|
|
);
|
|
});
|
|
});
|
|
|
|
describe('deleteOne', () => {
|
|
it('should throw a permission error when user does not have permission (member role)', async () => {
|
|
// Arrange
|
|
const graphqlOperation = deleteOneFieldMetadataItemFactory({
|
|
idToDelete: testFieldId,
|
|
});
|
|
|
|
const response =
|
|
await makeMetadataAPIRequestWithMemberRole(graphqlOperation);
|
|
|
|
// Assert
|
|
expect(response.body.data).toBeNull();
|
|
expect(response.body.errors).toBeDefined();
|
|
expect(response.body.errors[0].message).toBe(
|
|
PermissionsExceptionMessage.PERMISSION_DENIED,
|
|
);
|
|
expect(response.body.errors[0].extensions.code).toBe(
|
|
ErrorCode.FORBIDDEN,
|
|
);
|
|
});
|
|
});
|
|
});
|
|
|
|
describe('objectMetadata', () => {
|
|
describe('createOne', () => {
|
|
it('should throw a permission error when user does not have permission (member role)', async () => {
|
|
// Arrange
|
|
const graphqlOperation = createOneObjectMetadataFactory({
|
|
gqlFields: `
|
|
id
|
|
`,
|
|
input: {
|
|
object: {
|
|
labelPlural: 'Test Objects',
|
|
labelSingular: 'Test Object',
|
|
namePlural: 'testObjects',
|
|
nameSingular: 'testObject',
|
|
},
|
|
},
|
|
});
|
|
|
|
const response =
|
|
await makeMetadataAPIRequestWithMemberRole(graphqlOperation);
|
|
|
|
// Assert
|
|
expect(response.body.data).toBeNull();
|
|
expect(response.body.errors).toBeDefined();
|
|
expect(response.body.errors[0].message).toBe(
|
|
PermissionsExceptionMessage.PERMISSION_DENIED,
|
|
);
|
|
expect(response.body.errors[0].extensions.code).toBe(
|
|
ErrorCode.FORBIDDEN,
|
|
);
|
|
});
|
|
});
|
|
|
|
describe('update and delete a custom object', () => {
|
|
let listingObjectId = '';
|
|
|
|
beforeAll(async () => {
|
|
const { objectMetadataId: createdObjectId } =
|
|
await createListingCustomObject();
|
|
|
|
listingObjectId = createdObjectId;
|
|
});
|
|
afterAll(async () => {
|
|
await deleteOneObjectMetadataItem(listingObjectId);
|
|
});
|
|
describe('updateOne', () => {
|
|
it('should throw a permission error when user does not have permission (member role)', async () => {
|
|
// Arrange
|
|
const graphqlOperation = updateOneObjectMetadataItemFactory({
|
|
gqlFields: `
|
|
id
|
|
`,
|
|
input: {
|
|
idToUpdate: listingObjectId,
|
|
updatePayload: {
|
|
labelPlural: 'Updated Test Objects',
|
|
labelSingular: 'Updated Test Object',
|
|
},
|
|
},
|
|
});
|
|
|
|
const response =
|
|
await makeMetadataAPIRequestWithMemberRole(graphqlOperation);
|
|
|
|
// Assert
|
|
expect(response.body.data).toBeNull();
|
|
expect(response.body.errors).toBeDefined();
|
|
expect(response.body.errors[0].message).toBe(
|
|
PermissionsExceptionMessage.PERMISSION_DENIED,
|
|
);
|
|
expect(response.body.errors[0].extensions.code).toBe(
|
|
ErrorCode.FORBIDDEN,
|
|
);
|
|
});
|
|
});
|
|
describe('deleteOne', () => {
|
|
it('should throw a permission error when user does not have permission (member role)', async () => {
|
|
// Arrange
|
|
const graphqlOperation = deleteOneObjectMetadataItemFactory({
|
|
idToDelete: listingObjectId,
|
|
});
|
|
|
|
const response =
|
|
await makeMetadataAPIRequestWithMemberRole(graphqlOperation);
|
|
|
|
// Assert
|
|
expect(response.body.data).toBeNull();
|
|
expect(response.body.errors).toBeDefined();
|
|
expect(response.body.errors[0].message).toBe(
|
|
PermissionsExceptionMessage.PERMISSION_DENIED,
|
|
);
|
|
expect(response.body.errors[0].extensions.code).toBe(
|
|
ErrorCode.FORBIDDEN,
|
|
);
|
|
});
|
|
});
|
|
});
|
|
});
|
|
});
|